From: Praveenkumar I <quic_ipkumar@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <quic_varada@quicinc.com>, <quic_clew@quicinc.com>
Subject: Re: [PATCH] soc: qcom: qmi_encdec: Restrict string length in decode
Date: Mon, 31 Jul 2023 15:25:20 +0530 [thread overview]
Message-ID: <6920de01-2c32-eae8-2ca8-f04ae3a3bed8@quicinc.com> (raw)
In-Reply-To: <4377ba5a-deab-1f24-c785-c90965991af1@linaro.org>
On 7/31/2023 2:48 PM, Konrad Dybcio wrote:
> On 31.07.2023 11:14, Praveenkumar I wrote:
>> The QMI TLV value for strings in a lot of qmi element info structures
>> account for null terminated strings with MAX_LEN + 1. If a string is
>> actually MAX_LEN + 1 length, this will cause an out of bounds access
>> when the NULL character is appended in decoding.
>>
>> Signed-off-by: Chris Lew <quic_clew@quicinc.com>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> ---
> Fixes + Cc: stable?
Sure, will add.
>
> Konrad
--
Thanks,
Praveenkumar
prev parent reply other threads:[~2023-07-31 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 9:14 Praveenkumar I
2023-07-31 9:18 ` Konrad Dybcio
2023-07-31 9:55 ` Praveenkumar I [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6920de01-2c32-eae8-2ca8-f04ae3a3bed8@quicinc.com \
--to=quic_ipkumar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_clew@quicinc.com \
--cc=quic_varada@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®