From: Ira Weiny <ira.weiny@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Mike Rapoport <rppt@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>, <nvdimm@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH next] nvdimm: Prevent integer overflow in ramdax_get_config_data()
Date: Tue, 25 Nov 2025 10:38:29 -0600 [thread overview]
Message-ID: <6925db85a9343_63977100fd@iweiny-mobl.notmuch> (raw)
In-Reply-To: <aSW0-9cJcTMTynTj@stanley.mountain>
Dan Carpenter wrote:
> The "cmd->in_offset" variable comes from the user via the __nd_ioctl()
> function. The problem is that the "cmd->in_offset + cmd->in_length"
> addition could have an integer wrapping issue if cmd->in_offset is close
> to UINT_MAX . The "cmd->in_length" variable has been capped, but the
> "cmd->in_offset" variable has not. Both of these variables are type u32.
Does ramdax_set_config_data() also need this? I'm not quite following
where in_length is capped so I'm inclined to add size_add in both set and
get.
Ira
>
> Fixes: 43bc0aa19a21 ("nvdimm: allow exposing RAM carveouts as NVDIMM DIMM devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/nvdimm/ramdax.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvdimm/ramdax.c b/drivers/nvdimm/ramdax.c
> index 63cf05791829..faa6f3101972 100644
> --- a/drivers/nvdimm/ramdax.c
> +++ b/drivers/nvdimm/ramdax.c
> @@ -143,7 +143,7 @@ static int ramdax_get_config_data(struct nvdimm *nvdimm, int buf_len,
> return -EINVAL;
> if (struct_size(cmd, out_buf, cmd->in_length) > buf_len)
> return -EINVAL;
> - if (cmd->in_offset + cmd->in_length > LABEL_AREA_SIZE)
> + if (size_add(cmd->in_offset, cmd->in_length) > LABEL_AREA_SIZE)
> return -EINVAL;
>
> memcpy(cmd->out_buf, dimm->label_area + cmd->in_offset, cmd->in_length);
> --
> 2.51.0
>
next prev parent reply other threads:[~2025-11-25 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 13:54 Dan Carpenter
2025-11-25 16:38 ` Ira Weiny [this message]
2025-11-25 18:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6925db85a9343_63977100fd@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rppt@kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®