From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AC9B314A95 for ; Wed, 21 Jan 2026 13:59:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003956; cv=none; b=JhesJiSBB8sIcpSbGZX6uFhsM44YQCaXFyoI4f3ib+5TxqJwzQxDpAXt4/ISvGC5fU4n/cm7gPu6IdKrnT2xt0xPnc5cK0WfH/umA0WLAGjBo8+guhh1DVYd/rrwzoUsOp0bw8pTfoyIqho5T9JGB6IdE6GVL3ie5tPV8mS9jJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003956; c=relaxed/simple; bh=5VacMTYe6cp5/byRDguRcp4YLOf0wgJLoddNf3NdJOk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZjT0ep4vbDNS7C189UKs0R+aeKGBmW7FO7w5FIRj9+OBREycHkWpS2h0CeMI/jyZA2CyntcpXY0KQvTcDHjfUYxspYBgDNI2794WWKEdQqHCo6lKzn4Qmm+Jzsun4nLdfJuBnc95Tx3HNzFRsW6x50SjekvnHeTOd4YUNlfPmic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IErEx/88; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ob0vWVgv; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IErEx/88"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ob0vWVgv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769003954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5VacMTYe6cp5/byRDguRcp4YLOf0wgJLoddNf3NdJOk=; b=IErEx/8869+1Vi5gr8aTw039z2Txceg7rTy5U7h0qNgccZDetFrI9cEBLFhrVAxpO5Syo6 xUKYzDJPVRDbc2LQFoNfSXIbmSsNAU1+2tVQfjOiirsumd1O/rSqYP7MGhKPEJr71MYDT+ rxH+7w8goqf8OLncqUlqtIfgwA726oE= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-5-qA65NQzsOlegFE5zfR4zKA-1; Wed, 21 Jan 2026 08:59:13 -0500 X-MC-Unique: qA65NQzsOlegFE5zfR4zKA-1 X-Mimecast-MFC-AGG-ID: qA65NQzsOlegFE5zfR4zKA_1769003952 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-b872c88d115so943842666b.2 for ; Wed, 21 Jan 2026 05:59:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769003952; x=1769608752; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=5VacMTYe6cp5/byRDguRcp4YLOf0wgJLoddNf3NdJOk=; b=Ob0vWVgvTctY0DVxV8qohnOUGrRidnql6IMlSsFNiq9l9+K/DJudTLIrqJCd8bYdb0 MZDtOBvEhVys2RbTo2jqrWJ4Ou+ViN483nLTAUVcQ6da7VzQiaGBquunLaBAqexzzHBg gsPV/PQFno0VW8W010kpyHOV5p6BZFhBvxxVYAxPILZUhv84o/I/BVn4R8UfpcXlDA8O Q4UDStuFgzdFjomYUzq5dRk5adSU2dIfxPr4BJtuRTNjDNIIONVGBxi3mEmBOgjcVgLb 5C4p94uv6gLaYJMdqvRKTMdRdJGQtE5ujjDImADW1zC3Vpt9NQqCFjlU+ZTBSJmdAo+c veGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769003952; x=1769608752; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5VacMTYe6cp5/byRDguRcp4YLOf0wgJLoddNf3NdJOk=; b=lCOvkeClA9251Ky2TyStNt4kCvnRLrwacHO8ceKsRuh3Ah3uf9Fm5S+U7vxeBmrG+7 5q9jrHM/f6tbVAQd6i3c0IxX8Wk7mKjp32lLYi/1ItZTr/MKmJSX3pAhghKVZYXyWtqC KQbdA+U8m3PI1MkZLLze+ziran6uYeeqyT3fb85N37gCuPta79PF6x5tKNPfN4cQmNbO dY4RpLjeBW/fd0fAmIXCyy43t2o0CJcVAAu0ZL1HIABnzMv3FYFNzNbIoC5u23SK1Fcq kIHjxWzruMuGd0tX20RpEsnvddbE6nY63g1oHM97ftsf9ZegnVP1XSTbl9z6be1UDW3V 8mfg== X-Forwarded-Encrypted: i=1; AJvYcCVfXVcSo4o1g4TsO6WryPek615eC7748Cs3nxGVx8r/D7UIaigyhy/L9XYioIsB+Q9kcLHnpqL4wUO4HE0=@vger.kernel.org X-Gm-Message-State: AOJu0YwWUBRUI0PLgxAGc4NGXkI507zosW3mjSrXhLSCep4XJXbF8Ruu EaPhTK4VRVQzpD2JSCChHMZjDefKK5HXmBov2a3YSelUq+1bbSkr+Uh7fObLxjvISy/j/MxW4dv yAVFvtcqK6UDBg7CtveR8nGR8zbOMZuF2YBvC3ENWXKwqepBppmD3HEeatMc0xi1ihzk9MCrdjW j5 X-Gm-Gg: AZuq6aIMtSwdbuE2dwUHfRY9rcOwBogheQzGDSCNgIV7bnfDLPX+ftarEfBHtDFtozE 4/OX2HXe5xZlM5JEx0vOmhtYNl35Fq40gGUYbUvKuwlU7DywtTn98MSPM9/nBKUsotN5JwPXanR Yhg4Q1lz33y2wYcYWOtCpLG+B401/1IGNm9PQ4BL53oqXQmsm/8Jl9Ad7WUtf1ekkAeN8+VJXCg X74Q1/81J/TmJR7BimCbfSLbq32S/22vtO1yCyDHJyyBHJNxqCfzSah66/x/zyDyp1Q7l0/n8Yx S3vLqtHqze2uJX6b5uv7aizHDGoV8zexiRK0/RLxhESINpHt+pJYxNBfi71DKeejChzBTREkfNM YYhV9Wn+DQsOqrGsmbeSvX4AgaYPNv7uW5abvdkBuH4fXB0Jrk01paK/e9fqz4odSePtUlIkBph 6E/xGILuX/ X-Received: by 2002:a17:907:930a:b0:b80:3846:d46 with SMTP id a640c23a62f3a-b8792d5a7a8mr1728874566b.20.1769003951693; Wed, 21 Jan 2026 05:59:11 -0800 (PST) X-Received: by 2002:a17:907:930a:b0:b80:3846:d46 with SMTP id a640c23a62f3a-b8792d5a7a8mr1728872666b.20.1769003951168; Wed, 21 Jan 2026 05:59:11 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795168b9bsm1592365666b.16.2026.01.21.05.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 05:59:10 -0800 (PST) Message-ID: <69298b5dcfda02051c5c1fe995efc333f980664f.camel@redhat.com> Subject: Re: [PATCH 19/26] rv/rvgen: add abstract method stubs to Container class From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Wed, 21 Jan 2026 14:59:09 +0100 In-Reply-To: <20260119205601.105821-20-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-20-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > The Container class extends RVGenerator but was missing implementations > for several abstract methods decorated with @not_implemented in the base > class. This could lead to NotImplementedError exceptions if code paths > attempt to call these methods on Container instances. >=20 > Add empty-string returning stub implementations for > fill_tracepoint_handlers_skel, > fill_tracepoint_attach_probe, fill_tracepoint_detach_helper, and > fill_monitor_class_type. These empty returns are semantically correct > since Container is a grouping mechanism for organizing monitors, not an > actual monitor that generates tracepoint-specific C code. >=20 > Signed-off-by: Wander Lairson Costa > --- Just like the previous patch, the NotImplementedError here highlights a wea= kness in the design we should improve instead of cover. If all those fillers don't make sense for containers, we should instead mov= e them to Monitor and leave RVGenerator alone. Thanks, Gabriele > =C2=A0tools/verification/rvgen/rvgen/container.py | 12 ++++++++++++ > =C2=A01 file changed, 12 insertions(+) >=20 > diff --git a/tools/verification/rvgen/rvgen/container.py > b/tools/verification/rvgen/rvgen/container.py > index 51f188530b4dd..65df21dfd17b2 100644 > --- a/tools/verification/rvgen/rvgen/container.py > +++ b/tools/verification/rvgen/rvgen/container.py > @@ -30,3 +30,15 @@ class Container(generator.RVGenerator): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 self._kconfig_marker(), container_marker) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = return result > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return result + containe= r_marker > + > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_handlers_skel(self) -> str: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "" > + > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_attach_probe(self) -> str: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "" > + > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_detach_helper(self) -> str: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "" > + > +=C2=A0=C2=A0=C2=A0 def fill_monitor_class_type(self) -> str: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return ""