From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: Ian Rogers <irogers@google.com>, colin.i.king@gmail.com
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
linux-perf-users <linux-perf-users@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] perf: fix spelling mistake "parametrized" -> "parameterized"
Date: Wed, 4 Oct 2023 13:43:28 +0530 [thread overview]
Message-ID: <6929FC3F-06F4-45D1-96D4-0ABF86EA8698@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAP-5=fXO6+Cgvo4BmC9fgL70FY+ciPjRVR5qghxYBR3VSB7WNQ@mail.gmail.com>
> On 04-Oct-2023, at 6:37 AM, Ian Rogers <irogers@google.com> wrote:
>
> On Tue, Oct 3, 2023 at 12:49 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>>
>> There are spelling mistakes in comments and a pr_debug message. Fix them.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> + Athira Rajeev
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com <mailto:atrajeev@linux.vnet.ibm.com>>
Thanks
Athira
>
> Thanks,
> Ian
>
>> ---
>> tools/perf/tests/parse-events.c | 4 ++--
>> tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/perf/tests/parse-events.c b/tools/perf/tests/parse-events.c
>> index f78be21a5999..e52f45c7c3d1 100644
>> --- a/tools/perf/tests/parse-events.c
>> +++ b/tools/perf/tests/parse-events.c
>> @@ -2549,7 +2549,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>> if (strchr(ent->d_name, '.'))
>> continue;
>>
>> - /* exclude parametrized ones (name contains '?') */
>> + /* exclude parameterized ones (name contains '?') */
>> n = snprintf(pmu_event, sizeof(pmu_event), "%s%s", path, ent->d_name);
>> if (n >= PATH_MAX) {
>> pr_err("pmu event name crossed PATH_MAX(%d) size\n", PATH_MAX);
>> @@ -2578,7 +2578,7 @@ static int test__pmu_events(struct test_suite *test __maybe_unused, int subtest
>> fclose(file);
>>
>> if (is_event_parameterized == 1) {
>> - pr_debug("skipping parametrized PMU event: %s which contains ?\n", pmu_event);
>> + pr_debug("skipping parameterized PMU event: %s which contains ?\n", pmu_event);
>> continue;
>> }
>>
>> diff --git a/tools/perf/tests/shell/stat_all_pmu.sh b/tools/perf/tests/shell/stat_all_pmu.sh
>> index c77955419173..d2a3506e0d19 100755
>> --- a/tools/perf/tests/shell/stat_all_pmu.sh
>> +++ b/tools/perf/tests/shell/stat_all_pmu.sh
>> @@ -4,7 +4,7 @@
>>
>> set -e
>>
>> -# Test all PMU events; however exclude parametrized ones (name contains '?')
>> +# Test all PMU events; however exclude parameterized ones (name contains '?')
>> for p in $(perf list --raw-dump pmu | sed 's/[[:graph:]]\+?[[:graph:]]\+[[:space:]]//g'); do
>> echo "Testing $p"
>> result=$(perf stat -e "$p" true 2>&1)
>> --
>> 2.39.2
>>
next prev parent reply other threads:[~2023-10-04 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 7:49 Colin Ian King
2023-10-04 1:07 ` Ian Rogers
2023-10-04 8:13 ` Athira Rajeev [this message]
2023-11-06 21:35 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6929FC3F-06F4-45D1-96D4-0ABF86EA8698@linux.vnet.ibm.com \
--to=atrajeev@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=colin.i.king@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®