mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Antonio Vargas <windenntw@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
	leonid.i.ananiev@intel.com, axboe@suse.de,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 1/1] elevator: indirect function calls reducing
Date: Thu, 1 Dec 2005 02:11:52 +0100	[thread overview]
Message-ID: <69304d110511301711s2ade7fd6p667c1f160121967@mail.gmail.com> (raw)
In-Reply-To: <6694B22B6436BC43B429958787E45498E7877C@mssmsx402nb>

On 11/30/05, Ananiev, Leonid I <leonid.i.ananiev@intel.com> wrote:
> Christoph,
> During that function calls 3 memory ridings are performed under
> spin_lock and having cache miss/conflict problem;
> and 2 only main memory ridings after patching.
>
> In a source a[b][c][d](arg);
> after patching number of memory ridings less by 1:
> a[c][d](arg);
> Do you agree with it?
> Have you other explanation of performance degradation 2.6.9 -> 2.6.10?
>
> Leonid
>

Leonid, you are "just" removing a memory fetch by embeding the struct
instead of pointing to it, not removing a whole indirect jump...
granted it's good to remove innecesary mem-fetchs, but then please
call the patch that, a removal of not-necessary mem-fetches.

>
> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Wednesday, November 30, 2005 7:26 PM
> To: Ananiev, Leonid I
> Cc: linux-kernel@vger.kernel.org; axboe@suse.de
> Subject: Re: [PATCH 1/1] elevator: indirect function calls reducing
>
>
> this _still_ isn't an indirect function call reduction and people
> have told you N times.  Please get your basics right first, to start
> with the patch description.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



--
Greetz, Antonio Vargas aka winden of network

http://wind.codepixel.com/
windNOenSPAMntw@gmail.com
thesameasabove@amigascne.org

Every day, every year
you have to work
you have to study
you have to scene.

  reply	other threads:[~2005-12-01  1:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-30 18:05 Ananiev, Leonid I
2005-12-01  1:11 ` Antonio Vargas [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-11-30 13:53 Ananiev, Leonid I
2005-11-30 16:26 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69304d110511301711s2ade7fd6p667c1f160121967@mail.gmail.com \
    --to=windenntw@gmail.com \
    --cc=arjan@infradead.org \
    --cc=axboe@suse.de \
    --cc=hch@infradead.org \
    --cc=leonid.i.ananiev@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®