From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>, mmayer@broadcom.com
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] memory: brcmstb_dpfe: validate firmware section sizes
Date: Fri, 4 Sep 2026 15:53:55 +0200 [thread overview]
Message-ID: <69308cfc-c054-42e8-93a2-acc3ac25bb06@kernel.org> (raw)
In-Reply-To: <20260815134559.47888-1-pengpeng@iscas.ac.cn>
On 15/08/2026 15:45, Pengpeng Hou wrote:
> The firmware header is read before the image has been shown to contain a
> complete header. In addition, the final size check adds two
> firmware-provided u32 section lengths before comparing the result with
> fw->size, so the addition can wrap.
>
> Reject images shorter than the fixed header and checksum before reading
> the header. Then derive the available payload length with subtraction and
> require the two declared sections to fill it exactly.
>
> Fixes: 2f330caff577 ("memory: brcmstb: Add driver for DPFE")
>
There is no blank line around tags.
> Assisted-by: Codex:gpt-5
So if you ask some LLM tools, then ask them how to write correct Linux
kernel commit, please.
Applied.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-04 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 13:45 Pengpeng Hou
2026-09-04 13:53 ` Krzysztof Kozlowski [this message]
2026-09-04 13:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69308cfc-c054-42e8-93a2-acc3ac25bb06@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®