From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdJEOiI (ORCPT ); Thu, 5 Oct 2017 10:38:08 -0400 Received: from mail-eopbgr50040.outbound.protection.outlook.com ([40.107.5.40]:47254 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751330AbdJEOiG (ORCPT ); Thu, 5 Oct 2017 10:38:06 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ed.blake@sondrel.com; Subject: Re: [PATCH 3/4] irqchip: imgpdc: Set sys wake polarities to active high To: James Hogan Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linux-kernel@vger.kernel.org References: <1506938159-466-1-git-send-email-ed.blake@sondrel.com> <1506938159-466-4-git-send-email-ed.blake@sondrel.com> <20171004131453.GF25320@jhogan-linux.le.imgtec.org> From: Ed Blake Message-ID: <69323cb5-5b23-52cc-f4cb-a07dfa3e7d18@sondrel.com> Date: Thu, 5 Oct 2017 15:37:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171004131453.GF25320@jhogan-linux.le.imgtec.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [195.88.9.101] X-ClientProxiedBy: DB6PR07CA0015.eurprd07.prod.outlook.com (2603:10a6:6:2d::25) To DB6P191MB0008.EURP191.PROD.OUTLOOK.COM (2603:10a6:4:8b::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47b2f33c-e2a1-4f8c-0810-08d50bfeaf8f X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB6P191MB0008; X-Microsoft-Exchange-Diagnostics: 1;DB6P191MB0008;3:wc5qKMzBU6msjZunvFeg1rA1dS7adAEUHgmfuij/bZir7EmAezoGYV8/0TfRw67xH0k7xVUFpOpL4vJhDXTEPEn/2u39hf3DVgwCJ9p7XyxNpwlsBAdVP3BO0DIcEP0/PuDjL4aaux6TUNcZ3SpVDPFUTrZ0iFNc3AhcX3D92pHjDbRQrda5V7m/i6C6MSxcNMofuRcpQDdo9efE2+eIYWVsaSO5rgMOOW41G0zSTg3mKS2ZMVqvIWDv8UOqht10;25:U/qs4+DJOnkdMsuItfgABpbUVeaT0nedEU5+nzNypKDhB8GfXcC5thXSmntYJkDtuvY1/zAaBZdkW/+yz6uVXVb5rO8EqvRcudoi4e8ID3zKb5e/G0as8ZperDiM+wLlWssbTQ9tCqHbVpBk9TQhqv3hIf0yYFhrPWn68EmtPUpqvOkTX5y+CnFsHyjyFIHi0Cf8dXgOQwcAUhkZv5U94aK1WnjDNO71YfsaJHksZGE3arXmasmDz3jvdiz/P5GongT+Yvj2DmUUF/EC1bX7Pvn+K1y0hvGBku8D94eQh4bCw1qCmDld6SKb4vFZbQZnNG+6YZLzkrOXirlAdxrO9Q==;31:N88sLmTvSaIple+mIOTVy9lOPBZ8Tf4/QWvk1pOgCFVuCLAkLZUbOHtlMTqYubEWq5k0+DFXTFhuHOCGm/oHSdawqsLptI3Nw60gA6jo9twsd+Pe+Nx4N3YIm08R1fDNsZ0QuqircVcCHN0+sunMXmi1Of8a8qVrsHmYd2gg8H44TrmagOQuUJ5pGtMbC8QlTmGvb5ct9VdyLKyEUxGRiKQ9+8BBsnIQ7ShJm6eEjZk= X-MS-TrafficTypeDiagnostic: DB6P191MB0008: X-Microsoft-Exchange-Diagnostics: 1;DB6P191MB0008;20:U85SL3vLlewyps3vczvp4gQUHCGavqApl0Ych+CbJvnmf5YTD8KqXVQM9WdPzT0XZVBFDJjgHn2PsqsUe0K6qoazD5AIChpfZLkWynC3mbmWmvXC9Lau4UKj8QkpP42KMasAewAWhj1DslcJvkDqgdnjXDq0GNXXUDQ9e/JU5j10es6SwcIlylOxxyvvkVHavFLKzx9aYeBJNX/4Y2LxNqxtnObdGHREZysjPiyHHouFoJCIQq25YbJV9VfBugQs;4:KW3Qdegc07LBT3Zumw2KDtsQVbpfgzM78z3ZHEBeTGgPEAfNXV8vr9j8syOd/+eYeuFbRepKVKPdzjA7LRNyEHoAegkchfLSGZN26y0q6vxsOJjI21sr+yZfbjzfN3tB8bEkrpNuRcytoMzdtSrP/qL7FSZ8sQ5J/S8Qp2sHQEo89Bl4dQ1JKbZrze8ABK9CG3hR+3qDlTfdY6bOQjDY/RE3lgEB0u0clYWHub2EDAomzF6TtkIuYwR/aoW5dlUP X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6P191MB0008;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6P191MB0008; X-Forefront-PRVS: 04519BA941 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(346002)(39830400002)(24454002)(199003)(51914003)(189002)(65826007)(83506001)(4326008)(2906002)(101416001)(81166006)(5660300001)(65956001)(230700001)(50466002)(31686004)(81156014)(6666003)(478600001)(8676002)(58126008)(97736004)(6246003)(189998001)(23676002)(6116002)(66066001)(65806001)(3846002)(53546010)(25786009)(50986999)(229853002)(6916009)(2950100002)(47776003)(33646002)(36756003)(8936002)(64126003)(76176999)(54356999)(53936002)(86362001)(77096006)(16576012)(106356001)(7736002)(105586002)(68736007)(6486002)(305945005)(316002)(31696002)(16526018)(473944003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6P191MB0008;H:[10.40.8.170];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQMTkxTUIwMDA4OzIzOmpYVDdpbHBqVWdsSmJlbXErMldSNmkvam9P?= =?utf-8?B?cDcyN1owTmhBbjgrWDlFQTVOL3VJekdyRElBK1Y2VXI3MkJhT082WDZxditX?= =?utf-8?B?NjNYZGREamZkaGVnckFQQ2ptN1hndmNzZVk5NXEycEFaOEtMZFZZbmRkamxW?= =?utf-8?B?bWswYjNESXlGTm9DdnczQzhoNExhdnlTd2tPMmdrcU1GSjdhTVlza3RBakhh?= =?utf-8?B?eTRLNXE1VDNRMTZXZGhMcDRwbURWakM5UlUvc1hCdG5LdENKcEdodnlyc3BP?= =?utf-8?B?TXhkOFJlMHRTUVpobTl0L3FWbVc5NmdWM0dpTUZBaEtRR2lwYmxlU0lTaUtt?= =?utf-8?B?NlR0ZkgvSHRKMGVLVVQ0RDFkWHRMQVgrMmFrY2gzbUFXMmRZclpQWEo5Z1dr?= =?utf-8?B?SzdZaFZSclU1YkdqdEl5Vk92WVBLLy83UzNJZnpYYUpZRTkrOXlWaGlZMjBk?= =?utf-8?B?WVAyWENabjUzbDhINCt0VEFtb3VoM2VGOEtDZWlnVTVLazNJOUpqUzUzeWk3?= =?utf-8?B?cVlxV1huOU5YMmlMZlhiaFREK2xLaGJXbk1iVWs3RndjNi9qZHNDV1ZERXY2?= =?utf-8?B?SGMxOUZnN1ZqNDV2eWo3bFViN21INzhVWjdKbnJ1NnV5TEdOVVd0UGNrZVBS?= =?utf-8?B?Vm1pV0ZlOVBZMUFoa2lQRWk2TjRMK3EycXdCcjVaVjhSOGNsTEZHSzZWdEs1?= =?utf-8?B?TUs0RTBSOFVmSG9ubURUS2JzaWNPWFdkK0JNQnUvSXhHR0hFUXR2enFXYk1j?= =?utf-8?B?aDdmZk9FWXAwRVlPaGZnc0o1WGFOU1cyV0tEdHh5Y2g2Nlo2ejRvdzNpWVFI?= =?utf-8?B?Z2JITXJYOXRvTG9IMW1RY3JxbVRnanUzVDg5VzFvczlJc2k3c2Q4elp5MmQ0?= =?utf-8?B?dnhWQ0tDSkxQVGdUd1lGZnhRUk1KTDg4R2FSbDRKYmZlbHF1Rkg2UE9WT1ps?= =?utf-8?B?QXRRU09mOVQ4NUVxOGRwTU44d2tSbFpvYy91dUNDMnl3Vm5POFlDUGkyOTli?= =?utf-8?B?TkVGSWV0Tlc0aExLdk4vNVVGN1Vscko2Z21UTkxLckQrUm1xQ1ppc1JDWDhs?= =?utf-8?B?SmsrUzd0RUx5NUx0QmdqRS9PQlVVQjZjbW1NNFJFNXNZcUd6V0swSTRoKzd0?= =?utf-8?B?UjhaaEZrZWlENG5FQkp5SlJCZ3lqNkVlc0h2TE1RZXgrelpQU3RIOEw4L09T?= =?utf-8?B?UGE5RnhPRHVJaDJ5V0ZzdWlscSthbmM0TkErdjdnbmcweHU3RjRBRi9GTGdT?= =?utf-8?B?MitEY3ZVQ2Nra3Nsc0VHRWFqNFcwNVY1KzBPR21QVWhDQTNzQmhaM0xHTFVF?= =?utf-8?B?a3JqejZ1emgyTktHRHoxK3N4REl6SklGVnBNM1F4cFhHRWkvRk4xK0hJVzVa?= =?utf-8?B?am16K0xuOGE5dUVIMk1BYUZtS2MvakY4UWtBc2E2RXNrVG1yWHZlcVRQZXk0?= =?utf-8?B?Nkd2elFxdWdxMU5kQ1pwRGNEYlR2dkp4b215K2wvQ1dqSnVRTS84MHdkU2Qx?= =?utf-8?B?ZlVxWDdYbGlVZ080ZVdDVXFZcDdDU3RRdk1xUVN5blNlZnhRN3UwVzh0V3Vj?= =?utf-8?B?Ynh0ZVFQOUtnUjZyQ20wSk0rcXhaUmdWSCtEL1hxdUl0Rmp0MHJDb3RaR0NM?= =?utf-8?B?REtnOWhQNURtMFNtM0o2aG5kYW81VkoxZDJQU0twVHh0cHliVzlROEJxUlgz?= =?utf-8?B?VGdVWlo4Qk9TRDgvdHJTUXlvWlh4L3QrWEZOSG9XK3R0MUlFaW9ySHdCL09l?= =?utf-8?B?WkNsYnBvQjJpeWtsSGdwOFJjTERSSDZYb2JxNTJ3ZlhIbGFxWVhqNTJPNVZ0?= =?utf-8?B?T2FYN2x5SW1Oanl0VXpHY2g5RER3VS9paHRQTGlKOUZ0MEIvV3VIWWJHTkVF?= =?utf-8?Q?YwrlxDQRQQs=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6P191MB0008;6:Ud1I3IlkM5h6qkJYNq7iszp4LOWOf+ulMF5X1RFoUBeDr/XB2sK5V65tqiWVAOyepm0pml9UEOtUuyor1OS3A6z/LnKorX/hqm3Xes8XVXF3VWUvYvIX50ZYblQvUr34xlCrOkOV6/Hig4v6OTgZ7Q1kSneWI8gS/yISWVtVhW1kwADDoXpMR34s9sFbzUOr1TCuQZaVpILm4K8LGjPFCKufo+Bss93cbbNblVBAoyWI4W6SXPobxyjopB4shIicg3QqM4Xk82eNNn5wCH03s/5Jv0G+68zY2a2LZz3Q95Bk0/oARMR6VWMZzjKb2X57Z9T3rTD0PIUiiyq84ZDZRw==;5:mdTUOXZvQT8GejsKNJWfqh/9Pwak3NnTaYog9EJVzJF+Q77AznFUnMM3KXsk6g3d/s+Dnwbo2CSG4yRDYTZ//ANwJye84OLRmRe4N7U0UtZzgecZzFIeJyQ4FlZSKwg8MyTUKC8BXX38/F7FIvDnRQ==;24:vufyLKEneFOLYN6qfa1ffarfxKhag6Y170UlWKnkhbQH9s8VLL+9mcAYHopOskTkWJbhl+9fd2J9llZM+jYN32u0onehjwvh79pjB06GNNQ=;7:y7Rx3crxO6wF7LiKm8A5nm0gutBYd7pCHQRhTPz77DUGJovOkU3SNozhHkSv58IEJhshmSwcfN3lps5JfhaAzVoI8WPkIEizWM/DK8OHoDzmKidAy+XvEYsVjEJj7OwBDRnack0xL36+0YOymNVEfzut8+xVtBN8V5L3so8u+ruAwmQaVo9JIk5BA/A4KYTYRjsxFwFjwLrcP0/X/6jfYT5xzrsz9W6+qLxoM6quMb0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sondrel.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 14:38:03.6372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4faa3872-698e-4896-80ec-148b916cb1ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6P191MB0008 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, Thanks for the review. On 04/10/17 14:14, James Hogan wrote: > Hi Ed, > > On Mon, Oct 02, 2017 at 10:55:58AM +0100, Ed Blake wrote: >> Set all sys wake polarities to active high during initial setup. The >> default is active low, which currently causes the 'flow_type' passed >> into the set_type function to be effectively inverted. >> >> Signed-off-by: Ed Blake >> --- >> drivers/irqchip/irq-imgpdc.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/irqchip/irq-imgpdc.c b/drivers/irqchip/irq-imgpdc.c >> index 22d8f8a..d1bcfef 100644 >> --- a/drivers/irqchip/irq-imgpdc.c >> +++ b/drivers/irqchip/irq-imgpdc.c >> @@ -49,6 +49,8 @@ >> #define PDC_IRQ_ROUTE_EXT_EN_WD 0x00000004 >> #define PDC_IRQ_ROUTE_EXT_EN_IR 0x00000002 >> #define PDC_IRQ_ROUTE_EXT_EN_RTC 0x00000001 >> +#define PDC_SYS_WAKE_POL 0x00000020 >> +#define PDC_SYS_WAKE_POL_SHIFT 5 > I don't see this bit in the documentation for the PDC in TZ1090, so it > must be new in later versions of the IP. Maybe that can be mentioned in > the commit message or a code comment. OK, I'll add this in v2. > Does it need backporting to any stable branches (presumably v4.1+ for > Pistachio's sake)? Pistachio didn't have a PDC, so I don't think this needs backporting. Ed.