From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C346C30DED5 for ; Sat, 11 Apr 2026 18:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775932732; cv=none; b=eS0l6ftIrEqttI6wnIsEwhn14FsqF+iYALmAQQ8LVHbzV3r4Dg5Xceowsqp9fuW87gesmos0T1BPaVUaBYXxJGYRtwkvlS3z4VPtikb9AJ7cMxEK2JYShZYyy75epmvuToanrKcNbRkw7O5GB9/YIk+P8Qh45P7WkcMEW9mt8oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775932732; c=relaxed/simple; bh=G32kimuHQulcIRtvbX70KIJe9/8qb/w1NZjaE6M/Yag=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gmuELtFj+LeppiDdoXm82HNyKEC4dgzbN/MxwzdmruMSMzOmLGKBnjo/kojW5ruZGJ0DVm+gF9H2pxYF9sWHTbco6En2u5e8wKxXLolSlsYWl5Kg/OZDrsNlW+mQbyWwTJtKwSpMYYdCkTjZB5zP+YCx8REUuxkDcv12w2jT0y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=Qgk9QQbI; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="Qgk9QQbI" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7dbcd61429cso1515747a34.2 for ; Sat, 11 Apr 2026 11:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775932730; x=1776537530; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IvRlNKmzBLvAqyEhUGRKAEPOoty+E4bUWcZT3jLP1DY=; b=Qgk9QQbIPSgsGrhzywPBaAnO+mM5pC6JvlrRsIaOhcjTgvsAeZVQyJCohDg2lFUcyp WGdndSTQ2+vq54qI+n9vvShY4AaFlUSkZzEowW5uz5FdksMFpMwoBZ2h18aZH1q3KAAl NuLmnteGCSvhL8MJGJOySU1lWIwng+/oMeaFPDsb/U3moIGAr19Iz8Dxnuc7GEk4XYXG vz0Y8uxfsa4spEvXCBajLvDIlzg6NsmVzFHP4wzAJpcdq4FmRw2VYsSC19cML60sFAMO n+SvhrcFzKgqn6rLxUERspmTcB3ZeJ17EiMObY9/VzVeUPzx74oraMFNNQUbbzv1k5l/ Wuug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775932730; x=1776537530; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IvRlNKmzBLvAqyEhUGRKAEPOoty+E4bUWcZT3jLP1DY=; b=m7t/tUaPoyvNFMQtRbHu8vZvR6G5355CfcTjIWedWFDA7YeXiWNKQN3b8WnnlHBRiH ObeOh4/OUmPAIlREKM/t3vTy2LEb4VAlmts8XGB3V2kNDXx7YUZtdxw9zQP2t07iJyqZ cnXyKisdDjFLBr8A7fuJn/sOdoQprG+XMwjEcDjM5+xrYL7TEdb0G+YYNZZPObJ0rdKQ 3SBgWrlpX+ekEbO6LrgPQ9219Px94WeRLvN4PM7dlZdrxdHj2Z4yq9uD1Vhe+3nLnE+H eNR01fymYTh9gaqUsLy9/GXMmVHYLkMpysASqZULfQ5ktsqjj+49p5XQbTltczHI0tQ+ jtYg== X-Forwarded-Encrypted: i=1; AJvYcCXti6RFYueO/RylrTDe8Lh6aV5bYZLlsfwplr1I3ovEs//U5Gj9tW27Vee1X1xP79kdtiRcJ4n/Ov1PUow=@vger.kernel.org X-Gm-Message-State: AOJu0YzpChXl2awyFwCI9Zv+oZYBBHbpnI32IeQJx2cRly5MIqKgit3U pYtf/a72GtwOi5Sx6eKzeda4hs44K4k3g4olCpPfvsGSCmFrhXjluMyOw/HcgJyLueNqWvLq8Dx jsoLe X-Gm-Gg: AeBDietiigd17XVYYAKHNWilhabPXjJx8Ug99QBDDwJT6hM4jcNGcMIq+D5lilE1Tre QLxL3i99ScTqOlnxmyXTLn7JxWJCaFsNbgz7jY3H62uc0qcnXwMVTNy9lWVf3v+8SHdguu506rE pgfGoBj4xRlLITozEF/d4Sf0eQC4jcmvmtjzb8shInn4cCt8VHkU/OBARGXusIYSDrO77hAiIFk d/f5AEOAJNZIC0dG+GK/9rvbSvdTck+kz3oci/MVhHTjElgB3ZRdSJIkDOcaVLI0DdkyJSwv+HN EnIskyp0byOw0Ehr501pP/fVdUGqYvbRq/r4xb4tNqaTJp4EfxS+5sAgXPxpMkLIaEsWwNG4gfD WtMSBjHYhuW82TqtCtaav5jduSch922f/j/AiDuMUxRQwbYMUb9z6DyNCpjXTYyL3B6CZRAfEe1 wKbVIlv5EqRxexpfH87621Mo5gk+4gjRBb9G+wv6hM/yHAHf2YdD4XQtqGthTCEaPnRqp80FqgA g== X-Received: by 2002:a05:6820:c086:b0:67e:2fe1:2764 with SMTP id 006d021491bc7-68be7de90femr2387447eaf.36.1775932729767; Sat, 11 Apr 2026 11:38:49 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:d2e5:c81c:5b23:fe55? ([2600:8803:e7e4:500:d2e5:c81c:5b23:fe55]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-423ddb20c0fsm4808905fac.11.2026.04.11.11.38.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Apr 2026 11:38:48 -0700 (PDT) Message-ID: <693b0f48-9b2f-4989-89ff-280e3a9e1338@baylibre.com> Date: Sat, 11 Apr 2026 13:38:46 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v2 2/2] iio: frequency: ad9832: simplify bitwise math To: Joshua Crofts , Dan Carpenter Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, gregkh@linuxfoundation.org, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260411085848.75381-1-joshua.crofts1@gmail.com> <20260411085848.75381-3-joshua.crofts1@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/11/26 5:47 AM, Joshua Crofts wrote: > On Sat, 11 Apr 2026 at 12:38, Dan Carpenter wrote: >>> static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout) >>> { >>> - unsigned long long freqreg = (u64)fout * >>> - (u64)((u64)1L << AD9832_FREQ_BITS); >>> + u64 freqreg = (u64)fout * BIT_ULL(AD9832_FREQ_BITS)i; >> ^ >> This extra i char is something I really dread as a vim user. :P > > Damn, that's embarrassing... Should I wait 24 hours before submitting a fix > even if it's this trivial? Thanks. > The risk of not waiting though is now you have a review tag on v2 and you've already sent a v3 without it.