From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442AbdHFGa0 (ORCPT ); Sun, 6 Aug 2017 02:30:26 -0400 Received: from mout.web.de ([212.227.17.12]:56768 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdHFGaY (ORCPT ); Sun, 6 Aug 2017 02:30:24 -0400 Subject: [PATCH 3/3] ATM-iphase: Adjust four checks for null pointers From: SF Markus Elfring To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <693faecc-81ea-6d85-788c-b42924a2afb1@users.sourceforge.net> Date: Sun, 6 Aug 2017 08:30:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:TRTk3YT4HXAvIKLbiyGgNyFN/c9BLB6OUK+KqCqC1Mvb2Ubv6S1 atkFvVBlvs/AP7I7Dh4v0BTNDQkxdPuo0dPX9PNZwfLEgjCURHc1f12gbguXB+mzj74pmth dUKZn/MGhJdaOrSYQ6sE+DUawl4PJR9phhqbyVlHGabWZxI2cgznnIpv80ehvzT4Hkco4cy zIuQBMCGrN31koEnVpLpA== X-UI-Out-Filterresults: notjunk:1;V01:K0:y5hE0FRuU88=:+9sg6VDxJTGrBJS2ZTLk11 HgTwxySWUoKcMwvTO3j4gGKsg3ESETtbt1UEUkJA1mpSLL+gZ/VotIId2lyr9ZtfPu4pxqnhk IkZfio8iEaDZFa72du17plZRK3D3MvSbSxkTWR3XfibQfk4QWnCS9q0qy532MSxeJR/NtI9ve eRGn53O+4T6QlFibq+883lnvIht5NVZdNLuut/BBYgRet4eNsEcR6rX/Jy3CCgBKL2Q4J541D oGQpHow+p3Gp70I7fB0Gvc+1yXx8ctj8FF+YUv8hVZgNKZXBAwtMbyBOAXwg4qU8SoG/oafH1 DWJefXEOC6H/ElJrZjKWAkroMxbOPGUFRuzrhhR5rmQM1swQWb1IyRqZ+Q/UjcwT3xX1hOSg1 OHQYC3xmuto40cQ7olpfeZ/tYZblWP8T5rQbwpR5vAUgPQGf8egQsBxhOJS6JlH9Jt+hofgFn OdFbXpwnC5jDIfwQV5946bf/v6YfiWmhJCu7Sx2P5iX98DlBJkFLy0IgibVN3pMCQX8WAvIOV C3GK/z6AcqK+BcibqpaJ7eLG+ZBIGNI+UBsxENqti9MzUiV5P/NAFP9TPn8JAQZ8rUthE/ugO ETC/IqhB/qw9OpiGPO1nLeWPI8jqXRwfnZpuevz+JU/xl5XTr5DreC6IEfcEjj+1WC2FGyw8L su0bi1GhHQMgbfMUHJED5uj3gCvtHlKjzAm0GNCIQL3Q1QUmVDx7JBEEK7e6+h1iFwtUaFElJ s7pcftyeRI22V/uidImHlhM4DkFqW4WxZmoLHYUYUCdGJO0vAIuoG9KTS7SkIemFtejYgZp/U NMyi0HtN/2cLxDxYhynSihnqx5tswxhzBgKrcAiMu/5KIoMXfw= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 5 Aug 2017 22:30:04 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/atm/iphase.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c index ad4c1b41ba98..19782fed572a 100644 --- a/drivers/atm/iphase.c +++ b/drivers/atm/iphase.c @@ -101,7 +101,7 @@ static void ia_init_rtn_q (IARTN_Q *que) static void ia_enque_head_rtn_q (IARTN_Q *que, IARTN_Q * data) { data->next = NULL; - if (que->next == NULL) + if (!que->next) que->next = que->tail = data; else { data->next = que->next; @@ -116,7 +116,7 @@ static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) { return -ENOMEM; entry->data = data; entry->next = NULL; - if (que->next == NULL) + if (!que->next) que->next = que->tail = entry; else { que->tail->next = entry; @@ -127,7 +127,7 @@ static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) { static IARTN_Q * ia_deque_rtn_q (IARTN_Q *que) { IARTN_Q *tmpdata; - if (que->next == NULL) + if (!que->next) return NULL; tmpdata = que->next; if ( que->next == que->tail) @@ -1321,7 +1321,7 @@ static void rx_dle_intr(struct atm_dev *dev) goto INCR_DLE; } ia_vcc = INPH_IA_VCC(vcc); - if (ia_vcc == NULL) + if (!ia_vcc) { atomic_inc(&vcc->stats->rx_err); atm_return(vcc, skb->truesize); -- 2.13.4