mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: syzbot <syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com>
To: rakagunarto@gmail.com
Cc: rakagunarto@gmail.com, linux-kernel@vger.kernel.org,
	 syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] [usb?] memory leak in rtl8150_set_multicast
Date: Tue, 16 Dec 2025 15:37:31 -0800	[thread overview]
Message-ID: <6941ed3b.a70a0220.207337.001f.GAE@google.com> (raw)
In-Reply-To: <CACUOwm+O5RbQ8OjH=RCLLqRt-vzQMJwv_aMg41iNabH_AgHVJw@mail.gmail.com>

> #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

I've failed to parse your command.
Did you perhaps forget to provide the branch name, or added an extra ':'?
Please use one of the two supported formats:
1. #syz test
2. #syz test: repo branch-or-commit-hash
Note the lack of ':' in option 1.

> master
>
> async_set_registers() does not free the urb and req on the
> usb_submit_urb() call fail path. Fix by freeing both objects.
>
> Reported-by: syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com
> Signed-off-by: Raka Gunarto <rakagunarto@gmail.com>
> ---
>  drivers/net/usb/rtl8150.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 278e6cb6f4..0f6c700a85 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -211,6 +211,8 @@ static int async_set_registers(rtl8150_t *dev, u16
> indx, u16 size, u16 reg)
>                 if (res == -ENODEV)
>                         netif_device_detach(dev->netdev);
>                 dev_err(&dev->udev->dev, "%s failed with %d\n", __func__, res);
> +               usb_free_urb(async_urb);
> +               kfree(req);
>         }
>         return res;
>  }
> --

       reply	other threads:[~2025-12-16 23:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CACUOwm+O5RbQ8OjH=RCLLqRt-vzQMJwv_aMg41iNabH_AgHVJw@mail.gmail.com>
2025-12-16 23:37 ` syzbot [this message]
     [not found] <CACUOwmJ39NTytE0egqZ_ubuYGsiScsaEJcojzEk6tdXOSBcUGw@mail.gmail.com>
2025-12-16 23:48 ` syzbot
2025-12-16 10:06 syzbot
2025-12-16 23:23 ` Raka Gunarto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6941ed3b.a70a0220.207337.001f.GAE@google.com \
    --to=syzbot+8dd915c7cb0490fc8c52@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rakagunarto@gmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome