From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1605FC2D0EC for ; Tue, 7 Apr 2020 20:22:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4E2420748 for ; Tue, 7 Apr 2020 20:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DHGCk+yb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727737AbgDGUWH (ORCPT ); Tue, 7 Apr 2020 16:22:07 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22970 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727354AbgDGUWH (ORCPT ); Tue, 7 Apr 2020 16:22:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586290926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r8vqiSN09abRSI1hwl8/sl3dADzQpKJS/8XVAle9PuY=; b=DHGCk+ybLsU5lRjyi8KzMF4YIrPIjsU7duiBXektme0O0gj0svZfl/pLLDmLNkVkRiwKAd 9ws9N/x+a0D7CXY/LyDtym6mD8g+WQq6sjJYRBl4TxtAvMaHVtV7e/96I35LaIBe7NOQyn CqrjeyNJYlPfkiEd6UVbUkRYv3HCs4k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-eD3JK8RXOV290N2tCG19Jw-1; Tue, 07 Apr 2020 16:22:04 -0400 X-MC-Unique: eD3JK8RXOV290N2tCG19Jw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C732F8017CE; Tue, 7 Apr 2020 20:22:02 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-224.rdu2.redhat.com [10.10.112.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id 32CE950C01; Tue, 7 Apr 2020 20:21:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <694135.1586290793@warthog.procyon.org.uk> References: <694135.1586290793@warthog.procyon.org.uk> <20200407200318.11711-1-longman@redhat.com> Cc: dhowells@redhat.com, Waiman Long , Andrew Morton , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , linux-mm@kvack.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds , Joe Perches , Matthew Wilcox , David Rientjes Subject: Re: [PATCH v3] mm: Add kvfree_sensitive() for freeing sensitive data objects MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <694339.1586290917.1@warthog.procyon.org.uk> Date: Tue, 07 Apr 2020 21:21:57 +0100 Message-ID: <694340.1586290917@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Howells wrote: > > if (unlikely(key_data)) > > - __kvzfree(key_data, key_data_len); > > + kvfree_sensitive(key_data, key_data_len); > > I think the if-statement is redundant. Ah - I see that you explicitly wanted to keep it. There's a good chance it'll get janitored at some point. David