From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF8CD399CF5 for ; Mon, 3 Aug 2026 06:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738777; cv=none; b=hS6nukFcP/CKlpUEkDHowJ8/jG6gfv1l0dBKHN0TeSJa7KHEG7GB0NE0KbdYFS/LtusScRdyfFl+gzInu98vqQ3vQPEI0wFCL50OQbz23V7Sj5dcCEGdxlkCaUfQQ7/nOLuH1ZmiS9EaUKvzxlgh5uoVcaPNliBc/05NvmPGpHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738777; c=relaxed/simple; bh=z4NilfNrLDyjvuqg3u5Ou4sb7nkKppGdxS69/2ZrnHA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=akaylpC9ZaDDnGZweedO+6ocGgKs+NEf4ZObc14d255nE6B+Bzgbqftnj1WAu9NYaqpoxIGeVEkxxXTxSCb+sCemcHEPuLWshOeO1Vu1e0BosjrXTx17NAh5CgOHrklrBtBeh/AxA9CxMOSTGUBnWBebgS63fOSrheyP/zM/11s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EyQlDUmA; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=M4abB867; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EyQlDUmA"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="M4abB867" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785738773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kGAtNj6fbec9IRK9NgGILxfD8V3oY03sKYmcAfJ90+4=; b=EyQlDUmAKX4LdtMF6B7/8KJiDlgD/ZKwkVYCODd7gnamK4oR7N0pLz4a/KqWGJI5yV9Mf3 YqnyoIb0+rsJ+SrazCJEtyqmLwS9dsrgC51cUun/afKxnmy52QV70xArdAAwcpwQ5BBo+H vFmvkgXO3F04NGpquMrvHovPANTpq70= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-luP5el75NMOtfo9UxrKWvA-1; Mon, 03 Aug 2026 02:32:52 -0400 X-MC-Unique: luP5el75NMOtfo9UxrKWvA-1 X-Mimecast-MFC-AGG-ID: luP5el75NMOtfo9UxrKWvA_1785738771 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4955b84e25eso11655335e9.1 for ; Sun, 02 Aug 2026 23:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785738771; x=1786343571; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=kGAtNj6fbec9IRK9NgGILxfD8V3oY03sKYmcAfJ90+4=; b=M4abB867kzL6rAl7r1JCAFwnYVyrVLzSdD4saWxk/wrvSRGELZZCXp7BAxdZ4ubNa8 k6p4SqKwgizsJxMcGIwEY+fSCfnKSi1m31DrpiaaMOYX5rngwZQ58OcBgNAi0+zZgnU4 /NEfn02zOhCdyTcVecvzn14XD3wQEEkSO79a4tm4wq/B49V7jfJKqVamGQ/JvPlZCkUS NzyMVwrN/Y0vvlp/ZMmufRrYhRtZWxAaSGHha5gJI87A52VosxthoksFCEhE/yMUtvkX FQRKOfIjYUHKY8LIJRZUwntdJQNLNMBNY37ZTUvoJo00NWL9mJInALRWUkXcVIU5Oswx VkiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785738771; x=1786343571; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=kGAtNj6fbec9IRK9NgGILxfD8V3oY03sKYmcAfJ90+4=; b=bXYuWhldE2CIkG5Z/FY+cT7b0u82WUy8oqSB4XvT5xhmd8szqiFJ2Xr1eFAUvcElyr 3xsydQ4ZrZCAxOC34k5CjIgpPnb1gmcdTHO/g1IWNc5AJjj9eLkv1cIPLayqy+sxT7R8 mVgaM2av02Cj2J+PbS6osnhrY9PyJsdRCGU8g+nyNDCvGTx+PiFDIe0vDowlYdHzbTlq JWjq4DC5TYEipoVciAJQ+CHmuj543O5SE3natlCuSplQlHUUWrWuyBdTfNyuHA9zrhK6 8A0xGFcBYXWfJZc2ScaXpPolVYN2MJYcb+t023p8VgUT/sPauxrsm+yXW/M75yCHo14X LHvQ== X-Forwarded-Encrypted: i=1; AHgh+RqjneHZU5n+EKpywQf4vo2HBbyvBvZJLn+f00JR/m4Lv9vCGaeqNivJluR7Y9NOejQvfdZOCYYsM7RPt10=@vger.kernel.org X-Gm-Message-State: AOJu0YxWaJ6Xl0gbpMNM8ukc++0ufiSOwzFfvcxnfAfx4pKc3YsL4t0d Z7I/70BZeKCPfVxl97Pf/KrVvdaQcZuNLSHimS8dIfOb2UJHT0+PNqa8Ao+Sp7k+eUTDjTOErv4 fSSFdoZgmCKMUlHsCVZVKTatJhOFzZKd717LJ5RN59+0BTG2WkA7ondf7f3DEOWuhdQ== X-Gm-Gg: AR+sD11BG2e55shIHLwdhN/f29GWzantVAfSh4siQEJqOeHuk/erZn3KYlfri3B2hKf balqlbGSG8QjSvkTK/cZ5wV9/QtDQIT7pn2gCKvipvWebxiLK52Bxp2YMTnYTYm7lp0zrDgPumf A0tXlRYxcg23bDZ+ZJXYiv2fjUZtQ+jg/p2Q6i1GrGHmhkfdP3k2dBylNoHV6XSLRoNbfDftL9h gOkimebrwhG0NkKzE55XwIzfg5Sb5bUj7wLhCzXAZGBkYBHT1+pnv7WiOKoCaRFxHVBupRat5fV j54u8wyAJrU6Hb8mvH3A0EZjXihFP6INyKcpyXC2CQNWOcj4tTXQa09BSAZCYgCvpAAddBDEtOh JAMtJn7E2wEgonxJjbL3rlV69Z9ux X-Received: by 2002:a05:600c:e557:10b0:495:5890:8f6c with SMTP id 5b1f17b1804b1-4980c64b824mr121981055e9.7.1785738771189; Sun, 02 Aug 2026 23:32:51 -0700 (PDT) X-Received: by 2002:a05:600c:e557:10b0:495:5890:8f6c with SMTP id 5b1f17b1804b1-4980c64b824mr121980495e9.7.1785738770716; Sun, 02 Aug 2026 23:32:50 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49808191ccbsm202690735e9.3.2026.08.02.23.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 23:32:50 -0700 (PDT) Message-ID: <6943bc6d81388939512772b602f0c920ef0e5b01.camel@redhat.com> Subject: Re: [PATCH v2 3/4] rv/reactors: export rv_register_reactor() and rv_unregister_reactor() From: Gabriele Monaco To: wen.yang@linux.dev Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 03 Aug 2026 08:32:49 +0200 In-Reply-To: References: Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-08-03 at 02:43 +0800, wen.yang@linux.dev wrote: > From: Wen Yang >=20 > rv_react() is exported to modules, but the reactor registration helpers > are not.=C2=A0 Export them with EXPORT_SYMBOL_GPL() so reactor modules an= d > the tristate KUnit test module can register and unregister reactors > without hitting undefined symbol errors at load time. Nit, but I believe you meant /link/ time (modpost). Linking phase would fai= l at the end of the build and you wouldn't have anything (.ko) to load. Anyway patch looks good: Reviewed-by: Gabriele Monaco Thanks, Gabriele >=20 > Signed-off-by: Wen Yang > --- > =C2=A0kernel/trace/rv/rv_reactors.c | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/kernel/trace/rv/rv_reactors.c b/kernel/trace/rv/rv_reactors.= c > index cd571b1649f5..228ed043bd73 100644 > --- a/kernel/trace/rv/rv_reactors.c > +++ b/kernel/trace/rv/rv_reactors.c > @@ -314,6 +314,7 @@ int rv_register_reactor(struct rv_reactor *reactor) > =C2=A0 guard(mutex)(&rv_interface_lock); > =C2=A0 return __rv_register_reactor(reactor); > =C2=A0} > +EXPORT_SYMBOL_GPL(rv_register_reactor); > =C2=A0 > =C2=A0/** > =C2=A0 * rv_unregister_reactor - unregister a rv reactor. > @@ -327,6 +328,7 @@ int rv_unregister_reactor(struct rv_reactor *reactor) > =C2=A0 list_del(&reactor->list); > =C2=A0 return 0; > =C2=A0} > +EXPORT_SYMBOL_GPL(rv_unregister_reactor); > =C2=A0 > =C2=A0/* > =C2=A0 * reacting_on interface.