mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	"Josh Poimboeuf" <jpoimboe@redhat.com>, Tejun Heo <tj@kernel.org>,
	Andrii Nakryiko <andriin@fb.com>, Francis Ricci <fjricci@fb.com>
Subject: Re: WARNING with LBR + precise_ip=2 + bpf_get_stackid()
Date: Thu, 18 Jun 2020 20:18:06 +0000	[thread overview]
Message-ID: <694A8714-F178-4211-A9DC-DA7604B8D5B0@fb.com> (raw)
In-Reply-To: <20200618183302.GN576905@hirez.programming.kicks-ass.net>



> On Jun 18, 2020, at 11:33 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> 
> On Thu, Jun 18, 2020 at 05:25:24PM +0000, Song Liu wrote:
> 

[...]

>> 0xfffffe00004d1380 __start_orc_unwind
>> 0xfffffe00004d1388 unwind_next_frame.cold.7
>> 0xfffffe00004d13c8 perf_callchain_kernel
>> 0xfffffe00004d1418 entry_SYSCALL_64
>> 0xfffffe00004d1450 get_perf_callchain
>> 0xfffffe00004d14b0 bpf_get_stack
> 
> This, this is where it gets buggerd. This is a BPF problem, not a perf
> problem.
> 
> You'll note that if you ask perf for a PERF_SAMPLE_CALLCHAIN we'll do
> that early in setup_pebs_fixed_sample_data().

We did notice perf works fine in similar scenario. I guess need similar 
logic in BPF. 

Thanks,
Song


  reply	other threads:[~2020-06-18 20:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 17:25 Song Liu
2020-06-18 18:33 ` Peter Zijlstra
2020-06-18 20:18   ` Song Liu [this message]
2020-06-18 22:35 ` Andi Kleen
2020-06-18 23:21   ` Song Liu
2020-06-19  8:13   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=694A8714-F178-4211-A9DC-DA7604B8D5B0@fb.com \
    --to=songliubraving@fb.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andriin@fb.com \
    --cc=fjricci@fb.com \
    --cc=jpoimboe@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®