Re: Linux 5.18-rc1

[Jiri Slaby <jslaby@suse.cz>]

On 04. 04. 22, 5:29, Linus Torvalds wrote:
>> Error log:
>> drivers/tty/serial/mpc52xx_uart.c:967:23: error: initialization of 'unsigned int (*)(struct uart_port *)' from incompatible pointer type 'int (*)(struct uart_port *)' [-Werror=incompatible-pointer-types]
>>    967 |         .raw_rx_rdy = mpc5125_psc_raw_rx_rdy,
>>
>> and many similar errors.
>>
>> Caused by commit 18662a1d8f35 ("tty: serial: mpc52xx_uart: make rx/tx
>> hooks return unsigned"). Reported at
>> https://lore.kernel.org/lkml/20220403153607.GA3644508@roeck-us.net/
> 
> Jiri - apparently you didn't convert the cases under CONFIG_PPC_MPC512x.
> 
> Please, people, let's get these silly problems fixed asap, and not
> have people unaware of them and fixes pending until much later in the
> rc series? It was painful  last release, let's not repeat that
> mistake.

Sure, I wasn't aware of the issue until yesterday -- when Guenter 
dropped me an e-mail. It passed through all the testing machinery which 
is unfortunate. (I have a script to cross-compile most of the peculiar 
tty drivers [1]. That indeed contains "mpc52xx_uart.o powerpc_mpc5200".) 
The fix was posted as 20220404055122.31194-1-jslaby@suse.cz .

[1] https://pastebin.com/UDTsBAaY

thanks,
-- 
js
suse labs