From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9036F32ED42 for ; Sat, 21 Feb 2026 20:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771705240; cv=none; b=qZHsl3fVUZxrW8oBDw9DI5ZLl4z6LbpJGXaRxBWnBlOIB5QoUcIRARUfhK26NU2nXTI2PCwmNS7bz48hN2zuM/6mFqK1kI5kB7V8ebFHvmaJQtXFIDPV6F6wJD/Kb6rc1X45ZftUESDynNBvhTFf2Tn5xZRAq1UWiESugUZOQwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771705240; c=relaxed/simple; bh=YutVV/Yp/b+yJFKeAUB7af/0rb1SmXkhm7HkOhPprpI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kL4LuDesz4FqK/MOQQs4jeT+58JB1y9fhlAhn/r04wGHZe/Xfot8+ImyByBtJH7WXZruRmc/v2HT3PHMctaA6+PiMOpvc0ncq8bxSTemtsyJMJnEP488gk6lhH0ddyzE7ioYts8MYcKaBwrTadxIZA2/bhqFvGjDkXFt99z/9/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HANxZuBz; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HANxZuBz" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-8cb39647a70so309990885a.0 for ; Sat, 21 Feb 2026 12:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771705237; x=1772310037; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hl7pbSCAC6EgWEJVHJrMgxzQ04hk7/FUA/tscJI2bVc=; b=HANxZuBzLamI6Skfm+EVsdiRt2PqpK+VnzRm4+o/NyLJmAaIj9RurLexzJvp5QyW/b rTyqvDpVkgN7ArR6bCQcLia1OsnFTzp0v1TS1oLlWY2+vmOwNRUfJv9PPFR+yx7rTu+k vMepvsFCngwGh69CU6ZQgmcNw1gH5y2YDWjCEJh/4co6M8uwySADMG7iiqH9QxxMkEJX wnLsdBdGMGuuh0vyEaL2YCZMaukgbxjBIGI7Ivt6FIBpk9Jj4BIMcP6Jg3bLElwNmoVC n+zPrdqvxkdQaVtsAOioF83Rtkqzo4PyAkyIEx3kJINUDaSObWmUgSCjen/ZBGGsIObf Ii9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771705237; x=1772310037; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hl7pbSCAC6EgWEJVHJrMgxzQ04hk7/FUA/tscJI2bVc=; b=p9X2U7cLpfb9DgeAGy8dc1J2V4qEu8rgtKssM8TJ31COCAEn/GxqkEtD+de3RiZNhf iqAtEJkSBR64Zn+KAN4wjCjqqHh0uciLRLdHf0ctzTX5YH+j9iBy0385/rOEV5E3tNLp osjm0bF7Eisu28oQjDUK0DdObui/upmfqdBr3eItioJjdqHJ1S23N+5xw0VDAR5GYRAb wi3I1yp7mYE8S+QmETZ2M1WT7WWedP7wptv3c2LLeEeFa3WMb2eSfnxS1YvhT+VUHjYr PHhjxnc3C+WC/o5uKyxk0dlehpGmsgrkVq4KJBgZHjqXXT2T7cVVNmz7C+L5lqval3tR 6Kjw== X-Forwarded-Encrypted: i=1; AJvYcCX5hPyIM0ria9/6748O5od4K0VuyfVK/5qsWMSyMELtq+MxSAXXS7nTGAWRGtjt7VtKZIUQYWfZqUgtomA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3xqLJLd8G3sbs55fGpdKu95w/q0h7HSysOuQBQxO4jJMiivjR +6RvPFj9qlaiaj1zE6TUkrmsHHMCxDi/BTxsfHrmjHe8eHwiQN7+NwIe X-Gm-Gg: AZuq6aIzhX6PwVOm9Cutq0QXgGJIMPWyZ4TC7JiJX35xjMdbAFMeMWwO+InXuC8XPKf vWpuuGKdxX1cQIjPncaevYLNFcRDy0Y/cLg+vcZYVYBRdB9axADfqM5DZvQuyQ0rxHxPSg14eUd /AGuXCbu0q9EI+GTFr3KjLptyrgTbCcU/lKt5JQTZW803pQ0MAS1QlfSZYa53D5YLq7MngcMp/0 eQ1pDypACyxb1+bLhgKaixoIapFHNRp0ru3Gs8S/D1zSTn+G/OXFy+QqxOrLYnTiRDH/S2NQnFK 1T6uq8Hf4qEEWgxoeh5a5fes4b7w95JQFni8GGpkfh7EnFkDPVo1GPQ0llLacKDV9zyPUapZP5G 20N9MDxOvk1MQ6lNDUFtartrlq3nKKp/ZcHJzGLZ4GDfruI97R0UO7SF0RbtCQVOu69P8PrmJgl RuqlcDOjFgTlPPZ1o23P5iWlQGSI2ySOUcKtFAOds3laGhD3zkLw== X-Received: by 2002:a05:620a:28d1:b0:8cb:1ddc:4300 with SMTP id af79cd13be357-8cb8c9f3cc5mr447493385a.20.1771705237304; Sat, 21 Feb 2026 12:20:37 -0800 (PST) Received: from [192.168.0.155] ([170.10.253.128]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cb8d120020sm268327485a.45.2026.02.21.12.20.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Feb 2026 12:20:36 -0800 (PST) Message-ID: <694bcd12-7a1c-4be3-8921-20e5b0b88cc0@gmail.com> Date: Sat, 21 Feb 2026 16:20:33 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/11] staging: rtl8723bs: Clean up wrapper functions To: Priit Laes Cc: Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Philip Thayer , Bryant Boatright , JJ Strnad , Dan Carpenter , William Hansen-Baird , Navaneeth K , Julia Lawall , Tanjim Kamal , Randy Dunlap , Rodrigo Gobbi , Artur Stupa , Abraham Samuel Adekunle , Michael Straube , Hans de Goede , Ingo Molnar , Ethan Tidmore , Zhuoheng Li , Michael Huang , Nino Zhang , Thomas Gleixner , =?UTF-8?Q?Rog=C3=A9rio_Fernandes_Pereira?= , Diksha Kumari , yingche , Karthikey D Kadati , Khushal Chitturi , SeungJu Cheon , Akiyoshi Kurita , Erick Karanja , Sun Jian , Yuvraj Singh Chauhan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260221190628.50273-1-plaes@plaes.org> <20260221190628.50273-11-plaes@plaes.org> Content-Language: en-CA From: Vivek BalachandharTN In-Reply-To: <20260221190628.50273-11-plaes@plaes.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit This change doesn’t really “remove wrapper functions” so much as it moves the wrapper bodies into the public APIs, and inlines |_rtw_dequeue_cmd()| into |rtw_dequeue_cmd()|. Minor: the |if (pcmdpriv)| guard in |rtw_free_cmd_priv()| looks unnecessary if callers guarantee non-NULL. If you keep it, please point to call sites that can pass NULL (or drop the check). Best, Vivek On 2026-02-21 3:01 p.m., Priit Laes wrote: > Remove wrapper functions in cmd queue handling. > > Signed-off-by: Priit Laes > --- > drivers/staging/rtl8723bs/core/rtw_cmd.c | 88 ++++++++----------- > drivers/staging/rtl8723bs/include/cmd_osdep.h | 7 +- > 2 files changed, 39 insertions(+), 56 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index d0694a659259..60e2de7991d4 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > @@ -210,32 +210,6 @@ int rtw_init_evt_priv(struct evt_priv *pevtpriv) > return 0; > } > > -void _rtw_free_evt_priv(struct evt_priv *pevtpriv) > -{ > - cancel_work_sync(&pevtpriv->c2h_wk); > - while (pevtpriv->c2h_wk_alive) > - msleep(10); > - > - while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) { > - void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue); > - > - if (c2h && c2h != (void *)pevtpriv) > - kfree(c2h); > - } > - kfree(pevtpriv->c2h_queue); > -} > - > -void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) > -{ > - if (pcmdpriv) { > - kfree(pcmdpriv->cmd_allocated_buf); > - > - kfree(pcmdpriv->rsp_allocated_buf); > - > - mutex_destroy(&pcmdpriv->sctx_mutex); > - } > -} > - > /* > * Calling Context: > * > @@ -246,7 +220,7 @@ void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) > * > */ > > -int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) > +static int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) > { > unsigned long irqL; > > @@ -265,38 +239,35 @@ int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) > return _SUCCESS; > } > > -struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue) > +void rtw_free_evt_priv(struct evt_priv *pevtpriv) > { > - unsigned long irqL; > - struct cmd_obj *obj; > - > - /* spin_lock_bh(&(queue->lock)); */ > - spin_lock_irqsave(&queue->lock, irqL); > - if (list_empty(&queue->queue)) { > - obj = NULL; > - } else { > - obj = container_of(get_next(&queue->queue), struct cmd_obj, list); > - list_del_init(&obj->list); > - } > + cancel_work_sync(&pevtpriv->c2h_wk); > + while (pevtpriv->c2h_wk_alive) > + msleep(10); > > - /* spin_unlock_bh(&(queue->lock)); */ > - spin_unlock_irqrestore(&queue->lock, irqL); > + while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) { > + void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue); > > - return obj; > -} > + if (c2h && c2h != (void *)pevtpriv) > + kfree(c2h); > + } > + kfree(pevtpriv->c2h_queue); > > -void rtw_free_evt_priv(struct evt_priv *pevtpriv) > -{ > - _rtw_free_evt_priv(pevtpriv); > } > > void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) > { > - _rtw_free_cmd_priv(pcmdpriv); > + if (pcmdpriv) { > + kfree(pcmdpriv->cmd_allocated_buf); > + > + kfree(pcmdpriv->rsp_allocated_buf); > + > + mutex_destroy(&pcmdpriv->sctx_mutex); > + } > + > } > > -int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj); > -int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj) > +static int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj) > { > u8 bAllow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */ > > @@ -337,7 +308,24 @@ int rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj) > > struct cmd_obj *rtw_dequeue_cmd(struct cmd_priv *pcmdpriv) > { > - return _rtw_dequeue_cmd(&pcmdpriv->cmd_queue); > + unsigned long irqL; > + struct cmd_obj *obj; > + struct __queue *queue = &pcmdpriv->cmd_queue; > + > + /* spin_lock_bh(&(queue->lock)); */ > + spin_lock_irqsave(&queue->lock, irqL); > + if (list_empty(&queue->queue)) { > + obj = NULL; > + } else { > + obj = container_of(get_next(&queue->queue), struct cmd_obj, list); > + list_del_init(&obj->list); > + } > + > + /* spin_unlock_bh(&(queue->lock)); */ > + spin_unlock_irqrestore(&queue->lock, irqL); > + > + return obj; > + > } > > void rtw_free_cmd_obj(struct cmd_obj *pcmd) > diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/staging/rtl8723bs/include/cmd_osdep.h > index 5506f513dc01..b0ac41d2be24 100644 > --- a/drivers/staging/rtl8723bs/include/cmd_osdep.h > +++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h > @@ -7,12 +7,7 @@ > #ifndef __CMD_OSDEP_H_ > #define __CMD_OSDEP_H_ > > - > -int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); > +int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); > int rtw_init_evt_priv(struct evt_priv *pevtpriv); > -extern void _rtw_free_evt_priv(struct evt_priv *pevtpriv); > -extern void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv); > -int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj); > -extern struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue); > > #endif