From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C529440A3E; Mon, 14 Sep 2026 11:26:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789385177; cv=none; b=Co6nIC37ykpa5aFuDuZPb6dxBXy4N5/slW2UMHUG3Jx+KvqW42r92wRnQrp/udGo+vPpNkXfBwTJYodshuAhMpYsxLuP6phe58N/MmB2WLEhOAIK+3FzxE1c/cNGHXCAdONxO7p6Riyf6Y+2n8S0zCufOWxgY0TC+QOiro8w04M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789385177; c=relaxed/simple; bh=lXVPwq7s2VUOFgW7l33ir3TRXWPIYSzWJPDJTQ63R+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KIleHfjJT/NaPFt2F2fk83Jz5/IZ23haXOkZi28FoPj1zpaBaOWUpEPq54x0EdJ4ZnAclgHYeyEmLsbvXMfHvz9L5KnnI0vx62ThsQqv0gL66hTWTTe6aOn6cPFGB6hL7RrNXrGhIrLQQMDVUNRoJiw3PssW0jQ8vOf+csKkaW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=cGGB0QNM; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="cGGB0QNM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1789385173; bh=lXVPwq7s2VUOFgW7l33ir3TRXWPIYSzWJPDJTQ63R+U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cGGB0QNMA3UGaFW+2zS9yJ2f0H9CIkbzniMnzaf5CY35eK4B6hGXWbzssm1GNP0XA kLXyg/waZcQo6l7/lZGAV6gRv/HHyDq4BIxldXCaL8BFmyRdoH4TwIz3vEuvOdg9Jf E+dx868sHUpJfNl5Gi7YIOfkrYwliAvLDiRcoU8+0WffH0urqgo0B8lwnK0av25B8n PNUDXcX67mvM+ZVVesjNycvTIHj5EmTQmyz5HcyLnqPCfcY9wP8TYdxRG0O0sCKXeQ IImkggd+Z3tGxYzxuts56gFpuORikG2V8XMgdKOFsqlv9BfvyrAIFuYUC24rg6GTW4 v10dtaDm5DakA== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id D193C17E0894; Mon, 14 Sep 2026 13:26:12 +0200 (CEST) Message-ID: <69562510-23f3-4993-b740-60ba83979237@collabora.com> Date: Mon, 14 Sep 2026 13:26:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 11/11] drm/mediatek: Add Write DMA (WDMA) Engine for Writeback support To: =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" Cc: "kernel@collabora.com" , "robh@kernel.org" , "tzimmermann@suse.de" , "simona@ffwll.ch" , "mripard@kernel.org" , =?UTF-8?B?Sml0YW8gU2hpICjnn7PorrDmtpsp?= , "linux-mediatek@lists.infradead.org" , "maarten.lankhorst@linux.intel.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "conor+dt@kernel.org" , "devicetree@vger.kernel.org" , "krzk+dt@kernel.org" , "p.zabel@pengutronix.de" , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , =?UTF-8?B?SnVzdGluIFllaCAo6JGJ6Iux6IyCKQ==?= , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= References: <20260715135703.46540-1-angelogioacchino.delregno@collabora.com> <20260715135703.46540-12-angelogioacchino.delregno@collabora.com> <232cbc7ff5f2c50230eddf4db1f8eb7145a41d23.camel@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <232cbc7ff5f2c50230eddf4db1f8eb7145a41d23.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/27/26 07:33, CK Hu (胡俊光) wrote: > On Wed, 2026-07-15 at 15:57 +0200, AngeloGioacchino Del Regno wrote: >> Add a basic driver for the Write DMA Engine and initial compatible >> for the MediaTek MT8173 and MediaTek Dimensity 1200 MT6893, and >> hook it up to the mtk_ddp_comp and mtk_drm_drv in order for it to >> probe. >> >> This display controller component is used to enable the writeback >> engine that can be used for faster display image capturing in the >> userspace (for example, screenshots and screen recording). >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> >> +static const struct mtk_ddp_comp_funcs ddp_wdma = { >> + .clk_enable = mtk_wdma_clk_enable, >> + .clk_disable = mtk_wdma_clk_disable, >> + .config = mtk_wdma_config, >> + .start = mtk_wdma_start, >> + .stop = mtk_wdma_stop, >> + .register_vblank_cb = mtk_wdma_register_vblank_cb, >> + .unregister_vblank_cb = mtk_wdma_unregister_vblank_cb, >> + .enable_vblank = mtk_wdma_enable_vblank, >> + .disable_vblank = mtk_wdma_disable_vblank, >> + .layer_nr = mtk_wdma_layer_nr, >> + .layer_config = mtk_wdma_layer_config, >> + .get_formats = mtk_wdma_get_formats, >> + .get_num_formats = mtk_wdma_get_num_formats, > > I does not see you modify mtk crtc. > mtk crtc would use some interface only on 'first' ddp component of a pipeline. > WDMA would not be the first component, > so register_vblank_cb, unregister_vblank_cb, enable_vblank, disable_vblank, layer_nr, layer_config, get_formats, and get_num_formats are useless. It's true in this specific case, but this was done while performing the big mediatek-drm restructuring. I decided to split the full changes in two separate series, because the one restructuring mediatek-drm is literally huge... and this series is adding only things that can be applied before the full restructuring takes place. That was done in order to speed up the upstreaming and nothing else - so you can safely ignore the fact that there is extra functionality in this driver, because those extras will be used once the other big series is merged. It's a lot of code, please-please-please don't make me split things up even more, because then the commit log becomes messy :-) As for the comments on 8189/8196 (link rate and qos), you're right in that it makes sense to split the algo additions from the soc addition: I've done that already and will come in v7. Cheers, Angelo