From: Baolin Wang <baolin.wang@linaro.org>
To: dan.j.williams@intel.com, vinod.koul@intel.com
Cc: eric.long@spreadtrum.com, broonie@kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
baolin.wang@linaro.org
Subject: [PATCH 2/5] dmaengine: sprd: Define the DMA data width type
Date: Tue, 10 Apr 2018 15:46:04 +0800 [thread overview]
Message-ID: <695931ac827adb5b2c5a7939341ff61ba00af1a1.1523346135.git.baolin.wang@linaro.org> (raw)
In-Reply-To: <abdda9da96185f764d58bbf61db9010d0f72d1b3.1523346135.git.baolin.wang@linaro.org>
In-Reply-To: <abdda9da96185f764d58bbf61db9010d0f72d1b3.1523346135.git.baolin.wang@linaro.org>
Define the DMA data width type to make code more readable.
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/dma/sprd-dma.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index af9c156..9f44d6f 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -185,6 +185,14 @@ enum sprd_dma_step {
SPRD_DMA_DWORD_STEP = BIT(3),
};
+/* dma data width values */
+enum sprd_dma_datawidth {
+ SPRD_DMA_DATAWIDTH_1_BYTE,
+ SPRD_DMA_DATAWIDTH_2_BYTES,
+ SPRD_DMA_DATAWIDTH_4_BYTES,
+ SPRD_DMA_DATAWIDTH_8_BYTES,
+};
+
/* dma channel hardware configuration */
struct sprd_dma_chn_hw {
u32 pause;
@@ -613,15 +621,15 @@ static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc,
u32 fix_mode = 0, fix_en = 0;
if (IS_ALIGNED(len, 4)) {
- datawidth = 2;
+ datawidth = SPRD_DMA_DATAWIDTH_4_BYTES;
src_step = SPRD_DMA_WORD_STEP;
des_step = SPRD_DMA_WORD_STEP;
} else if (IS_ALIGNED(len, 2)) {
- datawidth = 1;
+ datawidth = SPRD_DMA_DATAWIDTH_2_BYTES;
src_step = SPRD_DMA_SHORT_STEP;
des_step = SPRD_DMA_SHORT_STEP;
} else {
- datawidth = 0;
+ datawidth = SPRD_DMA_DATAWIDTH_1_BYTE;
src_step = SPRD_DMA_BYTE_STEP;
des_step = SPRD_DMA_BYTE_STEP;
}
--
1.7.9.5
next prev parent reply other threads:[~2018-04-10 7:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 7:46 [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type Baolin Wang
2018-04-10 7:46 ` Baolin Wang [this message]
2018-04-10 7:46 ` [PATCH 3/5] dmaengine: sprd: Move DMA request mode and interrupt type into head file Baolin Wang
2018-04-10 7:46 ` [PATCH 4/5] dmaengine: sprd: Add Spreadtrum DMA configuration Baolin Wang
2018-04-11 9:36 ` Vinod Koul
2018-04-11 12:13 ` Baolin Wang
2018-04-12 9:37 ` Vinod Koul
2018-04-12 11:30 ` Baolin Wang
2018-04-12 11:36 ` Baolin Wang
2018-04-13 3:43 ` Vinod Koul
2018-04-13 6:17 ` Baolin Wang
2018-04-13 6:36 ` Vinod Koul
2018-04-13 6:41 ` Baolin Wang
2018-04-13 10:11 ` Vinod Koul
2018-04-13 10:48 ` Baolin Wang
2018-04-16 3:58 ` Vinod Koul
2018-04-16 6:32 ` Baolin Wang
2018-04-16 15:35 ` Vinod Koul
2018-04-17 6:06 ` Baolin Wang
2018-04-13 3:39 ` Vinod Koul
2018-04-13 5:44 ` Baolin Wang
2018-04-10 7:46 ` [PATCH 5/5] dmaengine: sprd: Add 'device_config' and 'device_prep_slave_sg' interfaces Baolin Wang
2018-04-11 9:40 ` Vinod Koul
2018-04-11 10:51 ` Baolin Wang
2018-04-17 10:45 ` Lars-Peter Clausen
2018-04-18 5:40 ` Baolin Wang
2018-04-11 9:24 ` [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type Vinod Koul
2018-04-11 10:49 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=695931ac827adb5b2c5a7939341ff61ba00af1a1.1523346135.git.baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.long@spreadtrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®