From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 644E2233944 for ; Thu, 9 Jul 2026 08:16:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783585016; cv=none; b=Sn+lgvwAOlx56gB/3tPoj2Mif+V6JlHwLKZ95VOuoFjZ2kMlJsIcf8rO9YLNmnfEPxdGMQlvI/zeT7MN4TehuLQpevsKYgcwu33B3qNCFULgpJY7gnPWRSZ0k+4IthC3DH8PBkYJlnX18JVBP1PV+suZ91T+EDi1WAQfzvfNP7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783585016; c=relaxed/simple; bh=GkCi0jq+alFib4ABH23vFxjXYANz7keEhGkqx46O1lA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ki2EE+kdiWO9LG0F347lL7BtPChLMAduSCGmG99WbwlF/Fo90b17VzYmBC9v3MFfqJpbq5ofA5pTGUr8NonOYoIEm+XThCTqED6QAJpVDLLoNVzjUiF0Uf//LBP9WoPz/4tN1fCBTKa7Mo/RP9c36nx2gqXfLhoP3x9vWZBz3tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PD6OquC6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PPuDbNTu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PD6OquC6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PPuDbNTu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783585013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XmSpAf4O3dtPU7pc72sg50trHi96xvgnv1EKezlLwQI=; b=PD6OquC6bWQ165oMFM9bAZmfWOt/JN5lONx57PlUwrn28iLiOtnH/KTLlkwx4XKfezjraV QQw8tnm0VMNcfz3chcQePjeA8eiTiGhAJJLw8yEpGCUPUlHAmUvobj/IRSHYWjXTl642fM +PoUAgq8RvgKYJ+qlY+iVAEf5WopbMY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-mhSX1UW2PManvBiBI1VnKg-1; Thu, 09 Jul 2026 04:16:52 -0400 X-MC-Unique: mhSX1UW2PManvBiBI1VnKg-1 X-Mimecast-MFC-AGG-ID: mhSX1UW2PManvBiBI1VnKg_1783585011 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-493b0a5e636so5164935e9.3 for ; Thu, 09 Jul 2026 01:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783585011; x=1784189811; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=XmSpAf4O3dtPU7pc72sg50trHi96xvgnv1EKezlLwQI=; b=PPuDbNTusdhDAILzLDHNy6q6mTgM+6/n6tIpXfEeDmrFBe/PtrXXebQUBOItiFWEOg WYQiqODdAqVdlErspYkw5vQj9P/tRc9jebIJsCdJCZPvoCBKbPrVUvkxPJC7cGChNjvO TSFL82If6Lt9cPjKHXXZBbc23BDunJZlq8wnnwMz2E5A/owQOxoPOfTjcjOEIOzToBJk GMN8Pat6W37zV9C7o5lBXQoKJJlI+IlGuzPQilHOr1DYdkOarH2hTUcelhpArostHqgz lwHPV7rxnXJlfxv8btKQIP1Fty+dHE0cDy4CcWz3XOFPcEiTgIQqCWYHR13GMXEzQTEA qBtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783585011; x=1784189811; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XmSpAf4O3dtPU7pc72sg50trHi96xvgnv1EKezlLwQI=; b=c4dFGE73Mc30EeynELA6CbtoNnaXRGJj9V/R9pQRHRk1W2PEMJIecFnRXza355SP7B 4BtJIR78i69ewYUfnGxLN3+4i3tP8qYjvhjZkMNCSKD4iBCNrP3Zs8bp3w9sbVW6YfxF miCZ8t0+L8oTHful7ordti2Ut4GCeFHfpWPorvvmNVgUGlArJEMp9nS6X6r8SFRS74yE UYEg9ohGBLEEFTdx+jEyFt7ak2pLZua2+AEpHGUHdv6djneJcA1RR7gdaq2zWalXXtAf ReMSLDvFI3CQ7x70kWbJGhFyZeUXC6oP83Mqfe7vlf734X010kw6Cr+L0MYs8qaNVIZH M/zQ== X-Forwarded-Encrypted: i=1; AHgh+RrAhZOVLOO4bzfSIAa3FFlhe3fTe32vofr7Ve4HnVKAM5tgQqqqwVaO9ftRuSPlXsQJGcswhtFYPm3T5Js=@vger.kernel.org X-Gm-Message-State: AOJu0YzYHqC3uzW1Sp0fEd9BfYAx5j7/S8ci++wmlv9A+PSjeKBtssIg wdUQUYhvPIxrwvb/zRISv4AnRpuSOZ8zTP29m2aGAGPufqo12jC2WYOad7koEY/I6j+V59PxRaO eRM9h5MW+lXtHjQTqDm4Tfw7iD0iHUfXUhPw1ixtYcug/Hnn7Z1IzGSNjxH3YEhGceQ== X-Gm-Gg: AfdE7cnuH6vt8J085Z1/iAC8poEQbQfBzTIeICuai8ec835jnJQOF0h2z0kOevkta6t k5knkNvuqFzkXKgRqrxe6OUyYLoRXBIa0H1WuAfwGG5iy+QHPa4AVpAfI3MRKlJrPT68Kuor0Gx QEBs/dbjwb4UXLk1WIX2C9GIGEILoNz5LcQ5hlJqwUQ9EMgV3gSC1UptwkctSFCA3CqAxVZL0rU S1Snsmpt6TcIZlA6RvVJOHLFs+vf5gTW5AJjJM6Ab7BYQli+ojNggPiDDHuwbbOOXGpnBxKbsKK 7B5nl3ru3zH40ofMamDM0aZblmHKPKJTYhd2WEyoyX1t7Te4WOCHLJUjV71Bkh0lz36CmBEq+x/ Y486OJgFxa/m2oVAFhYtBqQncoDqxUVv2x1qMWQ4dFQGplWuBiSutKPlhVXS2Fr5W0BsZCg7Ln3 fWsKdVBo0WFfJJ X-Received: by 2002:a05:600c:8184:b0:493:e79e:da9e with SMTP id 5b1f17b1804b1-493e79ede9dmr49876155e9.29.1783585010796; Thu, 09 Jul 2026 01:16:50 -0700 (PDT) X-Received: by 2002:a05:600c:8184:b0:493:e79e:da9e with SMTP id 5b1f17b1804b1-493e79ede9dmr49875865e9.29.1783585010365; Thu, 09 Jul 2026 01:16:50 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:58fd:68f:7756:389d? ([2a0d:3344:5521:6b10:58fd:68f:7756:389d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb70a677sm39467095e9.8.2026.07.09.01.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 01:16:49 -0700 (PDT) Message-ID: <695fc2fb-606e-4d5a-a4d6-41ba5d1cfadb@redhat.com> Date: Thu, 9 Jul 2026 10:16:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: erspan: set lltx to avoid sch_direct_xmit deadlock To: Yun Zhou , dsahern@kernel.org, idosch@nvidia.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260709065631.3488067-1-yun.zhou@windriver.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260709065631.3488067-1-yun.zhou@windriver.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/9/26 8:56 AM, Yun Zhou wrote: > erspan_xmit() re-enters the network stack via ip_tunnel_xmit(), causing > nested acquisition of _xmit_lock on the underlay device while already > holding the ERSPAN device's _xmit_lock. Both are ARPHRD_ETHER and share > the same lockdep class, creating an ABBA deadlock: > > sch_direct_xmit [lock erspan] -> erspan_xmit -> ip_tunnel_xmit -> > ip_output -> __dev_queue_xmit -> sch_direct_xmit [lock underlay] > > Set dev->lltx = true so HARD_TX_LOCK() skips the spinlock for ERSPAN. > This is safe as erspan_xmit() has no shared mutable state: o_seqno is > atomic, stats use atomic_long_inc, and dst_cache is per-CPU. GRETAP, > the sibling device with identical xmit structure, already sets lltx. > > Closes: https://syzkaller.appspot.com/bug?extid=9bda1b9fbb7fbdf9b62b > Reported-by: syzbot+9bda1b9fbb7fbdf9b62b@syzkaller.appspotmail.com > Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN") > Signed-off-by: Yun Zhou So this is actually a v2 of: 20260630183702.170798-2-hemendranaik@gmail.com/20260630183702.170798-2-hemendranaik@gmail.com/ right? please have a look at: https://elixir.bootlin.com/linux/v7.1/source/Documentation/process/maintainer-netdev.rst#L434 any kind of re-submission matters, no matter how trivial is the reason. /P