From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752153AbdHGGmO (ORCPT ); Mon, 7 Aug 2017 02:42:14 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59576 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbdHGGmM (ORCPT ); Mon, 7 Aug 2017 02:42:12 -0400 Subject: Re: [PATCH 4/4] thermal: bcm2835: constify thermal_zone_of_device_ops structures To: Julia Lawall , Zhang Rui Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org, Eduardo Valentin , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Eric Anholt , linux-pm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1501965437-30730-1-git-send-email-Julia.Lawall@lip6.fr> <1501965437-30730-5-git-send-email-Julia.Lawall@lip6.fr> From: Stefan Wahren Message-ID: <69716e67-d210-5599-426e-61c629dea523@i2se.com> Date: Mon, 7 Aug 2017 08:41:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501965437-30730-5-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Provags-ID: V03:K0:BbWze23rTyNRxYtz1LMc8+UWYtLZxWG91EmKQjes2VRVoUFeKco YzzhUYY8tSSBSvHCDrVdrJql7390/d2tOGd3U/bwzhCCvml+D6lY5zDs1JMd41yaVnyJ+1z 3WnmbMDWhzid/cljMyIX1CnZi5MfJJ9Vasbni49NMEKNhAMtfVflhs3IOyd6Lf5InaVmFXn bl+3K/lkN2rQgD7qD4a0Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:w9dLPUeAqo4=:qCuS36KsDxPq6if96EOibM A6PL0n/2k6DuwAHKvNQbrMO4dJFdzAScasdPhtLM9CgNjSgMf1z5xolgxNj5C7AqVsTWezJy4 33ZkK4IP8ejxhvqYZaqjngQihXXkir9KVxHR14HYKr838plWDCiuJtnqVyUpFASK200Dy76Ka Z7LOUc7vBXNYq1X/MVOcfSLc6TLwrS9PRXpbtTGcCVZ2DeDEmrb8guQHx7a842dF8cCKMsRXs JoyaYPJGz5sPyFlIpD+J6h/sWDEf4FJ3o4STaGZQBB+XEOtGau+Lre4FSVbq3HtXszXjgaHCT UNfjXZKHaRQdAKXA5F1rJ98oTMVD9w+ccgT3WR3TDwP7GJV7WmrXMfjlD+O6S+9HQmT6M9PXY J9B/VOF3+HPz9udjSnGWwWBmAnTAokB+vT3cENzNeE0wSXOoJ1ZBtZP8weldmSv1Rshd80vgJ I1Iiy0mG7s6Co591NPFzV3WLwy2nqhNt03bfLshohGaqsObxHUUTLVlTAgrh6LMHSic14v82J H858mWbVkWLE8qcaZN+AMk9NMF/885m1C46E6vlULPOBy3R5uKuQjyux6ypI9LcyDsZL8lDD2 kabesI5onXWWiD7r99iT2GZnEmnCPO2XQxfNUjTybE+mtR9vOSxqe7W6CEHo/lBYLvQmvRnQI U6eKttHCrRGnva6ZjxE+7/xPo0HD627QRzajWf+Z47teKBCU1lsc5+mgeKl5IH5wTKehqk/TR PGsh8lTJGlruHcSl0kcdyc1fP+GVI8tQmf5jNmZraXl2kmRe1kF9Kwz3heU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 05.08.2017 um 22:37 schrieb Julia Lawall: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to thermal_zone_of_sensor_register, which is declared as const. > Thus the thermal_zone_of_device_ops structure itself can be const. > > Done with the help of Coccinelle. > > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct thermal_zone_of_device_ops i@p = { ... }; > > @ok1@ > identifier r.i; > expression e1,e2,e3; > position p; > @@ > thermal_zone_of_sensor_register(e1,e2,e3,&i@p) > > @bad@ > position p != {r.p,ok1.p}; > identifier r.i; > struct thermal_zone_of_device_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct thermal_zone_of_device_ops i = { ... }; > // > > Signed-off-by: Julia Lawall Acked-by: Stefan Wahren > > --- > drivers/thermal/broadcom/bcm2835_thermal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c > index e6863c8..a4d6a0e 100644 > --- a/drivers/thermal/broadcom/bcm2835_thermal.c > +++ b/drivers/thermal/broadcom/bcm2835_thermal.c > @@ -145,7 +145,7 @@ static void bcm2835_thermal_debugfs(struct platform_device *pdev) > debugfs_create_regset32("regset", 0444, data->debugfsdir, regset); > } > > -static struct thermal_zone_of_device_ops bcm2835_thermal_ops = { > +static const struct thermal_zone_of_device_ops bcm2835_thermal_ops = { > .get_temp = bcm2835_thermal_get_temp, > }; > >