From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F705301004 for ; Wed, 24 Jun 2026 03:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782272371; cv=none; b=jguxPfAvjkC9/zU0ouAA3idJdyV8UepPBVcjkbRA5WDs1H42eQp1MQoEQgd9doKexiUqFHHm0srydajE59Nk47cL6npc3tPL/wTYoSUlG6W9J070SoeHgihacEjGEfcExyENM9GOBPyUCCB6BxMMvIu25C9Ev/Od3JU8twRcwFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782272371; c=relaxed/simple; bh=2EjvsFaAQeE9qVmKbO4mrLlRLyngDmWauWcSEj7FHSs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kq9O0ce889I/nVpibu3B9Z6ErZ41xA/rLDbNRnc3HnB8hq4/pkml65ICMmhwR2OydzOCTRO08e3h184gH5OsFPEzxIKHIKTkR+qR8QZypiFY6EyRqvMDmoMQRDs1sMUbl1D4C3SWgliTFwdlYibsbmTDOXDSMP7ZdLw5XuQEOXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JYe5kdPK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C1LEGkWO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JYe5kdPK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C1LEGkWO" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65O1TAf52987975 for ; Wed, 24 Jun 2026 03:39:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s0+XSenEQTH5fxmy4dSQBjH5RjWqklrxJNjZYQ6591Q=; b=JYe5kdPK6G8mYgg3 8XP3zCeiGHkzuT0TcZJsrZCCjNMfbCw+ltwP+MS73WkQ8a7KmZl+jJqpfvTjVX// 9tg0qomyMap6oIyo4Y2IpIhKihgY5QlkbLnZduJiw0gNGRyEPh+ZeGs6HSSoxPZ7 yxRF9iBkK6gRgXH8zS9irH9UHh+gOswgMsKYUhVI88uAkeyFcM+4PYPbqm5H7X/j G8Yo7RbMFk+ZcIKovcY0JtLSudxsiBbEH4obpKOOjoTqVt78+PryOcTkdLi8F8Jn HD4+8i0edgzuaqlqrIrv6k/fpjF9pl+ldd/+iPT04E5yVYm1DPWQF7ZSg20smqEt n2C7UA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr28umcr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 03:39:27 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36e09ec696aso1049518a91.0 for ; Tue, 23 Jun 2026 20:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782272367; x=1782877167; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s0+XSenEQTH5fxmy4dSQBjH5RjWqklrxJNjZYQ6591Q=; b=C1LEGkWORFr678vR4U26bPoMyr5eHt3veicuNh3dxEweoi93d5QtgrvJyZYbaqOSY4 B8NAIbyGpDsJKSdWugsxh1+/Q4VEJmIfas1yvBMAJoHMoDlehVN3IMJr9P+ihKVAEuO5 NZ7Kdhz+qVQteik1X+GnbZpboa7JSH/s4Q/CvFqkmJxjUeoWzndGVCqIQYfZAP9Qlm+p uv4yIQ45IiYdWvTgANwwtNVUYba1frIzWjAO9BbzFU8bN7bOZPORU7m7iNyRAP7vkKLd je2WmXYi6NouAJBtpTFT13N64ZxxvbC/tbvT2Hl9yDpC464yrSUZzMG4Mh413fApQvbo mi5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782272367; x=1782877167; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s0+XSenEQTH5fxmy4dSQBjH5RjWqklrxJNjZYQ6591Q=; b=JFnshCNP8ZzQxrmAr07JnOsV6m32q67+Us261FjfX+Q8foAc6xhwtr2xtoJs3fVZzO ccfyMAApFS0pV+jUjadICuCeVSqxBNg7eT0ZOjiWeajynipHBXqmDqXp7j7eyBwgSp6z 0p7dM5wVwctRs7Xlw5+eTKY36FHtNn8pIBoBeehdOT0/V7KZK08+YoG8ir2TXZTFlONT 2DPUo4mXHL/ayCTBW6a7hrN5tYOiLJYQcjhFNgzuqQ9lZzvJA67V9XuTCxcjqVvAxzZK daIawPrJNJLXOBMbKwB9o1QBFTMV51+Tp8XRwmuuW7fMuHXhgEB0ZnUINi+/2Eak5oTW ALeg== X-Forwarded-Encrypted: i=1; AHgh+Rrphu3eI984Z6Vl8eJoZCJ1wCtsO/tFYSZmQ9FG2iBQJHj8sJYH+L5mGb8RHWeZ3pgdCzlUiMjQGrzyYjg=@vger.kernel.org X-Gm-Message-State: AOJu0YzNu6Wl3NU5vEcFgT/aBx4DD/6iSdn/RPxFD5s0VMhC4rN7uaSX zB+DSn/m/c4VsDbbYyrsAB8GPQAsJGqntef/pkjl+L/dQEe2O3tEo1zTE9gO7sd4Mt6GVc9vDim 0jPA2s1bft+SlnkXIburPZJ99Wd6ix7SWCshi32ThvRfC99c1tK9lN1MDsl6uSg3//w== X-Gm-Gg: AfdE7cmTBuQrVoLDhtKNeMfzZvM5rd73li/V1RgAiwclX1hRHfV2hvoFqO4Bs5Wkreg 5CA49mLc/Bs/C9obIyf115OQCKpD9jfjVU1ON72uC3xxaVuiARkmCp8lN/59uVaBlPcIIChPvZa kAe/ND9W+JlcM7AopzA1h6rv/4G1sIH75g4qjnQx61D30JayEnK6N0c8rSneEYdeUxA1h//lLGX 1uAmwh0Ftj141AtE9loBOLTCCa1uvQFfYT266NDrtbJZEbAfoQTzTwx5+j7x0ljGJPgwODmQzqo 0irg2Fow0/wm476PbD3DDsyEhF7s3LjaE/FVk9wCEDioRiXDqbZJ8Od0JpqnxUtTa7eDX/oUx2U jN4kLUrOad3fLkoBL3qN06K2lddezPz0pOBhpxtlFWZI= X-Received: by 2002:a17:90b:57cc:b0:36d:635b:85a0 with SMTP id 98e67ed59e1d1-37de415329bmr1726668a91.3.1782272366895; Tue, 23 Jun 2026 20:39:26 -0700 (PDT) X-Received: by 2002:a17:90b:57cc:b0:36d:635b:85a0 with SMTP id 98e67ed59e1d1-37de415329bmr1726647a91.3.1782272366408; Tue, 23 Jun 2026 20:39:26 -0700 (PDT) Received: from [192.168.1.86] ([65.181.15.73]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37de3ca3eabsm862534a91.1.2026.06.23.20.39.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 20:39:25 -0700 (PDT) Message-ID: <6971c4b5-d091-4fe2-b843-60da8b32d48b@oss.qualcomm.com> Date: Wed, 24 Jun 2026 13:39:20 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] tee: qcomtee: Drop unused assignment of platform_device_id driver data To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Jens Wiklander Cc: Sumit Garg , linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Amirreza Zarrabi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDAyNiBTYWx0ZWRfX4waOwCBfwJzw EyL5aVTbIoDkD9inWLYDPFYznGYnkWpKoHOjldZSYH3WUtlgTa9vac7/GAXL7t+TVULPQPp/4Mc 5yr78iE0QpHD+BfUIIdqjE3x4iNTZXk= X-Authority-Analysis: v=2.4 cv=b4KCJNGx c=1 sm=1 tr=0 ts=6a3b516f cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=+1+sR1ZYQ3C5TUrBrcwr6g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=IpJZQVW2AAAA:8 a=EUspDBNiAAAA:8 a=zM1L8A4z-D6ZsxyLzxkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-GUID: 16LnhBuH9SzFKDVQk7U0A1XIi7bAMW6c X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDAyNiBTYWx0ZWRfX9gJsE/c/xutv K010omAb58vGzXWW+ZkhUm76TMvxsLetTEfM2B74D0oy6SxQLuW3ZhGY/QzA2t54tAKgLzcNW7J 1jWKG25iUQsgBXDbPTtMzBMIYc9aIKcHOarIG/UTfnODv4wsV7+3Fv6wJ4Y2D4agRjqqhgxrm6V 9kvGdqAI3Y6AEijnLOzpVNdI2wbwltw89ywPI1MZigeAspWoDynnRZZhGOK9m3H5TvbIELEREmN 8GFppepcgLGbUDyKcNlrRKS7L/rJC0NO6iJ8qNKR+YENSycvfAQIy3Zozc5k2Ye1EXNZkCu+NR4 vxhN1fTq1kLeLV1oWvoTQ2C4hWldaaH5n+/uu6niRk3sTPaiAQPEnJbX86M16A6cFKkoFYOaI8Q uCY/JpacCuuZZ1EgiX0DDgngGI55iw== X-Proofpoint-ORIG-GUID: 16LnhBuH9SzFKDVQk7U0A1XIi7bAMW6c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_01,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240026 Hi, On 6/17/2026 12:38 AM, Uwe Kleine-König (The Capable Hub) wrote: > The driver explicitly sets the .driver_data member of struct > platform_device_id to zero without relying on that value. Drop this > unused assignment. > > While touching this array unify spacing and usage of commas and use > a named initializer for .name for improved readability. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) > --- > Hello, > > while this is a cleanup that can stand on its own, it is also a > preparation for a change to struct platform_device_id that requires that > .driver_data isn't assigned by a list initializer. > > Best regards > Uwe > > drivers/tee/qcomtee/call.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/tee/qcomtee/call.c b/drivers/tee/qcomtee/call.c > index 0efc5646242a..4a597eeaf174 100644 > --- a/drivers/tee/qcomtee/call.c > +++ b/drivers/tee/qcomtee/call.c > @@ -798,7 +798,12 @@ static void qcomtee_remove(struct platform_device *pdev) > kfree(qcomtee); > } > > -static const struct platform_device_id qcomtee_ids[] = { { "qcomtee", 0 }, {} }; > +static const struct platform_device_id qcomtee_ids[] = { > + { > + .name = "qcomtee", > + }, > + { } > +}; > MODULE_DEVICE_TABLE(platform, qcomtee_ids); > Looks good to me, thanks. Reviewed-by: Amirreza Zarrabi > static struct platform_driver qcomtee_platform_driver = { > > base-commit: 8d6dbbbe3ba62de0a63e962ee004afb848c8e3ac