From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932280AbdAAQfi (ORCPT ); Sun, 1 Jan 2017 11:35:38 -0500 Received: from mout.web.de ([212.227.15.3]:63501 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932066AbdAAQfg (ORCPT ); Sun, 1 Jan 2017 11:35:36 -0500 Subject: [PATCH 1/5] staging/lustre/llite: Use seq_puts() in three functions To: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org, Andreas Dilger , Ben Evans , Bobi Jam , Emoly Liu , Fan Yong , Greg Kroah-Hartman , Gregoire Pichon , Henri Doreau , James Simmons , Jinshan Xiong , "John L. Hammond" , "Kirill A. Shutemov" , Lai Siyao , Oleg Drokin , Sebastien Buisson , Stephen Champion , wang di References: <45ae8939-a775-865b-ade0-9e38a7ff2b5d@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <6980a3a8-be35-e9a3-fc89-8394d503b80f@users.sourceforge.net> Date: Sun, 1 Jan 2017 17:33:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <45ae8939-a775-865b-ade0-9e38a7ff2b5d@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:DIO1rPexpVoB9s6f7NTHY6h43EtWzKRiaLSFXlu2G15qYTTCXY8 w0mxaxdWHYojnAYQV2oAC9waKVbmlZMk2AwHZGfO8fj3yLNKZAHpnAxQrQ7AGwGuqYLL1v3 D3dWKyMu6aMHHDJEHVpJZNfXEOP++mrFONPyUTU8cksLQSFLaC+LcsNPrqfzk5rnsu2E8RI W8mdP++yHpKQROuh44fHA== X-UI-Out-Filterresults: notjunk:1;V01:K0:XkIm2zIOFzQ=:WAcPYevgfsQIaMRlCxJctU 13m4eLqOmAmTXYukD5jy4q13ZzpL6IlcyNlyFYk3RWT9/5EScEcElH+HRYLnyOk5OY0RSPJo3 +mziIjHVK4+oqoK8emOR3YCHGDC2n/qSHhdf85RhYLjWxXyGrD3NvgxO2Qt/QnDq/18aMXtSr PxTDInZdG4hgww/3PkypMxkHnNpfwTmpAmSj9RiT8Vep8O69NFlnIp8O1uTJaszTTs3itUMWl 5SqP97yq3+BQd1Vwik569ua0od29RJcTcbZ5TTjYKWoHsbsTVRd5aS6MTCPL4srBhnDi/XxoK LYeHfFtWkmQWg3UOgty0b3sKgtcZylMuwyDZmeroLXUskhYPkh+w+HCKZmvCas2F/UpQkjMSk KHgx7/78/HiiSf6+xtPz18g44wjBbngFdMTHjwx6XJP23Ju+FGIMqHWoro6Po7/WCwSp+8mY0 e+3SbySamEV1vGZLYBq7PnsYlJS2ew9OpWVDInCYYthMl8Xav6pukjOlZY+MOqB6PwCQcHMFf R1S4VqewIZ0Rgb5j1wnMb5SAOrfY1+2lNdI+3aGnCLvkPp/R5x4OB5uB+n5McKxJGAGMMHiYg HQn1C5jLIIQCIk5trWV7YkPlo5simB9cWI3oZTcfHAyKNUZDeGwi1oHwCQQVaTz8/3QmYd+Bp ZzHAaWORa5sNkk5oTJJYBFNh+g5/itu3l5tUT8ewcf70F+sOQ8dhwoHNrPZbWaWu2vqV/G+J9 c9lFZ9Xq/2Xi8Dsu/xR5cG1TM6JwLqKCsSY5LlYlCY3HcKUSk2dFnSiAix4CYTpJEI53dUuKh KWv+bww Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 1 Jan 2017 15:30:45 +0100 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts" so that the data output will be a bit more efficient in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/lproc_llite.c b/drivers/staging/lustre/lustre/llite/lproc_llite.c index 03682c10fc9e..b195b7eb2883 100644 --- a/drivers/staging/lustre/lustre/llite/lproc_llite.c +++ b/drivers/staging/lustre/lustre/llite/lproc_llite.c @@ -1325,8 +1325,8 @@ static int ll_rw_extents_stats_pp_seq_show(struct seq_file *seq, void *v) ktime_get_real_ts64(&now); if (!sbi->ll_rw_stats_on) { - seq_printf(seq, "disabled\n" - "write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n"); + seq_puts(seq, "disabled\n" + "write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n"); return 0; } seq_printf(seq, "snapshot_time: %llu.%09lu (secs.usecs)\n", @@ -1403,8 +1403,8 @@ static int ll_rw_extents_stats_seq_show(struct seq_file *seq, void *v) ktime_get_real_ts64(&now); if (!sbi->ll_rw_stats_on) { - seq_printf(seq, "disabled\n" - "write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n"); + seq_puts(seq, "disabled\n" + "write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n"); return 0; } seq_printf(seq, "snapshot_time: %llu.%09lu (secs.usecs)\n", @@ -1583,8 +1583,8 @@ static int ll_rw_offset_stats_seq_show(struct seq_file *seq, void *v) ktime_get_real_ts64(&now); if (!sbi->ll_rw_stats_on) { - seq_printf(seq, "disabled\n" - "write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n"); + seq_puts(seq, "disabled\n" + "write anything in this file to activate, then 0 or \"[D/d]isabled\" to deactivate\n"); return 0; } spin_lock(&sbi->ll_process_lock); -- 2.11.0