From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Md Sadre Alam <quic_mdalam@quicinc.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] arm64: dts: qcom: ipq9574: Add SPI nand support
Date: Mon, 24 Feb 2025 21:36:19 +0100 [thread overview]
Message-ID: <6980c805-92b8-4011-af94-a701a8218548@oss.qualcomm.com> (raw)
In-Reply-To: <20250224113742.2829545-2-quic_mdalam@quicinc.com>
On 24.02.2025 12:37 PM, Md Sadre Alam wrote:
> Add SPI NAND support for ipq9574 SoC.
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
> * Moved changes in ipq9574-rdp-common.dtsi to separate patch
>
> * Prefixed zero for reg address in qpic_bam and qpic_nand
>
> * For full change history, please refer to https://lore.kernel.org/linux-arm-msm/20241120091507.1404368-8-quic_mdalam@quicinc.com/
> ---
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 28 +++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 942290028972..acbcf507adef 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -447,6 +447,34 @@ tcsr: syscon@1937000 {
> reg = <0x01937000 0x21000>;
> };
>
> + qpic_bam: dma-controller@7984000 {
> + compatible = "qcom,bam-v1.7.0";
v1.7.4
> + reg = <0x07984000 0x1c000>;
> + interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc GCC_QPIC_AHB_CLK>;
> + clock-names = "bam_clk";
> + #dma-cells = <1>;
> + qcom,ee = <0>;
> + status = "disabled";
> + };
> +
> + qpic_nand: spi@79b0000 {
> + compatible = "qcom,ipq9574-snand";
> + reg = <0x079b0000 0x10000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&gcc GCC_QPIC_CLK>,
> + <&gcc GCC_QPIC_AHB_CLK>,
> + <&gcc GCC_QPIC_IO_MACRO_CLK>;
> + clock-names = "core", "aon", "iom";
> + dmas = <&qpic_bam 0>,
> + <&qpic_bam 1>,
> + <&qpic_bam 2>;
> + dma-names = "tx", "rx", "cmd";
Please make clock-names & dma-names a vertical list, like clocks and dmas
and shift the nodes so that they're sorted by address
Konrad
next prev parent reply other threads:[~2025-02-24 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 11:37 [PATCH v1 0/3] Add SPI nand support in IPQ9574 Md Sadre Alam
2025-02-24 11:37 ` [PATCH v1 1/3] arm64: dts: qcom: ipq9574: Add SPI nand support Md Sadre Alam
2025-02-24 20:36 ` Konrad Dybcio [this message]
2025-02-28 11:12 ` Md Sadre Alam
2025-02-24 11:37 ` [PATCH v1 2/3] arm64: dts: qcom: ipq9574: Enable SPI NAND for ipq9574 Md Sadre Alam
2025-02-24 20:36 ` Konrad Dybcio
2025-02-28 11:13 ` Md Sadre Alam
2025-02-24 11:37 ` [PATCH v1 3/3] arm64: dts: qcom: ipq9574: Remove eMMC node Md Sadre Alam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6980c805-92b8-4011-af94-a701a8218548@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mdalam@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®