mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
	<quic_vgarodia@quicinc.com>, <krzk+dt@kernel.org>,
	<konradybcio@kernel.org>, <mchehab@kernel.org>, <robh@kernel.org>,
	<conor+dt@kernel.org>, <andersson@kernel.org>,
	<amit.kucheria@oss.qualcomm.com>
Cc: <linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 6/7] arm64: dts: qcom: qcm2290: Add Venus video node
Date: Thu, 10 Jul 2025 15:56:57 +0530	[thread overview]
Message-ID: <6985874e-efae-746d-efbd-dc537b5f24c0@quicinc.com> (raw)
In-Reply-To: <c3803de2-56f3-4346-9490-67cd63abb287@linaro.org>



On 7/10/2025 2:45 PM, Bryan O'Donoghue wrote:
> On 10/07/2025 09:57, Dikshita Agarwal wrote:
>>> +            iommus = <&apps_smmu 0x860 0x0>,
>>> +                 <&apps_smmu 0x880 0x0>,
>>> +                 <&apps_smmu 0x861 0x04>,
>>> +                 <&apps_smmu 0x863 0x0>,
>>> +                 <&apps_smmu 0x804 0xe0>;
>> What’s the rationale behind having five entries here?
>> could you share the use-cases that justify this configuration?
> 
> Already getting in trouble with non-pixel/secure # of iommus.
> 
> Why not specify the maximum expected number hardware supports, specifically
> so we don't end up buried under incomplete schema again ?

Adding this in DT schema is fine, concern here is, adding it to the DT
without a present use-case may be premature. Surprising to see it doesn't
create any boot-up issues.

Thanks,
Dikshita
> 
> ---
> bod

  reply	other threads:[~2025-07-10 10:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 18:05 [PATCH v6 0/7] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez-Ortiz
2025-07-08 18:05 ` [PATCH v6 1/7] media: dt-bindings: venus: Add qcm2290 dt schema Jorge Ramirez-Ortiz
2025-07-14 23:02   ` Dmitry Baryshkov
2025-07-08 18:05 ` [PATCH v6 2/7] media: venus: Conditionally register codec nodes based on firmware version Jorge Ramirez-Ortiz
2025-07-08 18:05 ` [PATCH v6 3/7] media: venus: Add support for AR50_LITE video core Jorge Ramirez-Ortiz
2025-07-10 10:05   ` Dikshita Agarwal
2025-07-11 10:55     ` Jorge Ramirez
2025-07-08 18:05 ` [PATCH v6 4/7] media: venus: hfi_plat_v4: Add capabilities for the 4XX lite core Jorge Ramirez-Ortiz
2025-07-10  9:21   ` Dikshita Agarwal
2025-07-11  9:46     ` Jorge Ramirez
2025-07-12  9:33     ` Jorge Ramirez
2025-07-08 18:05 ` [PATCH v6 5/7] media: venus: core: Add qcm2290 DT compatible and resource data Jorge Ramirez-Ortiz
2025-07-08 18:05 ` [PATCH v6 6/7] arm64: dts: qcom: qcm2290: Add Venus video node Jorge Ramirez-Ortiz
2025-07-10  8:57   ` Dikshita Agarwal
2025-07-10  9:15     ` Bryan O'Donoghue
2025-07-10 10:26       ` Dikshita Agarwal [this message]
2025-07-08 18:05 ` [PATCH v6 7/7] arm64: dts: qcom: qrb2210-rb1: Enable Venus Jorge Ramirez-Ortiz
2025-07-10  7:54 ` [PATCH v6 0/7] media: venus: Add QCM2290 support with AR50_LITE core Jorge Ramirez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6985874e-efae-746d-efbd-dc537b5f24c0@quicinc.com \
    --to=quic_dikshita@quicinc.com \
    --cc=amit.kucheria@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jorge.ramirez@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=quic_vgarodia@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®