From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbdK2NXi (ORCPT ); Wed, 29 Nov 2017 08:23:38 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59964 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753315AbdK2NXg (ORCPT ); Wed, 29 Nov 2017 08:23:36 -0500 Subject: Re: [PATCH] perf annotate: Fix objdump comment parsing for Intel mov dissassembly To: Thomas Richter Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, brueckner@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, Ravi Bangoria References: <20171128075632.72182-1-tmricht@linux.vnet.ibm.com> From: Ravi Bangoria Date: Wed, 29 Nov 2017 18:54:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171128075632.72182-1-tmricht@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17112913-0040-0000-0000-000003F3F893 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17112913-0041-0000-0000-000025F6DADE Message-Id: <69859e3b-cb22-a536-79ca-ffc44c3f86a8@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-29_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711290172 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2017 01:26 PM, Thomas Richter wrote: > The command 'perf annotate' parses the output of objdump and also > investigates the comments produced by objdump. For example the > output of objdump produces (on x86): > > 23eee: 4c 8b 3d 13 01 21 00 mov 0x210113(%rip),%r15 > # 234008 > > and the function mov__parse() is called to investigate the complete > line. Mov__parse() breaks this line into several parts and finally > calls function comment__symbol() to parse the data after the comment > character '#'. Comment__symbol() expects a hexadecimal address followed > by a symbol in '<' and '>' brackets. > > However the 2nd parameter given to function comment__symbol() > always points to the comment character '#'. The address parsing > always returns 0 because the character '#' is not a digit and > strtoull() fails without being noticed. > > Fix this by advancing the second parameter to function comment__symbol() > by one byte before invocation and add an error check after strtoull() > has been called. Yeah, looks like it fails to get correct value in 'addrp'. Can you please show the difference in perf annotate output before and after patch. Thanks, Ravi