From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8568BC43613 for ; Fri, 21 Jun 2019 17:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5ED1C20675 for ; Fri, 21 Jun 2019 17:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbfFUR1r (ORCPT ); Fri, 21 Jun 2019 13:27:47 -0400 Received: from smtprelay0186.hostedemail.com ([216.40.44.186]:50306 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726032AbfFUR1q (ORCPT ); Fri, 21 Jun 2019 13:27:46 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 3F510100E806B; Fri, 21 Jun 2019 17:27:45 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cream64_93b04b7d1048 X-Filterd-Recvd-Size: 3436 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Fri, 21 Jun 2019 17:27:43 +0000 (UTC) Message-ID: <698d3e3614ae903ae9582547d64c6a9846629e57.camel@perches.com> Subject: Re: [PATCH 0/3] net: ethernet: atheros: atlx: Use PCI generic definitions instead of private duplicates From: Joe Perches To: Bjorn Helgaas , Puranjay Mohan , Jay Cliburn , Chris Snook Cc: Shuah Khan , Bjorn Helgaas , netdev , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Linux PCI Date: Fri, 21 Jun 2019 10:27:41 -0700 In-Reply-To: References: <20190621163921.26188-1-puranjay12@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (adding the atlx maintainers to cc) On Fri, 2019-06-21 at 12:11 -0500, Bjorn Helgaas wrote: > On Fri, Jun 21, 2019 at 11:39 AM Puranjay Mohan wrote: > > This patch series removes the private duplicates of PCI definitions in > > favour of generic definitions defined in pci_regs.h. > > > > Puranjay Mohan (3): > > net: ethernet: atheros: atlx: Rename local PCI defines to generic > > names > > net: ethernet: atheros: atlx: Include generic PCI definitions > > net: ethernet: atheros: atlx: Remove unused and private PCI > > definitions > > > > drivers/net/ethernet/atheros/atlx/atl2.c | 5 +++-- > > drivers/net/ethernet/atheros/atlx/atl2.h | 2 -- > > drivers/net/ethernet/atheros/atlx/atlx.h | 1 - > > 3 files changed, 3 insertions(+), 5 deletions(-) > > Let's slow this down a little bit; I'm afraid we're going to overwhelm folks. I generally disagree. Consolidation of these sorts of changes are generally better done treewide all at once, posted as a series to a list and maintainers allowing time (weeks to months) for the specific maintainers to accept them and then whatever remainder exists reposted and possibly applied by an overall maintainer (e.g.: Dave M) > Before posting more to LKML/netdev, how about we first complete a > sweep of all the drivers to see what we're getting into. It could be > that this will end up being more churn than it's worth. Also doubtful. Subsystem specific local PCI #defines without generic naming is poor style and makes treewide grep and refactoring much more difficult. The atlx maintainers should definitely have been cc'd on these patches. Jay Cliburn (maintainer:ATLX ETHERNET DRIVERS) Chris Snook (maintainer:ATLX ETHERNET DRIVERS) Puranjay, can you please do a few things more here: 1: Make sure you use scripts/get_maintainer.pl to cc the appropriate people. 2: Show that you compiled the object files and verified where possible that there are no object file changes. 3: State that there are no object changes in the proposed commit log. thanks.