mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joel Fernandes <joelagnelf@nvidia.com>
To: Tiffany Yang <ynaffit@google.com>, linux-kernel@vger.kernel.org
Cc: keescook@google.com, kernel-team@android.com,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Christian Brauner" <brauner@kernel.org>,
	"Carlos Llamas" <cmllamas@google.com>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"David Gow" <davidgow@google.com>, "Rae Moar" <rmoar@google.com>,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH v4 0/6] binder: Set up KUnit tests for alloc
Date: Mon, 21 Jul 2025 12:22:09 -0400	[thread overview]
Message-ID: <699122f8-e6c4-4c0d-ab2f-3e1de2c8921e@nvidia.com> (raw)
In-Reply-To: <20250717011011.3365074-1-ynaffit@google.com>



On 7/16/2025 9:10 PM, Tiffany Yang wrote:
> Hello,
> 
> binder_alloc_selftest provides a robust set of checks for the binder
> allocator, but it rarely runs because it must hook into a running binder
> process and block all other binder threads until it completes. The test
> itself is a good candidate for conversion to KUnit, and it can be
> further isolated from user processes by using a test-specific lru
> freelist instead of the global one. This series converts the selftest
> to KUnit to make it less burdensome to run and to set up a foundation
> for unit testing future binder_alloc changes.
> 
> Thanks,
> Tiffany
> 
> Tiffany Yang (6):
>   binder: Fix selftest page indexing
>   binder: Store lru freelist in binder_alloc
>   kunit: test: Export kunit_attach_mm()
>   binder: Scaffolding for binder_alloc KUnit tests
>   binder: Convert binder_alloc selftests to KUnit
>   binder: encapsulate individual alloc test cases


Looks good to me!  And I learnt a bunch of kunit from reading this too. :)

Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>

 - Joel


      parent reply	other threads:[~2025-07-21 16:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17  1:10 Tiffany Yang
2025-07-17  1:10 ` [PATCH v4 1/6] binder: Fix selftest page indexing Tiffany Yang
2025-07-17  6:23   ` Kees Cook
2025-07-17  1:10 ` [PATCH v4 2/6] binder: Store lru freelist in binder_alloc Tiffany Yang
2025-07-17  6:23   ` Kees Cook
2025-07-17  1:10 ` [PATCH v4 3/6] kunit: test: Export kunit_attach_mm() Tiffany Yang
2025-07-17  1:10 ` [PATCH v4 4/6] binder: Scaffolding for binder_alloc KUnit tests Tiffany Yang
2025-07-17  1:10 ` [PATCH v4 5/6] binder: Convert binder_alloc selftests to KUnit Tiffany Yang
2025-07-17  6:33   ` Kees Cook
2025-07-17  1:10 ` [PATCH v4 6/6] binder: encapsulate individual alloc test cases Tiffany Yang
2025-07-17  6:32   ` Kees Cook
2025-07-17  7:34     ` Kees Cook
2025-07-17 14:41 ` [PATCH v4 0/6] binder: Set up KUnit tests for alloc Greg Kroah-Hartman
2025-07-21 16:22 ` Joel Fernandes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=699122f8-e6c4-4c0d-ab2f-3e1de2c8921e@nvidia.com \
    --to=joelagnelf@nvidia.com \
    --cc=arve@android.com \
    --cc=brauner@kernel.org \
    --cc=brendan.higgins@linux.dev \
    --cc=cmllamas@google.com \
    --cc=davidgow@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@google.com \
    --cc=kernel-team@android.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maco@android.com \
    --cc=rmoar@google.com \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    --cc=ynaffit@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®