From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3837AC433EF for ; Mon, 9 Sep 2019 02:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1575B21907 for ; Mon, 9 Sep 2019 02:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733251AbfIIC5P (ORCPT ); Sun, 8 Sep 2019 22:57:15 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2174 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731983AbfIIC5O (ORCPT ); Sun, 8 Sep 2019 22:57:14 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3F5596BA153CDAEA09DD; Mon, 9 Sep 2019 10:57:12 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 10:57:09 +0800 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: do not select same victim right again To: Jaegeuk Kim , , References: <20190909012532.20454-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <69933b7f-48cc-47f9-ba6f-b5ca8f733cba@huawei.com> Date: Mon, 9 Sep 2019 10:56:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190909012532.20454-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/9/9 9:25, Jaegeuk Kim wrote: > GC must avoid select the same victim again. Blocks in previous victim will occupy addition free segment, I doubt after this change, FGGC may encounter out-of-free space issue more frequently. Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index e88f98ddf396..15ca8bbb0b22 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -274,6 +274,9 @@ static unsigned int get_cb_cost(struct f2fs_sb_info *sbi, unsigned int segno) > static inline unsigned int get_gc_cost(struct f2fs_sb_info *sbi, > unsigned int segno, struct victim_sel_policy *p) > { > + if (sbi->cur_victim_sec == GET_SEC_FROM_SEG(sbi, segno)) > + return UINT_MAX; > + > if (p->alloc_mode == SSR) > return get_seg_entry(sbi, segno)->ckpt_valid_blocks; > > @@ -1326,9 +1329,6 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, > round++; > } > > - if (gc_type == FG_GC) > - sbi->cur_victim_sec = NULL_SEGNO; > - > if (sync) > goto stop; > >