From: Moteen Shah <m-shah@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <conor+dt@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<nm@ti.com>, <ssantosh@kernel.org>, <u-kumar1@ti.com>,
<gehariprasath@ti.com>, <vigneshr@ti.com>, <afd@ti.com>,
<a-limaye@ti.com>, <y-abhilashchandra@ti.com>, <johan@kernel.org>,
<kees@kernel.org>, <jm@ti.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/4] dt-bindings: soc: ti: Document the ti,tda54-mcu-scm-conf
Date: Mon, 16 Nov 2026 17:03:34 +0530 [thread overview]
Message-ID: <699420d5-28b8-4238-8fc4-3a4e762265ba@ti.com> (raw)
In-Reply-To: <20261113-fancy-trogon-of-saturation-16fc66@quoll>
Hey Krzysztof,
On 13/11/26 13:26, Krzysztof Kozlowski wrote:
> On Thu, Nov 12, 2026 at 02:40:24PM +0530, Moteen Shah wrote:
>> + reg:
>> + maxItems: 1
>> +
>> + ti,proxy-id:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 7
>> + description:
>> + Proxy region (0-7) through which this node's clients access
>> + claimable registers and their fault status registers.
> Partially continuing discussion from v2, IOW, device cannot access
> entire address space and you need to limit the address space to specific
> window of it? At least this is how it looks in driver code.
>
> This looks like the MMIO space is wrong. Listen, if you claim that the
> DTB represents the host (or VM) view on hardware and based on that you
> add proxy-id property to restrict the MMIO, then why do you claim that
> entire MMIO is correct for this host (or VM) in the first place?
Thanks for the review, I got your point.
One thing I wanted to clarify before sending a revision: a nonzero proxy
sets a bit in its CLAIM register to claim a register but for proxy 0 it
shouldn't be doing that as per the hardware. If we choose to use proxy
0's reg window we just have to check if any other proxy has claimed it
previously or no. Are you fine with having a property in the binding
something like "proxy-0" or alternatively "ti,claim-required", because
the driver won't be able to makeout which proxy it has the view of.
Regards,
Moteen
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2026-11-16 11:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 9:10 [PATCH v4 0/4] soc: ti: Add TDA54 SCM configuration syscon support Moteen Shah
2026-11-12 9:10 ` [PATCH v4 1/4] dt-bindings: soc: ti: Document the ti,tda54-mcu-scm-conf Moteen Shah
2026-11-13 7:56 ` Krzysztof Kozlowski
2026-11-16 11:33 ` Moteen Shah [this message]
2026-11-12 9:10 ` [PATCH v4 2/4] soc: ti: k3-socinfo: Use device managed allocations and unregistration Moteen Shah
2026-11-12 9:10 ` [PATCH v4 3/4] soc: ti: k3-socinfo: Export SoC registration helper Moteen Shah
2026-11-12 9:10 ` [PATCH v4 4/4] soc: ti: Add TDA54 SCM configuration syscon support Moteen Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=699420d5-28b8-4238-8fc4-3a4e762265ba@ti.com \
--to=m-shah@ti.com \
--cc=a-limaye@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gehariprasath@ti.com \
--cc=jm@ti.com \
--cc=johan@kernel.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®