From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout12.his.huawei.com (canpmsgout12.his.huawei.com [113.46.200.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE963093B5; Fri, 13 Mar 2026 02:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773369025; cv=none; b=XIJrnO7bR2GbP3umsRt3jfkdhvZcC4mq6mkUyRUcbi3o7T0gR89xifGgdD4CiMIjVxQAKvQwu8pVA+dt6WUp28KIkfS4rl/+noK9x1CwOw6DbJKDBkLhiIoVmSDFe0lanqOI3FffgC1z/V6jxmKQ1m8gRUUj24H3Xpa5fvKRlg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773369025; c=relaxed/simple; bh=W/foNPav97/R1NSG+CGx/D58xEyvpkNi6medIrP+C6Q=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=tbrPB7aYjqvVIBGgSIiLHAGL3Moezh2hbGjsLMDp8mm3Ct8Q0+yipsJ14RpaHFAPM/Pu91SHjjLF/hBdge8Gx0M1FHGUOXOQWB8Q9SSyUAvUj2nq5bQtn8r/rRT7J/FOkekSXXtN4eCRMUBTGVtBiPyEoId9/ZmZ+2jP5FFFHkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=2MIeAfhQ; arc=none smtp.client-ip=113.46.200.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="2MIeAfhQ" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=CVkB4K6yegSE+n79ThisbSxU7cMPDcr1n6IOBQnBrIM=; b=2MIeAfhQxyTndrqGx6t5o31MFsRiG77XtXY34XUO7DkiajhwGBA/mw3XKKYJw98GhroY7x9oR ZDuUg+PHLgfHz6ntw9twsM8tzX3A2VuZkh9UNQOhbLPswsT/Z5MluwK4Fi4c98OhfzTrgVYMsZA OvT6o9I1lcIszGmULdjTf3M= Received: from mail.maildlp.com (unknown [172.19.163.163]) by canpmsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4fX7bw5Z58znTwX; Fri, 13 Mar 2026 10:24:44 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id 847034048B; Fri, 13 Mar 2026 10:30:19 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 13 Mar 2026 10:30:17 +0800 Message-ID: <699a428a-6271-4369-83f4-8b1f2e1bfa42@huawei.com> Date: Fri, 13 Mar 2026 10:30:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] ACPI: Rename get_acpi_id_for_cpu() to acpi_get_cpu_uid() on non-x86 To: Jonathan Cameron CC: Bjorn Helgaas , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Jonathan Corbet , Shuah Khan , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H . Peter Anvin" , Juergen Gross , Boris Ostrovsky , Len Brown , Sunil V L , Mark Rutland , Kees Cook , Yanteng Si , Sean Christopherson , Kai Huang , Tom Lendacky , Thomas Huth , Thorsten Blum , Kevin Loughlin , Zheyun Shen , Peter Zijlstra , Pawan Gupta , Xin Li , "Ahmed S . Darwish" , Sohil Mehta , Ilkka Koskinen , Robin Murphy , James Clark , Besar Wicaksono , Ma Ke , Wei Huang , Andy Gospodarek , Somnath Kotur , , , , , , , , , , , , , , , , , , , , , , , References: <20260312072316.4806-1-fengchengwen@huawei.com> <20260312072316.4806-2-fengchengwen@huawei.com> <20260312110742.00002716@huawei.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20260312110742.00002716@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemk500009.china.huawei.com (7.202.194.94) On 3/12/2026 7:07 PM, Jonathan Cameron wrote: > On Thu, 12 Mar 2026 15:23:14 +0800 > Chengwen Feng wrote: > >> To unify the CPU ACPI ID retrieval interface across architectures, >> rename the existing get_acpi_id_for_cpu() function to >> acpi_get_cpu_uid() on arm64/riscv/loongarch platforms. >> >> This is a pure rename with no functional change, preparing for a > > It's not just a rename. This should mention that the addition of error > checks and hence the resulting signature change. Sorry for overlooking this, it has already been fixed in v7. And v7 also fix below review comments. Thanks > >> consistent ACPI Processor UID retrieval interface across all ACPI-enabled >> platforms. >> >> Note: Move the ARM64-specific get_cpu_for_acpi_id() implementation to >> arch/arm64/kernel/acpi_numa.c to fix compilation errors from >> circular header dependencies introduced by the rename. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Chengwen Feng >> Reviewed-by: Jonathan Cameron > From a reread, a few minor style consistency things inline. > ... >