From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 119F135F8AC for ; Wed, 24 Dec 2025 13:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766584297; cv=none; b=p+vL/kesJQ/ifV0f1yILOn1kC/0PNMl7auqptozO2TPCDdDk4xasqkTkXjgpdqwJITtv1kNTMipE52BLFTHF1GvURP9Vfm/9uRhqVTcga80g5+2lL3GaotBewfTvlgE10HbB1Ab+JhfDmH7rwlvLKJK0BiChTlBAK+BIPcqeiAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766584297; c=relaxed/simple; bh=sHiiB5bXZsqhP9gX8KjsvqSPrH/xDtqYsun5t11H5T8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=shyN5SrZohr3yB+V3hpTRcVA9YcuC3g5XMLqYEZ1kUmHK678pNqP3W1XEobUtcClEcPU6yhjFNcZ9ItECQJoNpaKWoODA07wQTjFKlvN87zOoa9TxYLsB2KmpyOxvsPtsr/gAYVe2AJapsvClS/e+lGwRfVS7ZfziCmqTV5neAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=LSjYnGje; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LSjYnGje" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47796a837c7so40318095e9.0 for ; Wed, 24 Dec 2025 05:51:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1766584294; x=1767189094; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N/ZzF1obUaDPXRtg/yqUVnjeEhP/ZAQCXQITZaB2iu8=; b=LSjYnGjeXzbusA1CqoGfYxC8at+FB3Yryz7hNSqXUeHgjdz8GLYa4x+XV8UXTRRfHL 7VGnajBoBW1KlXMDvZKPQLh17+pQ6TOUME/rEZ6UNWFUjJsnQT9aIyjj7/evRBsVuk48 MeNy2HIc6qSUweHP0lBOGPICeuX0e/NCsfC9M9HOuvM7dmr3QcE5Y/VbjFYKLDgNecXb lj6gCxv5G2xezSBLwwxyzDFkq6toJyfM96zWhfVETMdj3xJxr9dQMH56e90Y6SyWHL7Z mTiE2+Jlrvj7bPbaVSXIWm3OKnhyLt5HJ5/Uk7w65x4VLpvKJxs+aWBUC0CPg5goge93 3/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766584294; x=1767189094; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N/ZzF1obUaDPXRtg/yqUVnjeEhP/ZAQCXQITZaB2iu8=; b=fH0t6Ub1UUX6UUJIYTGodYTLoSgr7+rGkHDjgZYakbBc2Xij29yzb+sUYdU3+vDKCk XXJO8OCxOlvfG/iVVo04zLt1M4cfAW1azYQNW8a/Z07EREcrn2xzdCF09j88VfxWggVT fmDTCHClNhbPnMrR6CfbYHNCtdrEMoaxD1iGahqNFKc4vIxJpS5Qt0gAuD46UrgqaDWK 6iBTVfjDVqTMSgdwSp7R5z3LVHsmbtJY2Dn+IuZkuBsqUHNubk4ykKES0Zt8cJmQpfDG 0PVz6s2kAAoFf1sUwXXNpdvu1GLmCl32aqVGfJy8Mlavu5j+ajICkM7aNFwbDQyWiOiT F91A== X-Gm-Message-State: AOJu0YyvHZcYM/NaR1pqqfUqyKV6qVt6UW3hbYnQVnfauaV1yoSJcih1 kXR2WInlkeZwepYnsYSKN3ZC8busvn/k7bQ9d7/rEZNNi32Mh55Nke2OWQyKCIM9v/8= X-Gm-Gg: AY/fxX7yaqJxVhRGLt6AUkLG+F4NT+fJ/mSbZJQUfH+jH68evNE853I63OS4Pm39EL0 ZEVAssv4HbPWS4K4foF5pNdVU4jyqWlEofimd/gvzMf5hRWBtUnqDR10HopEHRrA8PwWgKossrb kV1l0Mq9UB4/+YFCjOORgn3o4KDv18hFpksHjfXyHFX0TrxAyxLKwNIDhPH0lwEM+qMRBrHe3BW ISIcXXzcB6EnBAeAothFUHJhdYc9EVEZGTjZaawQiecftdLe8zVXCeybHSOZJCXh+ZvvHCzG65k lbfkyjY/QsePUYFT5Lqy+jZErfc43OhCKPSGtLNyoJT7DDlM8ZodaUfEY20VS3hDleege73yhbp te5wfM/2UD4WqAyYtccVFRaMIdSClrIkFBjTkOe2KGLtJD2JlUDC+Ise925pFFopMzV9i1WrxIw yOHaGcbHEKLOKG3Uy7 X-Google-Smtp-Source: AGHT+IHoSRL1o3IUph4veUjp/8KyyN5BGuaOL926mUFfGKUJUv97WAdZyC8VGREHkTIDjwSD0Z111Q== X-Received: by 2002:a05:600c:1d1d:b0:477:8ba7:fe0a with SMTP id 5b1f17b1804b1-47d1957da90mr176764295e9.24.1766584294440; Wed, 24 Dec 2025 05:51:34 -0800 (PST) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d193e329asm297696205e9.15.2025.12.24.05.51.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 05:51:33 -0800 (PST) Message-ID: <69a098d8-ff54-4746-96d5-5ce5eb2a8a83@linaro.org> Date: Wed, 24 Dec 2025 13:51:33 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] tools headers: Don't check arm64's unistd.h To: Leo Yan , Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Namhyung Kim , Jiri Olsa , Ian Rogers , Adrian Hunter References: <20251222-perf_fix_syscall_header-v3-0-eb4a8b9dfe66@arm.com> <20251222-perf_fix_syscall_header-v3-3-eb4a8b9dfe66@arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20251222-perf_fix_syscall_header-v3-3-eb4a8b9dfe66@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/12/2025 6:06 pm, Leo Yan wrote: > The arm64 unistd.h in tools now diverges from the kernel header. > Comparing the two headers is pointless, remove the check. > > Signed-off-by: Leo Yan > --- > tools/perf/check-headers.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh > index e0537f275da2f79ea9e05b91300aa1e2f996e9f1..da3aca87457fdc56c96d4184f2dee88dab026d98 100755 > --- a/tools/perf/check-headers.sh > +++ b/tools/perf/check-headers.sh > @@ -54,7 +54,6 @@ declare -a FILES=( > "arch/s390/include/uapi/asm/kvm.h" > "arch/s390/include/uapi/asm/sie.h" > "arch/arm64/include/uapi/asm/kvm.h" > - "arch/arm64/include/uapi/asm/unistd.h" Isn't this _more_ of a special case for arm64 than continuing to do the consistency check like in v2? It seems like the desire for consistency isn't taking the whole tools/ picture into account and we end up adding more inconsistencies than just the regular static copy + diff check that we have for all the other headers. > "arch/alpha/include/uapi/asm/errno.h" > "arch/mips/include/asm/errno.h" > "arch/mips/include/uapi/asm/errno.h" >