From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B15C433DF for ; Fri, 31 Jul 2020 09:59:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2209D2074B for ; Fri, 31 Jul 2020 09:59:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gMBcfMGP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732480AbgGaJ7g (ORCPT ); Fri, 31 Jul 2020 05:59:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732140AbgGaJ7g (ORCPT ); Fri, 31 Jul 2020 05:59:36 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED8D2C061575 for ; Fri, 31 Jul 2020 02:59:35 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id g8so8065713wmk.3 for ; Fri, 31 Jul 2020 02:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=39y7P5Gwjtd3AnR6h3PLwZ8s2R2z4M9PxJEGWiapqVU=; b=gMBcfMGPW7ErBYTjBzW9QJveMfkgYy+NHBk+SKKkE3vKX6tn6MYhI5L9eaKWiCyrdT dpdxpJHinGrmrxPUESyzm42z/NBEQiFWdbEnpE1i9XCy7F3Bq6MdcMODWuhs70/YnNkm ki/EwEm6VNZJlhL6QTfSro3pePGkWLwPxHhweAuFvbMMHVKF5FaluqeHAWlhqN6ZKipk k3fR+QMmx1+gGaakLPIJ+GqWYoirAt0rEuK6jQQ4z2GkfH4RhHmHMFkmT80EaUBVRrf9 dOB+yFdrvGIhzZt7yeSqOrXuPo/PihoNrsY1n5qO2BpPPhLlazO9ZUuTJ/OVGxL00hKj B2XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=39y7P5Gwjtd3AnR6h3PLwZ8s2R2z4M9PxJEGWiapqVU=; b=ieUpNePqbBEy0RVqumjSNZdexPy8W3ZLzf/fa53ShI7laEgx0/FGFXPWnfKl0vBVyG ITh1PyEzM1TtNTZ0KdhtkHnkyqsGm6Mlue2iEMSius4fazK9nzN8UqnzjywM8Re2ajhO GwW0sP/RRjYhawhXKgvwj0Rpum4N2eGheWy/Ymozl3GjIgv6S46Gf2PsCh53CQKmH2aW DHKSytFYrir8BhCN8W2xBTLjoSJESbnrJsrj2lOG5Rcl4Wr5nquhf26GUDCkQWtppUXB d5NVvJ68CSeeraNdefrqCSyGkydiqrpF3QK4Ccqdrr+t6tPv1plye+5Crg8RhU5BCadS k9SQ== X-Gm-Message-State: AOAM533o1Vhlb/WNYEOIf/Kh6bYugEk9cvOXhLpR7NMiohIxisHQuBLC lm8BpeXCV2j6ydSRR2DZxRNDkA== X-Google-Smtp-Source: ABdhPJwX7zxARepQDDTP7uSmPjHKWK16wvj2up1Cti71adU9OAdqJiNWJ5CPpT1ecG7IJPqtGWIxxQ== X-Received: by 2002:a7b:c242:: with SMTP id b2mr3336543wmj.90.1596189574501; Fri, 31 Jul 2020 02:59:34 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:e484:a7d1:6931:9059? ([2a01:e34:ed2f:f020:e484:a7d1:6931:9059]) by smtp.googlemail.com with ESMTPSA id s125sm12875748wmf.14.2020.07.31.02.59.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2020 02:59:33 -0700 (PDT) Subject: Re: [PATCH] thermal: mediatek: Fix missing selection To: Henry Yen , Zhang Rui , Amit Kucheria , Matthias Brugger Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Steven Liu , Michael Kao , Arnd Bergmann References: <1596096304-16422-1-git-send-email-henry.yen@mediatek.com> From: Daniel Lezcano Message-ID: <69a4b653-9f47-63f1-7eb0-4880bf19497a@linaro.org> Date: Fri, 31 Jul 2020 11:59:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1596096304-16422-1-git-send-email-henry.yen@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Henry, cc'ing Arnd On 30/07/2020 10:05, Henry Yen wrote: > Mediatek thermal driver is compatible with multiple platforms. > Some of the platforms (e.g., MT2701) requires to enable > MEDIATEK_MT6577_AUXADC option. If lacks the config, the driver > will not be able to read correct temperature. > > To fix it, select missing MEDIATEK_MT6577_AUXADC config. The description states there is a dependency for some platforms not all of them. The change will select the option every time for any mediatek platform or compile test. I don't think it is the place to select the option. > Signed-off-by: Henry Yen > --- > drivers/thermal/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 3eb2348e5242..3a37f674f7f3 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -409,6 +409,7 @@ config MTK_THERMAL > depends on NVMEM || NVMEM=n > depends on RESET_CONTROLLER > default y > + select MEDIATEK_MT6577_AUXADC > help > Enable this option if you want to have support for thermal management > controller present in Mediatek SoCs > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog