mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Vinod Polimera <quic_vpolimer@quicinc.com>,
	dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com,
	dianders@chromium.org, swboyd@chromium.org,
	quic_kalyant@quicinc.com, quic_khsieh@quicinc.com,
	quic_vproddut@quicinc.com, quic_bjorande@quicinc.com,
	quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com
Subject: Re: [PATCH Resend v11 14/15] drm/msm/disp/dpu: clear active interface in the datapath cleanup
Date: Tue, 24 Jan 2023 02:28:22 +0200	[thread overview]
Message-ID: <69a62eb8-a7dd-3a73-e02d-b4bc332e2aef@linaro.org> (raw)
In-Reply-To: <1674138393-475-15-git-send-email-quic_vpolimer@quicinc.com>

On 19/01/2023 16:26, Vinod Polimera wrote:
> Clear interface active register from the datapath for a clean shutdown of
> the datapath.
> 
> Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 9cf1263..30dee50 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -2085,6 +2085,9 @@ void dpu_encoder_helper_phys_cleanup(struct dpu_encoder_phys *phys_enc)
>   	if (phys_enc->hw_pp->merge_3d)
>   		intf_cfg.merge_3d = phys_enc->hw_pp->merge_3d->idx;
>   
> +	if (phys_enc->hw_intf)
> +		intf_cfg.intf = phys_enc->hw_intf->idx;
> +
>   	if (ctl->ops.reset_intf_cfg)
>   		ctl->ops.reset_intf_cfg(ctl, &intf_cfg);
>   

This is already handled as a part of the commit
9811913a6dd0 ("drm/msm/dpu: populate wb or intf before reset_intf_cfg")
-- 
With best wishes
Dmitry


  reply	other threads:[~2023-01-24  0:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19 14:26 [PATCH Resend v11 00/15] Add PSR support for eDP Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 01/15] drm: add helper functions to retrieve old and new crtc Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 02/15] drm/msm/dp: use atomic callbacks for DP bridge ops Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 03/15] drm/msm/dp: Add basic PSR support for eDP Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 04/15] drm/msm/dp: use the eDP bridge ops to validate eDP modes Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 05/15] drm/msm/dp: disable self_refresh_aware after entering psr Vinod Polimera
2023-01-24  0:21   ` Dmitry Baryshkov
2023-01-24 15:09     ` Vinod Polimera
2023-01-24 16:45       ` Dmitry Baryshkov
2023-01-27 15:00         ` Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 06/15] drm/bridge: use atomic enable/disable callbacks for panel bridge Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 07/15] drm/bridge: add psr support for panel bridge callbacks Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 08/15] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 09/15] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 10/15] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver Vinod Polimera
2023-01-19 14:26 ` [PATCH Resend v11 11/15] drm/msm/disp/dpu: get timing engine status from intf status register Vinod Polimera
2023-01-24  0:24   ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 12/15] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled Vinod Polimera
2023-01-24  0:25   ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 13/15] drm/msm/disp/dpu: reset the datapath after timing engine disable Vinod Polimera
2023-01-24  0:26   ` Dmitry Baryshkov
2023-01-19 14:26 ` [PATCH Resend v11 14/15] drm/msm/disp/dpu: clear active interface in the datapath cleanup Vinod Polimera
2023-01-24  0:28   ` Dmitry Baryshkov [this message]
2023-01-19 14:26 ` [PATCH Resend v11 15/15] drm/msm/disp/dpu: update dpu_enc crtc state on crtc enable/disable during self refresh Vinod Polimera
2023-01-24  0:30   ` Dmitry Baryshkov
2023-01-24  0:32 ` [PATCH Resend v11 00/15] Add PSR support for eDP Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69a62eb8-a7dd-3a73-e02d-b4bc332e2aef@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_bjorande@quicinc.com \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=quic_vpolimer@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®