From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF759C433FE for ; Sun, 9 Oct 2022 15:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229914AbiJIPQm (ORCPT ); Sun, 9 Oct 2022 11:16:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbiJIPQj (ORCPT ); Sun, 9 Oct 2022 11:16:39 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DE5729CA0 for ; Sun, 9 Oct 2022 08:16:37 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id x25so1865293qki.2 for ; Sun, 09 Oct 2022 08:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=nMoVhDHOXbkfrQHXkDjBBWNzAhgx6kAOiO9M5hP5GW8=; b=u3ZfctBM9b1dd8Z0PEQMKq5aDzD+Sngf7/9n36/FFKr9PxVJozWgk+Dl8Q81ukH1vy FtRFmO1lGoX9+XayULTcP/M1lDGeB4Ux9FFb9d1fA2awfYI1kLbe7vXDBuxmXpgw0TTG o1dY/SgID1zy14Wy332bPImnXKgpJMQsOhzvZZUzkRYvJtSURYmtIwZIwX2AFADmv5ZI LulnMJ0la5z5Mt8Zgh8SehBBsJ7G5luciXaFbYVqqR9SqAOYZ5O2lZugCrQafl4SZpUj lgNufci6R/qj0VeyfTLP6lZr2Wv0QYDQNeopSK9Y+uwpuE9yrXhvLEoMEJEfkTfFhHo7 Fq+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nMoVhDHOXbkfrQHXkDjBBWNzAhgx6kAOiO9M5hP5GW8=; b=RNvkuQFVHEUXJ200fs/pusUo+39msz8H2yUDgW046LKrMK9jn992Wo9UMIr+vb8MZ2 5d3+UVh6UOomAr5abIRwE6M1O/G7AGuDXB/h7mxY7Ocr2bAPySWlVeXss4s8a4lAHR3o WUqQ8ZV4htLP5Mh9UMiCV/LtEszIvE1LMr3kYGo/BEeNkZk4WC4WXXFf7wMRNYmVVBpU ECIaOzh5PshRjfa/bbXS+QgaY+oDyBFmx8P1fo5RcuslceI7FaUqpOAA2gGxygf0rraO WAPhXtBayMnS0hW7AEL4gEaORIJHgLep/PIaZRwd8bjcFDIZC3FVY+kLdkpTp7JwSlGC e6eA== X-Gm-Message-State: ACrzQf139mEvNGDhBDylfabz03QMgj5cP8PA5QnikKw5xhTPMhqgD7GT 1bT+SeswGL9BOk8e0j5Vn6YZHHosNrbFUA== X-Google-Smtp-Source: AMsMyM5t905CkC2pl9ZhiooQYt86bJuYi8XfqiZzuanYsiUD8E3vQoIIdhEAJjVCGGpu+HO0b6ENog== X-Received: by 2002:a05:620a:2627:b0:6b9:1b05:7b9 with SMTP id z39-20020a05620a262700b006b91b0507b9mr10396742qko.776.1665328596650; Sun, 09 Oct 2022 08:16:36 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id l18-20020a37f912000000b006ce580c2663sm7516046qkj.35.2022.10.09.08.16.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Oct 2022 08:16:35 -0700 (PDT) Message-ID: <69ac49d8-1a4e-c830-fd7d-08f7ec1e1fa1@linaro.org> Date: Sun, 9 Oct 2022 17:14:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v1 2/2] dt-bindings: hpet: add loongson2k hpet binding To: Yinbo Zhu , Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Huacai Chen , WANG Xuerui , Jiaxun Yang , Jianmin Lv , Yun Liu , Yang Li , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, loongarch@lists.linux.dev References: <20220930093510.10781-1-zhuyinbo@loongson.cn> <20220930093510.10781-2-zhuyinbo@loongson.cn> <80af028d-d123-6894-189a-a26134ec89ee@loongson.cn> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <80af028d-d123-6894-189a-a26134ec89ee@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/2022 05:21, Yinbo Zhu wrote: > > > 在 2022/9/30 下午5:58, Krzysztof Kozlowski 写道: >> On 30/09/2022 11:35, Yinbo Zhu wrote: >>> Add the loongson2k High Precision Event Timer (HPET) binding >>> with DT schema format using json-schema. >>> >>> Signed-off-by: Yinbo Zhu >>> --- >>> .../bindings/timer/loongson,ls2k-hpet.yaml | 41 +++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 42 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml >>> new file mode 100644 >>> index 000000000000..1a8785076228 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml >>> @@ -0,0 +1,41 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Loongson2k High Precision Event Timer (HPET) >>> + >>> +maintainers: >>> + - Yinbo Zhu >>> + >>> +properties: >>> + compatible: >>> + const: loongson,ls2k-hpet >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clock-frequency: true >> >> clock frequency of what? I assume it's too early to use common clock >> framework and just get the clock? Still you did not answer: which/what clock? > The clock-frequency is 125000000, It doesn't support use common clock > framework But it should use CCF, if possible. > and just get the clock from dts, and I refer How do you "get" the clock from DTS? > "arm,armv7m-systick" to add the clock-frequency information: Better go with Common Clock Framework instead. > > clock-frequency: true > > oneOf: > - required: > - clocks > - required: > - clock-frequency >> Best regards, Krzysztof