From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF8FF3A6B8E for ; Thu, 21 May 2026 11:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779362354; cv=none; b=GZuqdNMDmq3e2SpR+sp7ivBEmJLSU9y7AI7V4oBpWE7c6zFHkXNc4pV52gGciopnJWvQE6A3eUjTWRp8sw3Oa7JVUXFqT0Jr7TV2YfxfuFj4cVtCD9ox3RIpoy79erW0b46Km3X2qiqehY60SW3cBdH5X7yhkmT+bA/HE3TYSWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779362354; c=relaxed/simple; bh=Va1tsaXau3ZOp4Fs1C6XDkNnNoOcNPKFH6zod0IfVuY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qzOi7FKd9nimxrd6uRTH8+jcEwnEVCJnvztXzW+n00cst1MkDGCPd/dDjVd5M8t3xJqZVN9RlCZOUGP1T5LeI4jxUboDds8UKxWeWvueWoGcrL7lDmbSTTdI1/zg8Z+ZqMLIXtmART9EPyym+2LTLay/KEdU/yZuIuwkpI8H0rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H4GNa20f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T4HOYb+v; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H4GNa20f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T4HOYb+v" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L99u1O3772914 for ; Thu, 21 May 2026 11:19:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= q7zTCbgzBEgy2rmz8Lm0pdUFHaG13OEbYSNtkZTbeHg=; b=H4GNa20fpZA3wcMy LobHT60IIU6ZNxgcEiPCX73buSLKX1O0Tx+ZduVLSb93fUh7qnO1NMQ3rbETM5aC ydoJA+9cLksq/me5mLfcJmLVV1IPx8pFdZsqDqML0D9pVsVQjk0lCVN+U4yO9R4u +aILbPfAfy5HrabDCnbPh3qR2j3U8/48x/F0SqqP2sXhzZZatgEqRyN3w1E9KdmY kaMzgai5M9NRRiMTSvKyvfn1HHwEexTKPZBo+4TpiY1Nib4aZv5tv8uplBW7nfml u59E/KyMAy2uErqx8IbHkkrRPTeCUV3L30kuB+5roxzrlg800GXh/RrTbeXVdtkZ 4cT/SQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ma42x4k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 11:19:11 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50faec938fcso15277021cf.3 for ; Thu, 21 May 2026 04:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779362350; x=1779967150; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q7zTCbgzBEgy2rmz8Lm0pdUFHaG13OEbYSNtkZTbeHg=; b=T4HOYb+v9yAfXR87qfMfX7Ra5/Epgmk25br5GGbtrNqRobeW19ScKksOw1flh/uRD/ AZDs4xKIBhyiyg4SBI+9wkrEY/vX8l3KXeGa91UIeNaSKGaK6l6oPRsuecIgUdP/hOhP /xkEBqUU90xJFc7zAu8dW4IV1Y0ALtQEw7NwX/Pw7PzGVDlLcjyevo5CrRdU57msI9WP wRbXiJKFkoPtW8JwaoAJdx4VebEY4VWKJeG+WHzXzDrZqksDXIZ8npauT3rg3epEMGMZ dYAUMunfS7W/3rqL+caOPPJt7YjkpdNADFLqmEUlM9RVIs51+gG9y4LFcSRSCwfOmlsS rjBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779362350; x=1779967150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q7zTCbgzBEgy2rmz8Lm0pdUFHaG13OEbYSNtkZTbeHg=; b=qZ/7rolnARDmPCbYw1cPLdhGjN73IRmPVL132vS/ecS5oSzR7a47bnGd8imjlrHzFh wxD8MhRwnx88L3oj4y86mUkwNztrUX4DCKCjLIbs3+V2KhMEkOdDsTsx3AJK97FL9J9q ydLd19isVfEVEJ8ZHgqNj5fh9f7kjlnWQP4jE02J/xTucU9suqij2WrMx/qGxMqpoG5c 3+83ZMr8rq3piudCQGDu+w339PHblC3TK+tKoMf80IlpAhJ152UvDZMJ4sw7Nwfr8/Jr i3xjjLZMs/nf3voa8al2nyBbZaOgZvKeCj562VTTk0ucVhZXnD1e+TDmU5kgQFAlQxpW 6KyA== X-Forwarded-Encrypted: i=1; AFNElJ+0s8ekR3SWek0UaWqF9OKqOuVLScSw3o/djN+R5MYdxAQs0uqxLR3UPMBMPGw8Ndv0dI46tIw1SCLkXTY=@vger.kernel.org X-Gm-Message-State: AOJu0YxA6Hl4RcAPBjhtQqokfNB42KR56PHW2oHAcKs5yI0uN1aTuVa/ sevS2zwj+i0CfAu9pQNk9zIh1yMAE+iZrLvvqr3VT6ndlYRCeEGVeN+eZhR7iWvFD1ar9RALIyF mCPlUTrvodSPN02fwTurgrWlsJPy6P5K2RdHXrSY4lqfoa1CYxmt0Ft2zQaFuZkjidHw= X-Gm-Gg: Acq92OHEpu0j4iLsK9mAuDAXtdOqa8q9zdCdA6do8I73gb9GRZu/qQ+k0xNbK2k3nEH /KTXcreC9cLKPndnpOw8yGV3Cqngjl9TOiCeQtbMmLXTYK30cJMsBBgXq01wX3MxLpXLqbiOSA9 6EUxGEOuiFi9mFUoievy7ptBuxF+MBbRdMrBe++PkOaXQOGsKrvZeMarhZNaFI9EeP0HRfnFADL 89UItd0czhwpx5ERgWcjvzG5fHYyVdxYGEim5OLlpxVP9F0FpzAnlo1lfqMypCCivFztuFKbsF7 qqGvZtfwSfn5O0R/EO0RCdYQAVL0yoR7idQVkc21j6siBDU4jO7np0cJXBsYCCkOHXQ4qIM9Jhx joeBGlYrPmg3p/HBWZ3+STFxHJb4Yv2Axrd9T5pXZvCQaxxYBzoYDCZ4hOBiKPcf+z6iyUX6XQx Uo3UM= X-Received: by 2002:a05:622a:4113:b0:509:e68:22cb with SMTP id d75a77b69052e-516c5646459mr20999961cf.5.1779362350126; Thu, 21 May 2026 04:19:10 -0700 (PDT) X-Received: by 2002:a05:622a:4113:b0:509:e68:22cb with SMTP id d75a77b69052e-516c5646459mr20999661cf.5.1779362349730; Thu, 21 May 2026 04:19:09 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bdc8a410c87sm32062966b.30.2026.05.21.04.19.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 04:19:08 -0700 (PDT) Message-ID: <69ad1327-8ef2-41c3-b07f-61d00e862904@oss.qualcomm.com> Date: Thu, 21 May 2026 13:19:06 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] powercap: qcom: Add SPEL powercap driver To: Manaf Meethalavalappu Pallikunhi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Bjorn Andersson , Konrad Dybcio , Daniel Lezcano Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Gaurav Kohli References: <20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com> <20260519-qcom_spel_driver_upstream-v1-2-75356d1b7f94@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260519-qcom_spel_driver_upstream-v1-2-75356d1b7f94@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=K9kS2SWI c=1 sm=1 tr=0 ts=6a0eea2f cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=fLRa9Tv8D7x8Vr91H4gA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: uM3DOKgFrEqqeB48n9RsI6jfXSsxzL52 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDExMiBTYWx0ZWRfX47HbMpuffuRh t01e/RumEeZzzP/I1aHPtpWB7mdaUnpj/w9vrYBSRcsoQxzk1Ve64r4OeRijOcFYsN6Uo9FiQTl o0Zdh00xg6hDr+uV7DMyBDbmMfQk2f72KLbei6dqntk1ww3EFuGUAEvJOS1I+lsRVNnRXtLt2tK H29RHbo08Z/tRE1UxjPNJaGYbd8Z/Aq2orBaiToBTGneenOIqVN0jsdilCWdgqUS3j0a7gcBWzI RQTYmhmlOzqP6ns1/9HnyzrcjxmG7+1EZ5J3qb5wTBrudoHw2fsQLt9a9rwtgwCA4yINzE8gsVf 1eM3EZl9tvEUYW192Qf+9Q8hdHFY8VaRYT/ejyY8Pgay8iL1/acXmAGA8Oau80TIOTRNF7J0cco qJTS6t6IniezJJS2iW+iFBvnkDUfiQQM2b1tocSHi/Le17oWxHVaeVMGe+sdfDPesWh8Zvq0ctx 1BuMQJnv7ghZvcG9BsQ== X-Proofpoint-ORIG-GUID: uM3DOKgFrEqqeB48n9RsI6jfXSsxzL52 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210112 On 5/19/26 12:49 PM, Manaf Meethalavalappu Pallikunhi wrote: > The Qualcomm SoC Power and Electrical Limits (SPEL) provides hardware > based power monitoring and limiting capabilities for various power > domains including System, SoC, CPU clusters, GPU, and various other > subsystems. > > The driver integrates with the Linux powercap framework, exposing SPEL > capabilities through powercap sysfs interfaces. > > Signed-off-by: Manaf Meethalavalappu Pallikunhi > --- [...] > +static const char *const spel_domain_names[] = { > + "sys", "soc", "cl0", "cl1", "cl2", "igpu", "dgpu", "nsp", > + "mmcx", "infra", "dram", "mdm", "wlan", "usb1", "usb2", "usb3", > +}; If the domain data is not going to change for future platforms (but e.g. only the offsets will), which I doubt, please use designated initializers Otherwise, please coalesce the names and offsets in a struct Konrad