From: Ira Weiny <ira.weiny@intel.com>
To: Sungwoo Kim <iam@sung-woo.kim>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Dan Williams" <dan.j.williams@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>
Cc: Dave Tian <daveti@purdue.edu>, Sungwoo Kim <iam@sung-woo.kim>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/hdm: fix a warning in devm_remove_action()
Date: Mon, 9 Mar 2026 14:31:05 -0500 [thread overview]
Message-ID: <69af1ff94c206_1a62c1100ce@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20260309000810.2632065-2-iam@sung-woo.kim>
Sungwoo Kim wrote:
> In the following race scenario, devm_remove_action() can be called
> before devm_add_action(), triggering a warning because there is no
> action to remove.
>
> To fix this, extend a critical section to embrace both
> __cxl_dpa_reserve() and devm_add_action().
>
> task 1:
> cxl_dpa_alloc()
> __cxl_dpa_reserve() ...(1)
> devm_add_action() ...(4)
>
> task 2:
> cxl_dpa_free()
> guard()
> if (!cxled->dpa_res) ...(2) pass, due to (1)
> return 0;
> devm_cxl_dpa_release()
> devm_remove_action() ...(3) warning, no action is added yet
>
> Warning log:
>
[snip]
>
> Fixes: cf880423b6a0 ("cxl/hdm: Add support for allocating DPA to an endpoint decoder")
> Fixes: 9c57cde0dcbd ("cxl/hdm: Enumerate allocated DPA")
> Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
[snip]
next prev parent reply other threads:[~2026-03-09 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 0:08 Sungwoo Kim
2026-03-09 19:31 ` Ira Weiny [this message]
2026-03-09 20:21 ` Dave Jiang
2026-03-24 4:06 ` Sungwoo Kim
2026-03-25 0:46 ` Alison Schofield
2026-03-25 22:34 ` Sungwoo Kim
2026-03-25 1:34 ` Dan Williams
2026-03-25 3:47 ` Sungwoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69af1ff94c206_1a62c1100ce@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=alison.schofield@intel.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=daveti@purdue.edu \
--cc=iam@sung-woo.kim \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®