From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D53CECDB482 for ; Thu, 19 Oct 2023 17:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346277AbjJSRda (ORCPT ); Thu, 19 Oct 2023 13:33:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235492AbjJSRd2 (ORCPT ); Thu, 19 Oct 2023 13:33:28 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBC73106; Thu, 19 Oct 2023 10:33:26 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39JHMWw4015395; Thu, 19 Oct 2023 17:33:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=hSDxNbot7+m/+CmxWZ/YuRhATf9AFer7UvRxZ/UJhh8=; b=Rx+tFQ4McqlKFSPTQvXuQc6/JfkltsqvEiyLjipSjlfcVA0+85MYhrhZytYSo9V7YjFV DEf/PduFO+nm0415OsV35r4bmdiucA9/gl8cP/bOz246qLzzmkp88T5l1UdCPtdV3bjs mV9vokh+g0x7G/lakE5hF64LvAQQHBhYw7cgBVIC4PCn5N4ry2dl6MHwhf8OANTSIjaE sagigS0GxgiZh0B9nZKp/YG5DLdVWhnh7YLLNjmaX2/Mqif7A9iXCAy6cIoptLYWzdZk ZXN88CUXRk4rRTjALKcRk+AWTnNMtwM9im7TnEFE04tljxK0GfdUVAu95l/x8drtO3P3 ug== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tu14cs6pr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 17:33:18 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39JHXHLK010429 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 17:33:17 GMT Received: from [10.48.241.70] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 19 Oct 2023 10:33:16 -0700 Message-ID: <69b0b9c8-d06f-46b5-8246-a2e1dce0d06f@quicinc.com> Date: Thu, 19 Oct 2023 10:33:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] wifi: ath12k: fix htt mlo-offset event locking Content-Language: en-US To: Johan Hovold , Kalle Valo CC: , , , References: <20231019113650.9060-1-johan+linaro@kernel.org> <20231019113650.9060-3-johan+linaro@kernel.org> From: Jeff Johnson In-Reply-To: <20231019113650.9060-3-johan+linaro@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: O8n16vmkdMIhsOECwXV-9vjXnY9_BkmW X-Proofpoint-ORIG-GUID: O8n16vmkdMIhsOECwXV-9vjXnY9_BkmW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-19_15,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=456 clxscore=1015 suspectscore=0 impostorscore=0 adultscore=0 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310190148 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2023 4:36 AM, Johan Hovold wrote: > The ath12k active pdevs are protected by RCU but the htt mlo-offset > event handling code calling ath12k_mac_get_ar_by_pdev_id() was not > marked as a read-side critical section. > > Mark the code in question as an RCU read-side critical section to avoid > any potential use-after-free issues. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Cc: stable@vger.kernel.org # v6.2 > Signed-off-by: Johan Hovold Acked-by: Jeff Johnson