From: Krzysztof Kozlowski <krzk@kernel.org>
To: linux@treblig.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] nfc: hci: Remove unused nfc_llc_unregister
Date: Wed, 19 Feb 2025 08:25:07 +0100 [thread overview]
Message-ID: <69b10d11-72d3-42b4-a7af-8c9e72476674@kernel.org> (raw)
In-Reply-To: <20250219020258.297995-1-linux@treblig.org>
On 19/02/2025 03:02, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> nfc_llc_unregister() has been unused since it was added in 2012's
> commit 67cccfe17d1b ("NFC: Add an LLC Core layer to HCI")
... and it is basically part of nfc_llc_exit() already, so no need to
call it.
I would like to see that you actually investigated that this cleanup
should not be called, instead of just blindly removing code.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-19 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 2:02 linux
2025-02-19 4:53 ` Kalesh Anakkur Purayil
2025-02-19 7:25 ` Krzysztof Kozlowski [this message]
2025-02-20 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b10d11-72d3-42b4-a7af-8c9e72476674@kernel.org \
--to=krzk@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®