From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 983CF35F60F for ; Mon, 10 Aug 2026 18:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385487; cv=none; b=ZxZ/nNPDvXCijEyvw9DK6S1dtmk0nmsK4R+LtJDcDA1qAr4m8e/LLdBnaNRsWBkZCr2xM+5OX6lv5JsLDsB8u8sbk75tTsEoLiAoEe7+fVFmCUPD8eVZBmjF95/cuIt8k5OsV8CeCM9ftqqjBwwHjmnuUGang0+DDi5KOs/i/Qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385487; c=relaxed/simple; bh=g3kQp8gGQiIXrYX4sT5ueXQYYRV5nEUtIvP3IlYpajE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sIQisGrizq15BNGmFEG5Kaz5lAKRthFAYPq3lxqYi/q28GeYDoDq+IgD0okO07w4YQP/v2k70uFtCjWQfPL0C9ThnF/LVB277uZTzaWBBlZNQt263/rC0I8KHLcP81gzlaXaL4LdCwonB9ow21wVSSRhJgfmqiaO2ywtScEqL78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TMrFm5ig; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TMrFm5ig" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cc7e86e7aeso24638185ad.2 for ; Mon, 10 Aug 2026 11:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385486; x=1786990286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L4Ymzks64fAO1V7KVTcq+phPVKZh8xNyMzo6gAaHxVg=; b=TMrFm5igAxgUXEyF3crAOJUjARaz4bTWF6sME7E4M5QIWqIgcm+rGYzC1m09vFTDEI dS/k5LlMQ1SoNUneKEN09KjHFMUjBieXy/2OrmhdGVC2R+05kvpEzrLYY8WHcjnOyXV2 EjAgWOB4w8rrvV3tqBXcKUH9KErHX2YLID7y2/WQkMlAP5L30exXvMDvZLF8+k8oudZT IkVr6DiO/YcD2mC4USrEKkCcKsJTDkvTQIuEJUccDICb/Iz3PVvkcwN+s9K2xL/8hEyV xzOWJ+g5bNMNlxKPh35FnVDRwP6fP5URAI8bcu5NENSNL7DzMIBYY1tDY8NDi92BvI8b Prhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385486; x=1786990286; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=L4Ymzks64fAO1V7KVTcq+phPVKZh8xNyMzo6gAaHxVg=; b=MXiT9igMf2b/k1PD6TvxR1buGdLw1ii3M2wIKjsVDO/0uDJN3p1f5xXvvOBUy3rz7D bewveO37IxKWgKV6VFpdZ/TI1BFcWdrdTHFIyhoaYHOfZ+itNPY5eYESb31vVSGTtdCM Z4ppyOOMsNtsMrQC116QMENs+PVNIiEJK+RJRqEhh+SjLYYUNQ/7yzAxvyNTEG05FeX8 HGqHwjzDPoarkFC6eQDsE7bYFJrQpOwr5Mng8F4k8927NEmr9lv1zbHmLART7hugXNf+ SR+RHbb+esog3PoRKitL1GF/4fCftt6pbJa9dGdi6gEtWDph9GjpBvgWu4iEYONSGdb3 dgmQ== X-Forwarded-Encrypted: i=1; AHgh+Rotss0V5vTFG35I/dj4eq2FKXrVechZtl5AdwWT6tv86dftdO3bBDTY6aZZz8XhXkwtrCFA/zN75aY75SA=@vger.kernel.org X-Gm-Message-State: AOJu0YzpNs+q4vINwwhq5QDXNMxFRg1WROW35OXCx80sV1v47jXznMBl BdSPtPUrbCUiOiQV/5Mq39FkkYWjWuQu8X1bQn66sJ8vvwlVUxTVtr0Y X-Gm-Gg: AR+sD123zKZUF3MphWf0opBKgYb+7Mraw9gt+S37v3TKLjoY927vTeuVdvdbfhWx6Iv zNz+A6nqcZlGH/mtyA5/rMIM0ePt6u7UTMdyyEyKwuTzFhmFWjL0GjpcC7sWr5CysCc2z2Vv9uh SHptQSAhLO6rqm/NJTo22enYSGr+Qy1n+XTlg8051RPZy3/leh5gC9WUim4NBa5/FhMlrC7mFy7 6P/eUgoNsbrlbGmpK7KftC2tzJyhab6vaxxzB2/N0AU+Vyu/x6ergbhQQA/UI3y8kbMhL0kGG7G e3rUGAf5aYICUyS+CFkle7y1UYu0G1to4PSfWPzi5xF5r1wMvCP7vaIwEPtZ/kR64fYFhqA3PO6 d4qmhOSxC+xCWQB/rpslkE1O5Mqk0O4lpjZBHbmAzL4DLW62mIbKrbEZ1IG50xUm3axktxktRr5 3CKBHKC6BcZR0bZqoK3XidfrHXXNTGYTz35QReSEQ0g17HX0//hIVAxLSk6FW9Hwk= X-Received: by 2002:a17:90b:2b8e:b0:38e:2e86:ed02 with SMTP id 98e67ed59e1d1-3909d8c5a4emr31571301a91.14.1786385485962; Mon, 10 Aug 2026 11:11:25 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:11:24 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v3 05/34] dmaengine: ep93xx: hook callbacks via dmaengine BH Date: Mon, 10 Aug 2026 11:09:06 -0700 Message-ID: <69b17379bf3c78b6af96dbe3b76940520d491417.1786384168.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dmaengine BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/ep93xx_dma.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c index 311e55a97ba9..d79e278fb7ba 100644 --- a/drivers/dma/ep93xx_dma.c +++ b/drivers/dma/ep93xx_dma.c @@ -167,7 +167,6 @@ struct ep93xx_dma_chan_cfg { * @dma_cfg: channel number, direction * @irq: interrupt number of the channel * @clk: clock used by this channel - * @tasklet: channel specific tasklet used for callbacks * @lock: lock protecting the fields following * @flags: flags for the channel * @buffer: which buffer to use next (0/1) @@ -196,7 +195,6 @@ struct ep93xx_dma_chan { struct ep93xx_dma_chan_cfg dma_cfg; int irq; struct clk *clk; - struct tasklet_struct tasklet; /* protects the fields following */ spinlock_t lock; unsigned long flags; @@ -801,9 +799,9 @@ static void ep93xx_dma_advance_work(struct ep93xx_dma_chan *edmac) spin_unlock_irqrestore(&edmac->lock, flags); } -static void ep93xx_dma_tasklet(struct tasklet_struct *t) +static void ep93xx_dma_tasklet(struct dma_chan *chan) { - struct ep93xx_dma_chan *edmac = from_tasklet(edmac, t, tasklet); + struct ep93xx_dma_chan *edmac = to_ep93xx_dma_chan(chan); struct ep93xx_dma_desc *desc, *d; struct dmaengine_desc_callback cb; LIST_HEAD(list); @@ -858,12 +856,12 @@ static irqreturn_t ep93xx_dma_interrupt(int irq, void *dev_id) switch (edmac->edma->hw_interrupt(edmac)) { case INTERRUPT_DONE: desc->complete = true; - tasklet_schedule(&edmac->tasklet); + dmaengine_schedule_bh(&edmac->chan); break; case INTERRUPT_NEXT_BUFFER: if (test_bit(EP93XX_DMA_IS_CYCLIC, &edmac->flags)) - tasklet_schedule(&edmac->tasklet); + dmaengine_schedule_bh(&edmac->chan); break; default: @@ -1420,7 +1418,7 @@ static struct ep93xx_dma_engine *ep93xx_dma_of_probe(struct platform_device *pde INIT_LIST_HEAD(&edmac->active); INIT_LIST_HEAD(&edmac->queue); INIT_LIST_HEAD(&edmac->free_list); - tasklet_setup(&edmac->tasklet, ep93xx_dma_tasklet); + dmaengine_init_bh(&edmac->chan, ep93xx_dma_tasklet); list_add_tail(&edmac->chan.device_node, &dma_dev->channels); -- 2.43.0