mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
	hmsjwzb <weizhefix@gmail.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix misspelling issue in fs/xfs/kmem.c
Date: Fri, 9 Nov 2018 17:45:21 -0600	[thread overview]
Message-ID: <69b1d0d9-5a5b-e11d-4ebe-eb49b9ba2ef3@sandeen.net> (raw)
In-Reply-To: <20181109234056.GH15721@magnolia>



On 11/9/18 5:40 PM, Darrick J. Wong wrote:
> On Sat, Nov 10, 2018 at 07:23:01AM +0800, hmsjwzb wrote:
> 
> Sorry, but all submissions must have a Signed-off-by: to be reviewed.
> 
> Also, there's no To: header on this message??

Also, it's not the only misspelling, and not even the only instance of
"auxillary" in the xfs codebase ... generally we only fix up such things
when we're touching surrounding code for a more substantive change.

-Eric

> NAK.
> 
> --D
> 
>> ---
>>  fs/xfs/kmem.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/kmem.c b/fs/xfs/kmem.c
>> index fdd9d6ede25c..73ec1f84e591 100644
>> --- a/fs/xfs/kmem.c
>> +++ b/fs/xfs/kmem.c
>> @@ -45,7 +45,7 @@ kmem_alloc_large(size_t size, xfs_km_flags_t flags)
>>  		return ptr;
>>  
>>  	/*
>> -	 * __vmalloc() will allocate data pages and auxillary structures (e.g.
>> +	 * __vmalloc() will allocate data pages and auxiliary structures (e.g.
>>  	 * pagetables) with GFP_KERNEL, yet we may be under GFP_NOFS context
>>  	 * here. Hence we need to tell memory reclaim that we are in such a
>>  	 * context via PF_MEMALLOC_NOFS to prevent memory reclaim re-entering
>> -- 
>> 2.17.1
>>
> 

      reply	other threads:[~2018-11-09 23:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 23:23 hmsjwzb
2018-11-09 23:40 ` Darrick J. Wong
2018-11-09 23:45   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69b1d0d9-5a5b-e11d-4ebe-eb49b9ba2ef3@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=darrick.wong@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=weizhefix@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®