mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Helen Koike <helen.koike@collabora.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Cc: <linux-arm-msm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema
Date: Fri, 3 May 2024 12:42:31 -0700	[thread overview]
Message-ID: <69b593b7-109c-825f-3dbb-5e8cce63ff01@quicinc.com> (raw)
In-Reply-To: <20240503-fd-fix-lxml-v2-2-f80a60ce21a1@linaro.org>



On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote:
> In order to validate drm/msm register definition files against schema,
> reuse the nodebugfs build step. The validation entry is guarded by
> the EXPERT Kconfig option and we don't want to enable that option for
> all the builds.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   drivers/gpu/drm/ci/build.sh  | 3 +++
>   drivers/gpu/drm/ci/build.yml | 1 +
>   2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
> index 106f2d40d222..28a495c0c39c 100644
> --- a/drivers/gpu/drm/ci/build.sh
> +++ b/drivers/gpu/drm/ci/build.sh
> @@ -12,6 +12,9 @@ rm -rf .git/rebase-apply
>   apt-get update
>   apt-get install -y libssl-dev
>   
> +# for msm header validation
> +apt-get install -y python3-lxml
> +
>   if [[ "$KERNEL_ARCH" = "arm64" ]]; then
>       GCC_ARCH="aarch64-linux-gnu"
>       DEBIAN_ARCH="arm64"
> diff --git a/drivers/gpu/drm/ci/build.yml b/drivers/gpu/drm/ci/build.yml
> index 17ab38304885..9c198239033d 100644
> --- a/drivers/gpu/drm/ci/build.yml
> +++ b/drivers/gpu/drm/ci/build.yml
> @@ -106,6 +106,7 @@ build-nodebugfs:arm64:
>     extends: .build:arm64
>     variables:
>       DISABLE_KCONFIGS: "DEBUG_FS"
> +    ENABLE_KCONFIGS: "EXPERT DRM_MSM_VALIDATE_XML"
>   

Wouldnt this end up enabling DRM_MSM_VALIDATE_XML for any arm64 device.

Cant we make this build rule msm specific?

  reply	other threads:[~2024-05-03 19:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 18:15 [PATCH v2 0/2] drm/msm/gen_header: allow skipping the validation Dmitry Baryshkov
2024-05-03 18:15 ` [PATCH v2 1/2] " Dmitry Baryshkov
2024-05-03 19:32   ` Abhinav Kumar
2024-05-08 22:41   ` Doug Anderson
2024-05-08 23:32     ` Abhinav Kumar
2024-05-03 18:15 ` [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema Dmitry Baryshkov
2024-05-03 19:42   ` Abhinav Kumar [this message]
2024-05-03 20:20     ` Dmitry Baryshkov
2024-05-03 22:38       ` Abhinav Kumar
2024-05-04  0:02         ` Dmitry Baryshkov
2024-05-04  0:07           ` Abhinav Kumar
2024-05-10 13:37             ` Helen Koike
2024-05-03 20:23 ` [PATCH v2 0/2] drm/msm/gen_header: allow skipping the validation Dmitry Baryshkov
2024-05-10 13:38   ` Helen Koike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69b593b7-109c-825f-3dbb-5e8cce63ff01@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=helen.koike@collabora.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®