From: "Thomas Hänig" <haenig@cosifan.de>
To: Takashi Iwai <tiwai@suse.de>, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Erik Schmauss <erik.schmauss@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>
Subject: Re: [REGRESSION 4.17] Spurious wakeup / reboot with power button
Date: Thu, 5 Jul 2018 20:18:29 +0200 [thread overview]
Message-ID: <69b98b03-4dbf-3a8d-6ae3-b9a6ffc92f0a@cosifan.de> (raw)
In-Reply-To: <s5hd0w1fwoq.wl-tiwai@suse.de>
Am 05.07.2018 um 18:56 schrieb Takashi Iwai:
> On Thu, 05 Jul 2018 18:02:11 +0200,
> Rafael J. Wysocki wrote:
>>
>> [The Lv's address is not valid any more, so drop it from the CC]
>>
>> On Thursday, July 5, 2018 5:10:20 PM CEST Rafael J. Wysocki wrote:
>>> On Thu, Jul 5, 2018 at 5:09 PM, Takashi Iwai <tiwai@suse.de> wrote:
>>>> On Thu, 05 Jul 2018 16:00:14 +0200,
>>>> Thomas H4nig wrote:
>>>>>
>>>>> Am 05.07.2018 um 14:12 schrieb Takashi Iwai:
>>>>>> On Thu, 05 Jul 2018 12:41:03 +0200,
>>>>>> Rafael J. Wysocki wrote:
>>>>>>>
>>>>>>> On Thursday, July 5, 2018 11:50:11 AM CEST Takashi Iwai wrote:
>>>>>>>> On Thu, 05 Jul 2018 11:34:59 +0200,
>>>>>>>> Rafael J. Wysocki wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> On Thu, Jul 5, 2018 at 9:05 AM, Takashi Iwai <tiwai@suse.de> wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> we've got a regression report since 4.17 about the behavior of
>>>>>>>>>> power-off with the power button. When a machine is powered off with
>>>>>>>>>> the power button on desktop, it reboots after a few seconds instead of
>>>>>>>>>> power down.
>>>>>>>>>>
>>>>>>>>>> The manual power down via "systemctl poweroff" works fine, so it's
>>>>>>>>>> possibly some spurious wakeup by the power button action, and some
>>>>>>>>>> ACPI-related change is suspected.
>>>>>>>>>> The regression still remains in 4.18-rc3.
>>>>>>>>>
>>>>>>>>> There are only a few ACPI commits directly related to power management
>>>>>>>>> between 4.16 and 4.17 and none of them looks particularly suspicious.
>>>>>>>>
>>>>>>>> OK, interesting.
>>>>>>>>
>>>>>>>>> It looks like the power button state may not be cleared sufficiently
>>>>>>>>> after it's been pressed which is now visible for some reason.
>>>>>>>>
>>>>>>>> Hmm, where can such a state remain? Since it happens after the
>>>>>>>> machine turned off, some (ACPI) wakeup bits?
>>>>>>>
>>>>>>> Basically, yes.
>>>>>>>
>>>>>>> It looks like a GPE may remain active which then triggers wakeup after
>>>>>>> shutdown.
>>>>>>>
>>>>>>> On a hunch, I'm wondering if reverting commit
>>>>>>>
>>>>>>> 18996f2db918 ACPICA: Events: Stop unconditionally clearing ACPI IRQs during suspend/resume
>>>>>>>
>>>>>>> (may not revert clearly, though) makes any difference.
>>>>>>
>>>>>> OK, I'm building a 4.17.x test kernel with that revert, in OBS
>>>>>> home:tiwai:bsc1099930 repo.
>>>>>>
>>>>>> Thomas, could you try later the kernel in
>>>>>> http://download.opensuse.org/repositories/home:/tiwai:/bsc1099930/standard/
>>>>>> ? It'll take an hour or so until the build finishes.
>>>>>
>>>>> With your new built kernel
>>>>> 4.17.4-1.g6f23755-default
>>>>>
>>>>> the power button works again, so the revert solved the problem
>>>>
>>>> Thanks, that clarifies the cause.
>>>> Adding Erik and Lv to Cc.
>>>>
>>>> I guess it's the side-effect by removing
>>>> acpi_ev_walk_gpe_list(acpi_hw_clear_gpe_block, NULL);
>>>> in acpi_hw_disable_all_gpes().
>>>>
>>>> This function is called from acpi_power_off_prepare(), and the machine
>>>> goes to power off without clearing the GPEs, hence it's woken up later
>>>> unexpectedly.
>>>
>>> That's correct.
>>>
>>> We need to fix up that commit. I'll try to prepare something.
>>>
>>
>> Below is a patch to test that theory and maybe fix things if it is correct.
>>
>> What it does is to clear all GPEs after disabling them in
>> acpi_power_off_prepare() which should address the issue if our theory
>> about the underlying reason is correct.
>>
>> Please test.
>
> OK, building a new test kernel package in OBS home:tiwai:bsc1099930-2
> repo. It'll appear at
> http://download.opensuse.org/repositories/home:/tiwai:/bsc1099930-2/standard/
>
> Thomas, please give it a try later.
>
>
> thanks,
>
> Takashi
Later will have to be tomorrow morning (07:00 UTC+2) as until then I
have no access to the machine in question.
Thanks
Thomas
next prev parent reply other threads:[~2018-07-05 18:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 7:05 Takashi Iwai
2018-07-05 9:34 ` Rafael J. Wysocki
2018-07-05 9:50 ` Takashi Iwai
2018-07-05 9:58 ` Thomas Hänig
2018-07-05 10:00 ` Takashi Iwai
2018-07-05 10:16 ` Rafael J. Wysocki
2018-07-05 10:41 ` Rafael J. Wysocki
2018-07-05 12:12 ` Takashi Iwai
2018-07-05 12:19 ` Thomas Hänig
2018-07-05 14:00 ` Thomas Hänig
2018-07-05 15:09 ` Takashi Iwai
2018-07-05 15:10 ` Rafael J. Wysocki
2018-07-05 16:02 ` Rafael J. Wysocki
2018-07-05 16:56 ` Takashi Iwai
2018-07-05 18:18 ` Thomas Hänig [this message]
2018-07-06 5:18 ` Thomas Hänig
2018-07-06 6:55 ` Takashi Iwai
2018-07-06 9:40 ` Rafael J. Wysocki
2018-07-06 9:53 ` Takashi Iwai
2018-07-06 11:12 ` Thomas Hänig
2018-07-06 11:21 ` Rafael J. Wysocki
2018-07-06 12:13 ` Rafael J. Wysocki
2018-07-06 12:27 ` Takashi Iwai
2018-07-06 12:53 ` Thomas Hänig
2018-07-06 17:57 ` Thomas Hänig
2018-07-08 8:18 ` Rafael J. Wysocki
2018-07-06 12:49 ` Thomas Hänig
2018-07-08 9:10 ` [PATCH] ACPICA: Clear status of all events when entering S5 Rafael J. Wysocki
2018-07-16 17:59 ` Schmauss, Erik
2018-07-17 7:23 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b98b03-4dbf-3a8d-6ae3-b9a6ffc92f0a@cosifan.de \
--to=haenig@cosifan.de \
--cc=erik.schmauss@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®