mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Jonas Gorski <jonas.gorski@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Broadcom internal kernel review list 
	<bcm-kernel-feedback-list@broadcom.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, Simon Arlott <simon@octiron.net>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irq-bcm6345-l1: do not assume a fixed block to cpu mapping
Date: Fri, 30 Jun 2023 16:29:09 +0200	[thread overview]
Message-ID: <69bcc286-f28f-0a41-8d39-0f1124f69ca8@broadcom.com> (raw)
In-Reply-To: <20230629072620.62527-1-jonas.gorski@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]



On 6/29/2023 8:26 AM, Jonas Gorski wrote:
> The irq to block mapping is fixed, and interrupts from the first block
> will always be routed to the first parent IRQ. But the parent interrupts
> themselves can be routed to any available CPU.
> 
> This is used by the bootloader to map the first parent interrupt to the
> boot CPU, regardless wether the boot CPU is the first one or the second
> one.
> 
> When booting from the second CPU, the assumption that the first block's
> IRQ is mapped to the first CPU breaks, and the system hangs because
> interrupts do not get routed correctly.
> 
> Fix this by passing the appropriate bcm6434_l1_cpu to the interrupt
> handler instead of the chip itself, so the handler always has the right
> block.
> 
> Fixes: c7c42ec2baa1 ("irqchips/bmips: Add bcm6345-l1 interrupt controller")
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

  parent reply	other threads:[~2023-06-30 14:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29  7:26 Jonas Gorski
2023-06-30 10:23 ` Philippe Mathieu-Daudé
2023-06-30 14:29 ` Florian Fainelli [this message]
2023-07-03 19:00 ` [irqchip: irq/irqchip-fixes] irq-bcm6345-l1: Do " irqchip-bot for Jonas Gorski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69bcc286-f28f-0a41-8d39-0f1124f69ca8@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=simon@octiron.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®