From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763068AbcINSzp (ORCPT ); Wed, 14 Sep 2016 14:55:45 -0400 Received: from host18.canaca.com ([66.49.204.205]:36114 "EHLO host18.canaca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbcINSzo (ORCPT ); Wed, 14 Sep 2016 14:55:44 -0400 Message-ID: <69c4e4c8a24f3e23cd6ae4287836940f.squirrel@mungewell.org> In-Reply-To: <1473461449-8060-4-git-send-email-simon@mungewell.org> References: <1473461449-8060-1-git-send-email-simon@mungewell.org> <1473461449-8060-4-git-send-email-simon@mungewell.org> Date: Wed, 14 Sep 2016 12:55:42 -0600 Subject: Re: [PATCH 4/5] HID:hid-logitech: Rewrite of descriptor for all DF wheels From: "Simon Wood" To: "Simon Wood" Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Kosina" , "Edwin Velds" , "Elias Vanderstuyft" , "Michal Maly" , "Simon Wood" User-Agent: SquirrelMail/1.5.2 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host18.canaca.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mungewell.org X-Get-Message-Sender-Via: host18.canaca.com: authenticated_id: simon@mungewell.org X-Authenticated-Sender: host18.canaca.com: simon@mungewell.org X-Source: X-Source-Args: X-Source-Dir: X-From-Rewrite: unmodified, already matched Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, September 9, 2016 7:34 pm, kbuild test robot wrote: > All warnings (new ones prefixed by >>): > > > drivers/hid/hid-lg.c: In function 'lg_report_fixup': > >>> drivers/hid/hid-lg.c:347:28: warning: unused variable 'rev_min' >>> [-Wunused-variable] >>> > __u16 bcdDevice, rev_maj, rev_min; > ^ > >>> drivers/hid/hid-lg.c:347:19: warning: unused variable 'rev_maj' >>> [-Wunused-variable] >>> > __u16 bcdDevice, rev_maj, rev_min; > ^ > >>> drivers/hid/hid-lg.c:347:8: warning: unused variable 'bcdDevice' >>> [-Wunused-variable] >>> > __u16 bcdDevice, rev_maj, rev_min; > ^ > >>> drivers/hid/hid-lg.c:346:32: warning: unused variable 'udesc' >>> [-Wunused-variable] >>> > struct usb_device_descriptor *udesc; ^ Hi all, No other comments from the rest of the patch set (so far), so I'll send a V2 patch set to cover these towards the end of the week. Also have better support for the "Wingman Forumula Force GT" to include, as I picked one up cheap on Kijiji. Simon.