From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2DCB408002 for ; Wed, 10 Jun 2026 13:46:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781099166; cv=none; b=Zy2/De/vo4P+8stppUaEe5+kdcWBX2M351HHHYt1bTvphcR4oZSx0DYgEypysM/kjABSOatNLVOn5vGdiMBMhCCmfHGb09LLC/n9MUWpdFz8KHlKSc9Cdso14szeHwHN59J7+mMMn7j4dLcmIyxXWqKN+CkDEGKrU+5hWy+tbZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781099166; c=relaxed/simple; bh=/SKklmSTWg0NDrPS5nK53kFHuLxXsbQJfhttvNNstCk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s9Jk6jkW9ljtViez9YolS06vd/uwkpjzcJVzBP047mvpVpLDf2rjMfs22Xm0sjbcYGzLefXMK40j+hsph96JkOaYBnkNI3npjKbzVb+kBrLNHKUclI6xrprByuPCdIoeC6e2dmmjQvUON+jXq73UvG8T8njwON7iOqankEd2m4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OPKfVCyJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DOSCK42/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OPKfVCyJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DOSCK42/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65ACC0Je1073299 for ; Wed, 10 Jun 2026 13:46:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= F9Qfs3uEyJpapaY7d3zFlRclpUk+M+Cozx7EeNpDX/s=; b=OPKfVCyJgcTC7bo/ 8vWGU7vdfVbwYGaNsUP+qxFUPTMiK3iyndW1+zHQf9WxZyLFc6/ZNzIdBzgU23tV +tDfudlnQ+gzpfqslG24ffuxY7ihxAdpgTA4k9NLKKL3UVX5BUoQKzP+YW3mmkRv gefoJkuZ5Njn8HvFXwiIAngsglzDJLxg9HfbpOaEjyJgeJEe0fUEiKdcUANiJrmS 9XEdc/Me6F2dsEOaaoByEweYK95CHJl6uMBqpf6Q7cZtUBDbYSExusdjjEz5beCy MZhVtc9tlnVrNRPlMytC9gFIxYndx/QeOjwQ3CCT1Qlzi8atYfl7kGkKD18flo7H BK4svw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epxuvje0j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Jun 2026 13:46:05 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-915737aaf0bso154986085a.3 for ; Wed, 10 Jun 2026 06:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781099164; x=1781703964; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F9Qfs3uEyJpapaY7d3zFlRclpUk+M+Cozx7EeNpDX/s=; b=DOSCK42/tRiVRaOexAfWihmqEXO4jwc0AKxIrpp7Dfk1e2YA+CW4l2S69FCuPcWrxp V7mSxcMIKB8LYNwAR6O31IdMmarBGrrkbhaiIC2/9RRG5R+VW2GpNz8QiNtCZHoeJXby 4uHp6r+QviXMRCQkNq53iB0POWB+0jhLksC3FfGCdZOeq+JdYwrzTOYJKkJPNlZy1qLw oZf37u1B7TCTpD8wA3KJ+myYGiWDYOCUQ5bzBxXI2ab9cFPcD7wCeg/q+ytOn3Y5Mw6H tzw2pnKb/cPGwp4+qnBzLBsW07mWOi2A1jaeVkq2qjDa8zdVTURpIW2decXJ7CydAN8b EkpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781099164; x=1781703964; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F9Qfs3uEyJpapaY7d3zFlRclpUk+M+Cozx7EeNpDX/s=; b=Cli2RVIHDzFpPznH2IFe9CZ0ItyfTnDrJ3pq5MOMEhQVr01nQHS+auiIAqwDBoMqAj 3jAlPvHaOIoCQxVCDOZRpZE+iXPcv37Nab236oV6c7m2bF+xB4+1NBwqn4zZ2pHuUMKe 2UqAFdhHPJ6ebYBWnlphhtS/9KMpjGBafOUyIvggvbwesD1QJar4c1UrxadguM1GVC0E Iw0PjrAb5TXvrXfkRq76F8BP5ZYIkQmhAIzERAyL87Zl4TsA/4svaFPLBgw/kZ0hYYq3 Fa5Z1bCWR42mjmeaxMDHHNT11OGdzO+IkfAIkVZiydfIb7U3f03UorHia9H3fOQ4T3a1 B7DQ== X-Forwarded-Encrypted: i=1; AFNElJ/9982nqOSpo38JCZGAIk4qEpuJJXNV17O+0WPOO7vWGK80JUyggF7sPMwlV9qS7W0mZeqCfXuGyAUfTyg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzoe+YExYyqZP9eUZypSpCCSRjEe5Q87lJn1DHWLItN3L7sCZ3U vysotdDQNTzbhNwofRVXAzTsPqNdd+esRAyMndQxrGOiGUfuaGsKC4LDCkuAs+8ZQcyj1BzDJWI D0XOHVN5txk31AL/WicGyRvtvCU3rRV4G6FL5V0vLrGnYycEHxif0Zy4dDJirsIsEK3I= X-Gm-Gg: Acq92OHluHDNoZc32LU8SDdxRhmDwIkAasQuLXdNK8y3J3i5lnS4I/7SZiV2TItuYed IsgJDoxEd1ZejAzfXDIvWxlv/Rd7qHzZdCXpXRTaBi504fKz8/AZjkctyX6Z6+wnzeXijpahTwl ZVqn6/T8G8ko+S1hqMvtKaDow/P+lbG1pS3bDwQDG0OcLaRKyIdWXvyccKg1dQG2m2vmEon7w33 r1Y3rNGlFTlj+i8dK0mRwp+AQas/+P8emOn3m8q7IaQeTbwZ1MfOVe9HcENUWlOpA57cMPN7cvd LB3BB0HUIb6jVFA0xiN/u6Uhmgl/1ApLpSpHYUapS+H+O43KWRZXKxzGxFfwtun9uhIBDPmgtDB KWW08LXsHM7XGvGkXN38qfMnW5GRgBckOfw2EAQTBDNCb/P9usEO9mI10 X-Received: by 2002:a05:620a:3723:b0:8f3:5988:f97c with SMTP id af79cd13be357-915e6d7a437mr766630585a.3.1781099163989; Wed, 10 Jun 2026 06:46:03 -0700 (PDT) X-Received: by 2002:a05:620a:3723:b0:8f3:5988:f97c with SMTP id af79cd13be357-915e6d7a437mr766626185a.3.1781099163460; Wed, 10 Jun 2026 06:46:03 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf052097992sm1226019366b.26.2026.06.10.06.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jun 2026 06:46:02 -0700 (PDT) Message-ID: <69cc948f-bb4f-49e7-b050-9e3805aef758@oss.qualcomm.com> Date: Wed, 10 Jun 2026 15:46:00 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/12] clk: qcom: gcc-mdm9607: Fix BIMC PLL definition To: Stephan Gerhold , Bjorn Andersson Cc: Michael Turquette , Stephen Boyd , Georgi Djakov , Shawn Guo , Bryan O'Donoghue , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org> <20260609-qcom-clk-mdm9607-fixes-v1-4-5e9717faf842@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260609-qcom-clk-mdm9607-fixes-v1-4-5e9717faf842@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: tREa-0NAk3Y6_CAjLG1YN1jDRDpDQgER X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEwMDEzMSBTYWx0ZWRfXzfwYh1rLyGLT sqC/9WzGhmeAyDDo7oG1C/pE10B0qn/E4xhM1EFl9Z/MdlyVJna2d+jeR1IP//WArYnHznCv2S5 +zt40m23ZfbODJwwbfK/w2KsV2alJh6LDRudBvPts7LtvDMFNn+ltb3iV3jE5M6V9bb51TFm6Uq IEBR+80bQd58cde5NgHPPCnJz0CK5/v1LERIrBpu81Qee2NiMU6lgrFyE8/OVxxWvf4Jl9EhveF g0AlsXG8JLvJBQ/Y4jZAdfucKWwLX6lRaNSW8kohDvAwfPmFP5fQOYURV+qUHuMkiC1nmm/bHvW 0YWnQWzM2UD+Wksce61rdGp0IyHt0FWMZLSdXkSgSOxCL3huKI6fohumriH0GAFj3FTG4ZXlQyH JLnW/3+iUdns1DRGHc46ukhzR8AWcMa3mtGk/U0CeJIqlPO1KHhZgwjvzIuatcHL6PU2NZHvpdg M3ijGteUSNrweAK0RQQ== X-Authority-Analysis: v=2.4 cv=Co+PtH4D c=1 sm=1 tr=0 ts=6a296a9d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=j8Cu_9a8AAAA:8 a=VwQbUJbxAAAA:8 a=oZK_lny2TaSriTy3aD0A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=A2jcf3dkIZPIRbEE90CI:22 X-Proofpoint-ORIG-GUID: tREa-0NAk3Y6_CAjLG1YN1jDRDpDQgER X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-10_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606100131 On 6/9/26 4:14 PM, Stephan Gerhold wrote: > From: Stephan Gerhold > > The gcc-mdm9607 driver was originally based on gcc-msm8916, but a closer > match nowadays is gcc-msm8909. Looking at the differences between > gcc-mdm9607 and gcc-msm8909, there is quite some confusion around the > definitions for the BIMC PLL. > > It turns out the BIMC PLL on MDM9607 is actually an Alpha PLL just like on > MSM8909. We can vote for it using BIT(2), which explains why BIT(3) was > used for GPLL2. > > Replace the definitions of the BIMC PLL in gcc-mdm9607 with the ones from > gcc-msm8909 to make sure we read the PLL status correctly and don't make > accidental incorrect changes to the PLL configuration. With this change, > the rate of the BIMC PLL (600.6 MHz) is displayed correctly in debugfs. > > The clock naming typically used for Alpha PLLs differs from the older vote > PLLs. There is no device tree upstream for MDM9607 yet, so we can still > safely change the dt-bindings. Nevertheless, by keeping the old ID values > and swapping the two entries we can preserve ABI compatibility for compiled > DTBs. Previously, BIMC_PLL_VOTE (71) was the final PLL clock to reference > when needed, this is now just BIMC_PLL. The previous parent BIMC_PLL (70) > is now the parent BIMC_PLL_EARLY clock. > > Cc: stable@vger.kernel.org > Fixes: 48b7253264ea ("clk: qcom: Add MDM9607 GCC driver") > Signed-off-by: Stephan Gerhold > --- I think we may be better off removing the NoC PLLs and defer controlling them to RPM, on all platforms that define them.. Konrad