From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prasanth Kumar Padarthi <prasanth.padarthi10@gmail.com>,
linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
linux-kernel@vger.kernel.org, joel@jms.id.au,
ryan_chen@aspeedtech.com, tan.siewert@9elements.com
Subject: Re: [RFC PATCH] soc: aspeed: Add B650D4U power passthrough support
Date: Sat, 3 Oct 2026 15:54:07 +0200 [thread overview]
Message-ID: <69da1928-1ebe-44b1-891b-a0dd7d0b21f3@kernel.org> (raw)
In-Reply-To: <20261002131634.113680-1-prasanth.padarthi10@gmail.com>
On 02/10/2026 15:16, Prasanth Kumar Padarthi wrote:
> Add the AST2600 SCU passthrough selector support used by the
> ASRock Rack B650D4U host power-control circuit. This RFC includes
> the driver, Devicetree binding, and board node to discuss the final
> kernel-facing interface.
>
> Signed-off-by: Prasanth Kumar Padarthi <prasanth.padarthi10@gmail.com>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
> ---
> .../asrock,b650d4u-power-passthrough.yaml | 23 ++++
Bindings for a driver is a no-go (for longer explanation see
writing-bindings, any tutorials or DTS101 slides).
> .../dts/aspeed/aspeed-bmc-asrock-b650d4u.dts | 5 +
> drivers/soc/aspeed/Kconfig | 9 ++
> drivers/soc/aspeed/Makefile | 1 +
> drivers/soc/aspeed/aspeed-b650d4u-power.c | 110 ++++++++++++++++++
Soc drivers should not expose user-space interfaces. Use existing
suitable subsystems.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-10-03 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 13:16 Prasanth Kumar Padarthi
2026-10-02 16:47 ` Tan Siewert
2026-10-02 17:28 ` Prasanth
2026-10-03 13:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69da1928-1ebe-44b1-891b-a0dd7d0b21f3@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanth.padarthi10@gmail.com \
--cc=ryan_chen@aspeedtech.com \
--cc=tan.siewert@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®