From: Stefan Metzmacher <metze@samba.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Michal Luczaj <mhal@rbox.co>,
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
Marcel Holtmann <marcel@holtmann.org>, David Wei <dw@davidwei.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: SCO: check for codecs->num_codecs == 1 before assigning to sco_pi(sk)->codec
Date: Wed, 8 Apr 2026 10:16:27 +0200 [thread overview]
Message-ID: <69dce63c-f5e9-4e21-9665-be0889fe6334@samba.org> (raw)
In-Reply-To: <CABBYNZJMY-MH+1H0kFoXPxuKbjjWaPDzzaxX=-C9uwYtdxWo4Q@mail.gmail.com>
Hi Luiz,
>>> I guess this is odd because there was no need for this code to exist,
>>> BT_CODEC should have used struct bt_codec rather than struct bt_codecs
>>> since we can only set exactly one codec, that said I don't think we
>>> can change this now thus why we need to perform these checks, anyway
>>> back to your changes why don't we have both checks for num_codecs != 1
>>> && optlen < struct_size(codecs, codecs, codecs->num_codecs)) since the
>>> handling is the same?
>>
>> Should I submit a v2 using this:
>> if (codecs->num_codecs != 1 || optlen < struct_size(codecs, codecs, codecs->num_codecs))
>>
>> Or can you to take it from here?
>> As I don't really care and the patch is not strictly needed.
>
> I can fix it myself, no problem.
Great! Thanks!
metze
prev parent reply other threads:[~2026-04-08 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 15:13 Stefan Metzmacher
2026-04-07 16:37 ` Luiz Augusto von Dentz
2026-04-07 16:45 ` Stefan Metzmacher
2026-04-07 17:02 ` Luiz Augusto von Dentz
2026-04-08 8:16 ` Stefan Metzmacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69dce63c-f5e9-4e21-9665-be0889fe6334@samba.org \
--to=metze@samba.org \
--cc=dw@davidwei.uk \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=luiz.von.dentz@intel.com \
--cc=marcel@holtmann.org \
--cc=mhal@rbox.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®