mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] usb: mon: make mmapped memory read only
Date: Fri, 16 Sep 2022 21:14:11 -0700	[thread overview]
Message-ID: <69ddd90e-91fa-78d7-63e6-9d6a8036c6b5@linaro.org> (raw)
In-Reply-To: <20220916224741.2269649-1-tadeusz.struk@linaro.org>

On 9/16/22 15:47, Tadeusz Struk wrote:
> Syzbot found an issue in usbmon where it can corrupt monitor
> internal memory causing the usbmon to crash with segfault,
> UAF, etc. The reproducer mmaps the /dev/usbmon memory to userspace
> and overwrites it with arbitrary data, which causes the issues.
> To prevent that explicitly clear the VM_WRITE flag in mon_bin_mmap().
> 
> Cc:linux-usb@vger.kernel.org
> Cc:linux-kernel@vger.kernel.org
> Cc:stable@vger.kernel.org
> Fixes: 6f23ee1fefdc ("USB: add binary API to usbmon")
> Link:https://syzkaller.appspot.com/bug?id=2eb1f35d6525fa4a74d75b4244971e5b1411c95a
> Signed-off-by: Tadeusz Struk<tadeusz.struk@linaro.org>

I forgot to add:
Reported-by: syzbot+23f57c5ae902429285d7@syzkaller.appspotmail.com

-- 
Thanks,
Tadeusz


  reply	other threads:[~2022-09-17  4:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-16 22:47 Tadeusz Struk
2022-09-17  4:14 ` Tadeusz Struk [this message]
2022-09-19  4:25 ` Dmitry Vyukov
2022-09-19 11:21   ` Dmitry Vyukov
2022-09-19 14:53   ` Tadeusz Struk
2022-09-19 21:59 ` [PATCH v2] " Tadeusz Struk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69ddd90e-91fa-78d7-63e6-9d6a8036c6b5@linaro.org \
    --to=tadeusz.struk@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®