From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0993E7D0BB for ; Fri, 22 Sep 2023 01:28:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbjIVB2r (ORCPT ); Thu, 21 Sep 2023 21:28:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjIVB2q (ORCPT ); Thu, 21 Sep 2023 21:28:46 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D35A8CF; Thu, 21 Sep 2023 18:28:40 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38M1AUpI031994; Fri, 22 Sep 2023 01:28:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=WN0AuIlO6OWJQbJExDLJ00O1apLzzc782qZ8sd/5w4Y=; b=CfroBfXPzklE1VHVTPAfGR4Q3JhD5WeATQL1ZPaovfRG8kPqq5AFjda1T6HuYbRUDKVN zV+yp7BOswItMztdGQpvpBuGibtNGrCjEXaFbHHxuvJpLiRl1ws2t57m58k0Sx97HIPq h66OWymfQjTdr+GU+Dyce3t7SlbV8z+yWz7PPiyy+qY0Mk6/UJJl7K8cTP7o1UEUsPpg XBf50TCm9iEc8eOoRadG7lq8nthTN2moOp7IlWREiFPaZWZIil4wW9VxfQSn/YLHLfMX UVi4sgbFaCpYt+85l2mxjGqTsivgR46INKzx6iLEQ+uL0DBMIIIg0V9S/deqXo2lefdE lA== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t8uknrkhx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Sep 2023 01:28:10 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38M1S9FG014287 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Sep 2023 01:28:09 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Thu, 21 Sep 2023 18:28:01 -0700 Message-ID: <69ded869-4cdf-4b68-bcb6-8168d625d779@quicinc.com> Date: Fri, 22 Sep 2023 09:27:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] arm64: dts: qcom: sm4450: Add RPMH and Global clock To: Konrad Dybcio , , , , , , , , , CC: , , , , , , , , , , , , , , , , , References: <20230920065459.12738-1-quic_tengfan@quicinc.com> <20230920065459.12738-4-quic_tengfan@quicinc.com> <21b8b019-42b8-6e47-e640-8bca28d2d784@linaro.org> From: Tengfei Fan In-Reply-To: <21b8b019-42b8-6e47-e640-8bca28d2d784@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: qupHyuvlROhrxNyBxkRCQr8r4gEpRAhF X-Proofpoint-ORIG-GUID: qupHyuvlROhrxNyBxkRCQr8r4gEpRAhF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-22_01,2023-09-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=927 priorityscore=1501 phishscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309220011 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 9/20/2023 6:00 PM, Konrad Dybcio 写道: > > > On 9/20/23 08:54, Tengfei Fan wrote: >> Add device node for RPMH and Global clock controller on Qualcomm >> SM4450 platform. >> >> Signed-off-by: Ajit Pandey >> Signed-off-by: Tengfei Fan >> --- >>   arch/arm64/boot/dts/qcom/sm4450.dtsi | 23 +++++++++++++++++++++++ >>   1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi >> b/arch/arm64/boot/dts/qcom/sm4450.dtsi >> index 3d9d3b5e9510..c27f17a41699 100644 >> --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi >> @@ -3,6 +3,8 @@ >>    * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights >> reserved. >>    */ >> +#include >> +#include > These should be sorted alphabetically.Yes, I will sort these alphabetically. > > [...] > >> +            rpmhcc: clock-controller { >> +                compatible = "qcom,sm4450-rpmh-clk"; >> +                #clock-cells = <1>; >> +                clock-names = "xo"; >> +                clocks = <&xo_board>; > property > property-names > > Konrad Hi Konrad, Sure, I will adjust these noeds. -- Thx and BRs, Tengfei Fan