From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F080C4742C for ; Fri, 30 Oct 2020 01:52:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 419F120723 for ; Fri, 30 Oct 2020 01:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbgJ3Bw3 (ORCPT ); Thu, 29 Oct 2020 21:52:29 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7100 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726350AbgJ3BwS (ORCPT ); Thu, 29 Oct 2020 21:52:18 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CMlg60RdbzLmp9; Fri, 30 Oct 2020 09:52:18 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 30 Oct 2020 09:52:15 +0800 Subject: Re: [f2fs-dev] [PATCH v5 2/2] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION ioctl To: Eric Biggers CC: Daeho Jeong , , , , "Daeho Jeong" References: <20201029041538.4165209-1-daeho43@gmail.com> <20201029041538.4165209-2-daeho43@gmail.com> <92f4da8e-27a1-7577-84f9-39038eaa88cb@huawei.com> <20201029155453.GB849@sol.localdomain> From: Chao Yu Message-ID: <69dfcb36-158c-e524-494c-6c5377a56945@huawei.com> Date: Fri, 30 Oct 2020 09:52:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20201029155453.GB849@sol.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/10/29 23:54, Eric Biggers wrote: > Note that my intent with recommending ENOPKG was for it to be returned in the > !f2fs_cops[algorithm] case, similar to how opening an encrypted file when the > encryption algorithm is recognized but not supported by the kernel returns > ENOPKG. For a truly unrecognized algorithm (algorithm >= COMPRESS_MAX), EINVAL > would probably be more appropriate. So if !f2fs_cops[algorithm] is now allowed, > then ENOPKG should no longer be among the error codes this ioctl returns. Agreed. Thanks, > > - Eric > . >