From: David Hildenbrand <david@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
James Hogan <james.hogan@imgtec.com>,
Paul Mackerras <paulus@ozlabs.org>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH v2 1/5] KVM: rename API for requests to match bit operations
Date: Mon, 27 Feb 2017 10:54:09 +0100 [thread overview]
Message-ID: <69dff1a5-6af4-ce1e-bb5c-3e3adb1ee6ae@redhat.com> (raw)
In-Reply-To: <20170224195002.28030-2-rkrcmar@redhat.com>
Am 24.02.2017 um 20:49 schrieb Radim Krčmář:
> kvm_make_request was a wrapper that added barriers to set_bit and
> kvm_check_request did the same for test_bit and check_bit, but the name
> was not very obvious.
>
> The renaming:
> kvm_request_set <- kvm_make_request
> kvm_request_test_and_clear <- kvm_check_request
>
What about kvm_req_set() / kvm_req_test_and_clear()
Matches the request bit definitions (KVM_REQ_*) and saves a couple of
characters.
Anyhow
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David
next prev parent reply other threads:[~2017-02-27 10:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 19:49 [PATCH v2 0/5] KVM: rename and encapsulate vcpu->requests API Radim Krčmář
2017-02-24 19:49 ` [PATCH v2 1/5] KVM: rename API for requests to match bit operations Radim Krčmář
2017-02-27 9:54 ` David Hildenbrand [this message]
2017-03-01 16:37 ` Radim Krčmář
2017-02-24 19:49 ` [PATCH v2 2/5] KVM: add KVM request variants without barrier Radim Krčmář
2017-02-27 10:02 ` David Hildenbrand
2017-02-27 10:18 ` David Hildenbrand
2017-03-01 16:58 ` Radim Krčmář
2017-02-28 7:34 ` Peter Xu
2017-02-28 7:40 ` Peter Xu
2017-03-01 17:02 ` Radim Krčmář
2017-03-02 1:15 ` Peter Xu
2017-03-02 2:26 ` Peter Xu
2017-02-24 19:50 ` [PATCH v2 3/5] KVM: add kvm_request_pending Radim Krčmář
2017-02-27 10:02 ` David Hildenbrand
2017-02-24 19:50 ` [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear Radim Krčmář
2017-02-27 8:45 ` Andrew Jones
2017-02-27 10:03 ` David Hildenbrand
2017-02-28 11:29 ` James Hogan
2017-03-01 17:04 ` Radim Krčmář
2017-02-24 19:50 ` [PATCH v2 5/5] KVM: optimize kvm_make_all_cpus_request Radim Krčmář
2017-02-27 8:47 ` [PATCH v2 0/5] KVM: rename and encapsulate vcpu->requests API Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69dff1a5-6af4-ce1e-bb5c-3e3adb1ee6ae@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=drjones@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®